feature(route guarding): incomplete #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach
Added new file guard.js to define a new component called GuardedRoute, which would check for authentication before rendering the component. Otherwise would redirect to login page.
I wanted to use this component to check if there was an active token, but my approach doesn't seem to be fully working.
'props.auth.token' returns undefined. I have attempted this task multiple times and there always seems to be a slight error. Not familiar enough with React to know the best practices here.
Links
https://www.freecodecamp.org/news/a-complete-beginners-guide-to-react-router-include-router-hooks/#guarding-routes
https://dev.to/karanpratapsingh/private-public-and-restricted-routes-in-react-42ff
https://medium.com/weekly-webtips/protect-your-route-with-protectedroute-and-guards-in-reactjs-2db83ec48860
Doesn't quite solve #21