Skip to content

Fix Order Form Submit Bug #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
17 changes: 12 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@ This project represents a challenge to test your git flow, programming, and trou
## Challenge Instructions
You will begin by creating a fork of this repository to your own Github account. All work will be completed and reviewed within your own fork. Please do not create a Pull Request (PR) back into this repository.

Once you have created your fork, review the Issues labeled `challenge task` [HERE](https://github.com/Shift3/react-challenge-project/issues?q=is%3Aissue+is%3Aopen+label%3A%22challenge+task%22). Work on each task in a new branch. Once the work is completed, create a Pull Request from the working branch to your `master` branch and reference the Issue you are working on. These open PRs will be the final submission which Shift3 will review.
Once you have created your fork, review the Issues labeled `challenge task` [HERE](https://github.com/Shift3/react-challenge-project/issues?q=is%3Aissue+is%3Aopen+label%3A%22challenge+task%22). Shift3's standard for branching is as follows:

- Maintain a `master` and development (`dev`) branch on your fork
- For each new feature (issue), create a branch based off of your `dev` branch
- Once your feature has been completed, submit a Pull Request from your feature branch to your `dev` branch
- If you have a reviewer on your repository, once your Pull Request has been approved, merge your feature branch back into `dev`
- Otherwise, submit the Pull Request and merge it into your `dev` branch
- Once the work has been completed, create a Pull Request from the working branch to your `master` branch and reference the Issue you are working on. These open PRs will be the final submission which Shift3 will review.

Once you are ready to submit your work, send an email to your Shift3 contact with a link to your fork.

Expand All @@ -24,10 +31,10 @@ This is a multi-container docker environment that utilizes Docker to create thre
## Project Requirements

- Docker
- [For Mac Users](https://docs.docker.com/docker-for-mac/install/)
- [For Windows 10 Pro/Enterprise Users](https://docs.docker.com/docker-for-windows/install/)
- [For Windows 7 or Windows 10 home Users](https://docs.docker.com/toolbox/toolbox_install_windows/)
- Kitematic should come automatically installed, with Docker, but make sure you have it available, it will be very useful in managine containers
- For Mac Users: [Docker Desktop for Mac](https://docs.docker.com/docker-for-mac/install/)
- For Windows 10 Pro/Enterprise Users: [Docker Desktop for Windows](https://docs.docker.com/docker-for-windows/install/)
- For Windows 7 or Windows 10 home Users: [Docker Toolbox](https://docs.docker.com/toolbox/toolbox_install_windows/)
- For Linux Users (follow link and choose your Distro): [Docker Engine](https://docs.docker.com/engine/install/)
- Do not have anything running on the required ports (3000 for client, 4000 for server, 27017 for mongo.)

## Running the project
Expand Down
2 changes: 1 addition & 1 deletion application/src/components/order-form/orderForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class OrderForm extends Component {
}

menuItemChosen(event) {
this.setState({ item: event.target.value });
this.setState({ order_item: event.target.value });
}

menuQuantityChosen(event) {
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ services:
- server
volumes:
- ./application:/home/node/application
- home/node/application/node_modules
- /home/node/application/node_modules

server:
build: './server'
Expand All @@ -23,7 +23,7 @@ services:
- database
volumes:
- ./server:/home/node/server
- home/node/server/node_modules
- /home/node/server/node_modules
database:
image: "mongo"
networks:
Expand Down