rip custom productElementLabel - use standard productElementName instead #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure about the exact history, but I guess back in the days we simply didn't notice that `Product.productElementName` exists, and therefor added `StoredNode.productElementLabel` and tweaked the pretty printer in joern. This can be done much simpler...
|
i prepared the changes in joern locally already.. |
maltek
approved these changes
Feb 16, 2023
|
maybe the idea was that the label can be an even prettier string than the field name? |
delete-merged-branch
bot
deleted the
michael/rip-product-element-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the exact history, but I guess back in the days we
simply didn't notice that
Product.productElementNameexists, andtherefor added
StoredNode.productElementLabeland tweaked the prettyprinter in joern. This can be done much simpler...