Add missing write barriers #32
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was defined in Ruby 2.1 and the gemspec specifies 3.1 as a requirement.
|
Looking at the crashing func: static VALUE grpc_rb_call_credentials_callback(VALUE args) {
VALUE result = rb_hash_new();
VALUE callback_func = rb_ary_entry(args, 0);
VALUE callback_args = rb_ary_entry(args, 1);
VALUE md_ary_obj = rb_ary_entry(args, 2);
VALUE callback_func_str = rb_funcall(callback_func, rb_intern("to_s"), 0);
VALUE callback_args_str = rb_funcall(callback_args, rb_intern("to_s"), 0);
VALUE callback_source_info =
rb_funcall(callback_func, rb_intern("source_location"), 0);
grpc_absl_log_str(
GPR_DEBUG, "GRPC_RUBY: grpc_rb_call_credentials invoking user callback:",
StringValueCStr(callback_func_str));
if (callback_source_info != Qnil) {
VALUE source_filename = rb_ary_entry(callback_source_info, 0);
VALUE source_line_number =
rb_funcall(rb_ary_entry(callback_source_info, 1), rb_intern("to_s"), 0);
grpc_absl_log_str(GPR_DEBUG, "GRPC_RUBY: source_filename: ",
StringValueCStr(source_filename));
grpc_absl_log_str(GPR_DEBUG, "GRPC_RUBY: source_line_number: ",
StringValueCStr(source_line_number));
grpc_absl_log_str(GPR_DEBUG, "GRPC_RUBY: Arguments: ",
StringValueCStr(callback_args_str));
} else {
grpc_absl_log_str(
GPR_DEBUG, "(failed to get source filename and line) with arguments: ",
StringValueCStr(callback_args_str));
}
VALUE metadata =
rb_funcall(callback_func, rb_intern("call"), 1, callback_args);
grpc_metadata_array* md_ary = NULL;
TypedData_Get_Struct(md_ary_obj, grpc_metadata_array,
&grpc_rb_md_ary_data_type, md_ary);
grpc_rb_md_ary_convert(metadata, md_ary);
rb_hash_aset(result, rb_str_new2("metadata"), metadata);
rb_hash_aset(result, rb_str_new2("status"), INT2NUM(GRPC_STATUS_OK));
rb_hash_aset(result, rb_str_new2("details"), rb_str_new2(""));
return result;
}There ware multiple objects we're calling From there, look at the code to see which object is responsible for holding them, and where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing write barriers to address segfaults like this:
where we end up trying to call methods on
T_NONEobjects