Skip to content

chore: less strict theme type #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Krisztiaan
Copy link

@Krisztiaan Krisztiaan commented Jan 27, 2022

With this change, and eventually providing default generics, where appropriate, you could extend restyle with the theme.

declare module '@shopify/restyle' {
  export interface BaseTheme extends AppTheme {}
}

Without this change, the above extension would error with a circular dependency.

@Krisztiaan Krisztiaan changed the title chore: less invasive theme type chore: less strict theme type Mar 26, 2022
@gvarandas gvarandas force-pushed the master branch 9 times, most recently from 334b3da to f86990a Compare March 19, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant