Skip to content

Make Thread#to_s consistent with Method and Proc to_s #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 2 additions & 40 deletions spec/ruby/core/thread/inspect_spec.rb
Original file line number Diff line number Diff line change
@@ -1,44 +1,6 @@
require_relative '../../spec_helper'
require_relative 'fixtures/classes'
require_relative 'shared/to_s'

describe "Thread#inspect" do
it "can check it's own status" do
ThreadSpecs.status_of_current_thread.inspect.should include('run')
end

it "describes a running thread" do
ThreadSpecs.status_of_running_thread.inspect.should include('run')
end

it "describes a sleeping thread" do
ThreadSpecs.status_of_sleeping_thread.inspect.should include('sleep')
end

it "describes a blocked thread" do
ThreadSpecs.status_of_blocked_thread.inspect.should include('sleep')
end

it "describes a completed thread" do
ThreadSpecs.status_of_completed_thread.inspect.should include('dead')
end

it "describes a killed thread" do
ThreadSpecs.status_of_killed_thread.inspect.should include('dead')
end

it "describes a thread with an uncaught exception" do
ThreadSpecs.status_of_thread_with_uncaught_exception.inspect.should include('dead')
end

it "describes a dying sleeping thread" do
ThreadSpecs.status_of_dying_sleeping_thread.inspect.should include('sleep')
end

it "reports aborting on a killed thread" do
ThreadSpecs.status_of_dying_running_thread.inspect.should include('aborting')
end

it "reports aborting on a killed thread after sleep" do
ThreadSpecs.status_of_dying_thread_after_sleep.inspect.should include('aborting')
end
it_behaves_like :thread_to_s, :inspect
end
13 changes: 13 additions & 0 deletions spec/ruby/core/thread/shared/to_s.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
describe :thread_to_s, shared: true do
sep = ruby_version_is("2.7") ? " " : "@"

describe "for a thread created with Thread.new" do
it "returns a description including file and line number" do
Thread.new { "hello" }.send(@method).should =~ /^#<Thread:([^ ]*?)#{sep}#{Regexp.escape __FILE__}:#{__LINE__ } \w+>$/
end

it "has a binary encoding" do
Thread.new { "hello" }.send(@method).encoding.should == Encoding::BINARY
end
end
end
6 changes: 6 additions & 0 deletions spec/ruby/core/thread/to_s_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
require_relative '../../spec_helper'
require_relative 'shared/to_s'

describe "Thread#to_s" do
it_behaves_like :thread_to_s, :to_s
end
2 changes: 1 addition & 1 deletion thread.c
Original file line number Diff line number Diff line change
Expand Up @@ -3180,7 +3180,7 @@ rb_thread_to_s(VALUE thread)
rb_str_catf(str, "@%"PRIsVALUE, target_th->name);
}
if ((loc = threadptr_invoke_proc_location(target_th)) != Qnil) {
rb_str_catf(str, "@%"PRIsVALUE":%"PRIsVALUE,
rb_str_catf(str, " %"PRIsVALUE":%"PRIsVALUE,
RARRAY_AREF(loc, 0), RARRAY_AREF(loc, 1));
rb_gc_force_recycle(loc);
}
Expand Down