Remove support for node 16 #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizkenyon
commented
May 24, 2024
| @@ -3,7 +3,8 @@ | |||
| "compilerOptions": { | |||
| "baseUrl": ".", | |||
| "outDir": ".", | |||
| "rootDir": "." | |||
| "rootDir": ".", | |||
| "useDefineForClassFields": false | |||
There was a problem hiding this comment.
Our tests were failing before adding this.
We can either use this option or update our test code.
microsoft/TypeScript#52331
lizkenyon
commented
May 24, 2024
tsconfig.base.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "pretty": true, | |||
| "module": "Node16", | |||
| "moduleResolution": "Node16", | |||
| "target": "ES2021", | |||
| "target": "ES2022", | |||
There was a problem hiding this comment.
Updated to this because of this recommendation
lizkenyon
changed the title
paulomarg
approved these changes
May 28, 2024
| @@ -11,13 +11,13 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| version: [16, 18, 20] | |||
| version: [18, 20, 22] | |||
There was a problem hiding this comment.
Will this break CI since we'll still be using assert?
There was a problem hiding this comment.
yes, forgot to remove that as I was splitting out. Removed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
Type of change
Checklist
yarn changesetto create a draft changelog entry (do NOT update theCHANGELOG.mdfiles manually)