Skip to content

Fix logger re-initialisation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix logger re-initialisation #2

merged 1 commit into from
Jul 12, 2023

Conversation

kashyap-thacker
Copy link
Collaborator

Jira:

SEN-6331

Description:

  • Lambda shares logger instances causing re-initialisation. Prevent if already initialised.
  • Disable propagation to parent logger to disable printing twice.

Type of change:

Checklist (put x in bracket to check):

Please do not delete options here.

  • I have performed a self-review of my code
  • Existing unit tests pass locally with my changes
  • I have written coverage for new code
  • I have updated the Production deployment sheet if this service required production changes in this sprint

@vaibhavudaywal vaibhavudaywal merged commit d384391 into main Jul 12, 2023
@kashyap-thacker kashyap-thacker deleted the kthacker/fix-reinitialisation branch July 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavudaywal vaibhavudaywal vaibhavudaywal approved these changes

@amitinfo86 amitinfo86 Awaiting requested review from amitinfo86

@vikas010 vikas010 Awaiting requested review from vikas010

@Kunal951996 Kunal951996 Awaiting requested review from Kunal951996

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kashyap-thacker @vaibhavudaywal @vikas010 @Kunal951996