StyleCop #1
Merged
StyleCop #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also list stylecop analysers as a dependency in the output Nuget package? |
|
I was wondering that also. I haven't tested that yet but I can take a look at it. And we should probably also create a .ruleset file that we should configure in the same way as the stylecop.json file (http://stackoverflow.com/a/38094474/2410453) Edit: It does, will try to figure out how we can get rid of it there. |
|
Just pushed a patch to resolve the dependency. |
antonfirsov
referenced
this pull request
in jongleur1983/ImageSharp
May 13, 2018
JimBobSquarePants
pushed a commit
that referenced
this pull request
Jul 17, 2018
Sync with imagesharp master
antonfirsov
pushed a commit
that referenced
this pull request
Aug 6, 2019
Update from SixLabors/ImageSharp
antonfirsov
added a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
Sync with imagesharp master
antonfirsov
pushed a commit
that referenced
this pull request
Jan 18, 2020
Added guards from the ImageSharp project
antonfirsov
pushed a commit
that referenced
this pull request
Jan 18, 2020
Remove typo in NuGet package description
JimBobSquarePants
pushed a commit
that referenced
this pull request
Feb 17, 2021
Added guards from the ImageSharp project
JimBobSquarePants
pushed a commit
that referenced
this pull request
Feb 17, 2021
Remove typo in NuGet package description
JimBobSquarePants
pushed a commit
that referenced
this pull request
Feb 17, 2021
Added guards from the ImageSharp project
JimBobSquarePants
pushed a commit
that referenced
this pull request
Feb 17, 2021
Remove typo in NuGet package description
JimBobSquarePants
pushed a commit
that referenced
this pull request
Dec 12, 2021
Merge upstream changes
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds StyleCop.Analyzers that will enable StyleCop during the build. The documentation for the library can be found here: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/DOCUMENTATION.md. I added stylecop.json file and you can find more information about how that file works here: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/Configuration.md.