Add AVX version of TransformColor and TransformColorInverse #1830
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
======================================
- Coverage 87% 87% -1%
======================================
Files 937 937
Lines 48385 48420 +35
Branches 6048 6054 +6
======================================
- Hits 42285 42217 -68
- Misses 5097 5196 +99
- Partials 1003 1007 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| { | ||
| int numPixels = pixelData.Length; | ||
| fixed (uint* p = pixelData) | ||
| int i; |
There was a problem hiding this comment.
| int i; | |
| nint i; |
? As well on the other loop-variables to avoid the movsxd machine-instruction.
There was a problem hiding this comment.
The slice down below requires an int. Is it still worth using nint here and cast with the slice or should i keep it rather int then? The Slice is outside of the loop and only for the leftover.
There was a problem hiding this comment.
I'd cast to int in the slice. It's actually a nop in machine code.
There was a problem hiding this comment.
ok will do that then, thx!
There was a problem hiding this comment.
@brianpopow I went ahead and did the nint change.
There was a problem hiding this comment.
thanks, i was unsure in some places, if I should go for it or not.
Co-authored-by: Günther Foidl <[email protected]>
Co-authored-by: Günther Foidl <[email protected]>
Prerequisites
Description
This PR add AVX2 versions of
TransformColorandTransformColorInversewhich are used during webp encoding and decoding.Relates to #1786
Profiling results:
master:
PR: