Skip to content

ImageFormatDetector Configuration Cleanup #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2022
Merged

ImageFormatDetector Configuration Cleanup #1936

merged 3 commits into from
Jan 11, 2022

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Jan 11, 2022 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates around ImageFormatDetector. Fixes #1850

Minimum changes.

  • Removes the public setter from the Configuration type
  • Minor style cleanup.

This still leaves it possible to clear the collection of detectors, therefore limiting the collection of available image formats.

@JimBobSquarePants JimBobSquarePants added area:formats API breaking Signifies a binary breaking change. labels Jan 11, 2022
@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Jan 11, 2022
@JimBobSquarePants JimBobSquarePants changed the title Remove public setter and use ConcurrentBag<T>.Clear() ImageFormatDetector Configuration Cleanup Jan 11, 2022
antonfirsov
antonfirsov approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimBobSquarePants JimBobSquarePants merged commit dfe3fb5 into master Jan 11, 2022
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1850 branch January 11, 2022 13:38
This was referenced Jul 23, 2025
Closed
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 30, 2025
Open
Open
Open
Open
Open
This was referenced Sep 23, 2025
Open
Open
@dependabot dependabot bot mentioned this pull request Oct 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees
No one assigned
Labels
API area:formats breaking Signifies a binary breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we need public setter for Configuration.ImageFormatManager?
2 participants
@JimBobSquarePants @antonfirsov