-
-
Notifications
You must be signed in to change notification settings - Fork 887
Fix documentation of HorizontalResolution and VerticalResolution properties #1981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…erties Also improve the formatting of the ResolutionUnits documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah JUST missed the V2 release....
This looks great, much appreciated 👍
Too bad I just missed the v2 release! I noticed this documentation glitch while porting the ClosedXML library from |
Thanks! That's really great to hear! Just had a very quick look at the port. You've got a mix of the old and new major versions of ImageSharp, Drawing, and, Fonts going on there which won't work well. I'm gonna be pushing new betas for both Fonts and Drawing today which will bring some changes (massive improvements) around text rendering. I'd strongly recommend bumping to a minimum of net472 also due the the redirect issues with older targets |
Actually, Drawing is not used. Nevertheless, I updated Fonts to the latest beta (16) and it was a matter of updating
I'm fully aware of the issues with .NET Standard 2.0 theoretically supporting .NET Framework 4.6.1 but actually only supporting .NET Framework 4.7.2. But in such a large pull request, I prefer te be conservative with the changes to the target framework in order to focus on the rest of the pull request. |
Also improve the formatting of the ResolutionUnits documentation.