Add support for decoding gray tiff with jpeg compression #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
br3aker
reviewed
Feb 27, 2022
| using SpectralConverter<L8> spectralConverterGray = new GrayJpegSpectralConverter<L8>(this.configuration); | ||
| var scanDecoderGray = new HuffmanScanDecoder(stream, spectralConverterGray, CancellationToken.None); | ||
| jpegDecoder.LoadTables(this.jpegTables, scanDecoderGray); | ||
| scanDecoderGray.ResetInterval = 0; |
There was a problem hiding this comment.
What is the point of zeroing this field? It should be zero by default if there is no RST marker.
There was a problem hiding this comment.
Yes you are right, that is not needed. Changed with 2fbf566
This was referenced Jul 23, 2025
This was referenced Jul 30, 2025
This was referenced Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds support for decoding gray tiff with jpeg compression.
Fixes #2030