Skip to content

Fix issue with app1 parsing #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 13, 2022
Merged

Fix issue with app1 parsing #2058

merged 3 commits into from
Mar 13, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes an issue with APP1 parsing: the remaining bytes was not calculated correctly when it was not an EXIF or XMP profile.

Related to #2057

@brianpopow brianpopow mentioned this pull request Mar 10, 2022
Closed
4 tasks
@brianpopow
Merge remote-tracking branch 'origin/main' into bp/fixapp1parsing
c668373 
# Conflicts:
#	tests/ImageSharp.Tests/TestImages.cs
@brianpopow brianpopow requested a review from a team March 11, 2022 13:47
JimBobSquarePants
JimBobSquarePants approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@JimBobSquarePants JimBobSquarePants merged commit f970634 into main Mar 13, 2022
@JimBobSquarePants JimBobSquarePants deleted the bp/fixapp1parsing branch March 13, 2022 14:26
This was referenced Jul 23, 2025
Closed
Merged
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 30, 2025
Open
Open
Open
Open
This was referenced Sep 23, 2025
Open
Open
@dependabot dependabot bot mentioned this pull request Oct 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
bug formats:jpeg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianpopow @JimBobSquarePants