Skip to content

Fix null reference exception on Exif clone of null ExifArrayValue #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2022
Merged

Fix null reference exception on Exif clone of null ExifArrayValue #2059

merged 2 commits into from
Mar 11, 2022

Conversation

ynse01
Copy link
Contributor

@ynse01 ynse01 commented Mar 11, 2022 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR fixes #2056

When an ExifArrayValue has a null value, don't bother to clone that value. Just write the null value in the clone also.

@ynse01 ynse01 changed the title Fix and test Fix null reference exception on Exif clone of null ExifArrayValue Mar 11, 2022
brianpopow
brianpopow approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ynse01: Looks good, thank you for the fix!

@brianpopow brianpopow merged commit e73f21f into SixLabors:main Mar 11, 2022
@JimBobSquarePants JimBobSquarePants added this to the 2.1.0 milestone Mar 15, 2022
@JimBobSquarePants JimBobSquarePants mentioned this pull request Apr 15, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpopow brianpopow brianpopow approved these changes

Assignees
No one assigned
Labels
metadata:exif
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

System.NullReferenceException when resizing jpeg file
3 participants
@ynse01 @brianpopow @JimBobSquarePants