fix: cross-env & windows fix for vue #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a contribution to merge SoftwareBrothers#46 in which they fixed the react path but ignored the vue ones, also the cmd command is passed over cross-env package to make sure it works in any enviroment (linux/osx/windows)
|
I think you can achieve this without the "cross-env" dependency. This two-liner in bundler.js should do the job as well:
|
wojtek-krysiak
approved these changes
Aug 24, 2020
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a contribution to merge #46 in which they fixed the react path but ignored the vue ones, also the cmd command is passed over cross-env package to make sure it works in any enviroment (linux/osx/windows).
These changes shouldn't affect the current behavior of the package & hope it helps other people. Thanks for this amazing project.