Skip to content

국내주식 시세조회의 업종명 버그 수정 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

국내주식 시세조회의 업종명 버그 수정 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab5984
KisStockInfoRepr 잘못된 필드명 수정
Soju06 Oct 29, 2024
4386133
국내주식 시세조회 업종명 필드 기본값 추가
Soju06 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pykis/api/stock/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class KisStockInfoResponse(KisStockInfo, KisResponseProtocol, Protocol):
"market",
"symbol",
"name",
"eng_name",
"name_eng",
lines="single",
)
class KisStockInfoRepr:
Expand Down
8 changes: 4 additions & 4 deletions pykis/api/stock/quote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class KisQuote(KisProductProtocol, Protocol):
"""한국투자증권 상품 시세"""

@property
def sector_name(self) -> str:
def sector_name(self) -> str | None:
"""업종명"""
raise NotImplementedError

Expand Down Expand Up @@ -301,7 +301,7 @@ class KisQuoteBase(KisQuoteRepr, KisProductBase):
market: MARKET_TYPE
"""상품유형타입"""

sector_name: str
sector_name: str | None
"""업종명"""
price: Decimal
"""현재가"""
Expand Down Expand Up @@ -402,7 +402,7 @@ class KisDomesticQuote(KisQuoteBase, KisAPIResponse):
market: MARKET_TYPE
"""상품유형타입"""

sector_name: str = KisString["bstp_kor_isnm"]
sector_name: str | None = KisString["bstp_kor_isnm", None]
"""업종명"""
price: Decimal = KisDecimal["stck_prpr"]
"""현재가"""
Expand Down Expand Up @@ -516,7 +516,7 @@ class KisForeignQuote(KisQuoteBase, KisAPIResponse):
market: MARKET_TYPE
"""상품유형타입"""

sector_name: str = KisString["e_icod"]
sector_name: str | None = KisString["e_icod"]
"""업종명"""
price: Decimal = KisDecimal["last"]
"""현재가"""
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_product_quote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ def test_quotable(self):

def test_krx_quote(self):
self.assertTrue(isinstance(self.pykis.stock("005930").quote(), KisQuote))
# https://github.com/Soju06/python-kis/issues/48
# bstp_kor_isnm 필드 누락 대응
self.assertTrue(isinstance(self.pykis.stock("002170").quote(), KisQuote))

def test_nasd_quote(self):
self.assertTrue(isinstance(self.pykis.stock("NVDA").quote(), KisQuote))
Expand Down