Skip to content

Conversation

tasoo-oos
Copy link
Contributor

πŸ› οΈ PR Summary

🌟 μš”μ•½

μ–΄λ–€ 것이 λ³€κ²½λ˜μ—ˆλ‚˜μš”? κ°„λž΅νžˆ μ„€λͺ…ν•΄μ£Όμ„Έμš”.

λ‹€μŒ 였λ₯˜λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

  File "/home/tasoo1118/.miniconda3/envs/algotrading/lib/python3.11/site-packages/pykis/event/handler.py", line 129
    return f"{self.__class__.__name__}({", ".join(repr(filter) for filter in self.filters)}, gate={self.gate!r})"
                                         ^
SyntaxError: f-string: expecting '}'

πŸ“Š μ£Όμš” λ³€κ²½ 사항

μ£Όμš” λ³€κ²½ 사항을 μ μ–΄μ£Όμ„Έμš”.

ν•΄λ‹Ή μ€„μ˜ λ‚΄λΆ€ μŒλ”°μ˜΄ν‘œλ₯Ό μ™Έλ”°μŒν‘œλ‘œ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

return f"{self.__class__.__name__}({", ".join(repr(filter) for filter in self.filters)}, gate={self.gate!r})"
return f"{self.__class__.__name__}({', '.join(repr(filter) for filter in self.filters)}, gate={self.gate!r})"

🎯 λͺ©μ  및 영ν–₯

  • λͺ©μ : μ™œ 이 PR이 ν•„μš”ν•œκ°€μš”?
    파이썬 3.11 λ²„μ „μ—μ„œ μ—λŸ¬κ°€ λ‚©λ‹ˆλ‹€.

  • 영ν–₯: 이 λ³€κ²½ 사항이 μ–΄λ–€ 영ν–₯을 λ―ΈμΉ˜λ‚˜μš”?
    이 변경사항이 μ΅œμ„ μΈμ§€λŠ” 잘 λͺ¨λ₯΄κ² μŠ΅λ‹ˆλ‹€.
    κ·Έλž˜λ„ μ—λŸ¬λŠ” 이제 μ•ˆ λ‚©λ‹ˆλ‹€.

@Soju06 Soju06 added the 버그 λ­”κ°€ μž‘λ™ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. label Nov 14, 2024
@Soju06 Soju06 merged commit 7059918 into Soju06:main Nov 14, 2024
1 check passed
@Soju06
Copy link
Owner

Soju06 commented Nov 14, 2024

λΌμ΄λΈŒλŸ¬λ¦¬μ— κΈ°μ—¬ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•©λ‹ˆλ‹€!

@Soju06 Soju06 self-requested a review November 14, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
버그 λ­”κ°€ μž‘λ™ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants