Refector/decorator keeping function information #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ ๏ธ PR Summary
๐ ์์ฝ
์ด๋ค ๊ฒ์ด ๋ณ๊ฒฝ๋์๋์? ๊ฐ๋ตํ ์ค๋ช ํด์ฃผ์ธ์.
kis_repr๋ฐthread_safe๋ฐ์ฝ๋ ์ดํฐ์ ํจ์ ์ ๋ณด๋ฅผ ์ ์งํ ์ ์๋๋ก ๋ณ๊ฒฝํ์์ต๋๋ค.๐ ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ์ ์ ์ด์ฃผ์ธ์.
utils/cache.py๋ฅผ ์ ๊ฑฐํ๊ณ ,functools.cached_property๋ก ๋ณ๊ฒฝํ์์ต๋๋ค.KisChartBar.__reversed__,KisChartBar.df์ ๋ฐํ ํ์ ์ ๋ช ์ํ์์ต๋๋ค.kis_repr๋ฐthread_safe์functools.wraps๋ฅผ ์ฌ์ฉํ์ฌ ํจ์ ์ ๋ณด๋ฅผ ์ค์ ํ์์ต๋๋ค.๐ฏ ๋ชฉ์ ๋ฐ ์ํฅ
๋ชฉ์ : ์ ์ด PR์ด ํ์ํ๊ฐ์?
์ฝ๋๋ฅผ ์ ๋ฆฌํ๊ณ , ๋ฎจ์ํ ๋ฐ ํ์ดํ ๋ฌธ์ ๋ฅผ ํด๊ฒฐํ์ต๋๋ค.
์ํฅ: ์ด ๋ณ๊ฒฝ ์ฌํญ์ด ์ด๋ค ์ํฅ์ ๋ฏธ์น๋์?
ํ์ด์ฌ์ ๊ถ์ฅ ์ฌ์์ ๋ถํฉํ๋๋ก ๋ง๋ค์์ต๋๋ค.