Skip to content

Conversation

oodigie
Copy link

@oodigie oodigie commented Aug 22, 2025

Changes:

  • EBP-1204: fix the supported cipher suite list for TLSv1.2 on the latest 10.25.0 broker version

✨ PR Description

Purpose: Update TLSv1.2 cipher suite lists to support compatibility with latest 10.25.0 broker version by removing deprecated ciphers.
Main changes:

  • Removed unsupported cipher suites (DES-CBC3-SHA, RC4-SHA, RC4-MD5) from supported list
  • Added separation between supported and unsupported cipher suites for better documentation
  • Reorganized cipher suite tables for improved readability and accurate compatibility information

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Copy link

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR updates TLS cipher suite documentation for broker version 10.25.0, reorganizing supported and unsupported cipher suites. The changes are appropriate for security improvements, but there are formatting inconsistencies in the documentation tables.

2 issues detected:

🧾 Readability - Line 302 has malformed table formatting with extra pipe character and inconsistent spacing.

Details: The documentation table has malformed formatting with extra pipe characters and inconsistent spacing, making it difficult to read and potentially confusing for developers.
File: pkg/solace/config/messaging_service_properties.go (302-302)

🧾 Readability - Line 264 has malformed table formatting with extra pipe character and inconsistent spacing.

Details: The documentation table has malformed formatting with extra pipe characters and inconsistent spacing, making it difficult to read and potentially confusing for developers.
File: pkg/solace/config/messaging_service_strategies.go (264-264)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

Copy link

gitstream-cm bot commented Aug 22, 2025

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

@oodigie oodigie requested a review from TrentDaniel August 25, 2025 13:53
Copy link

@TrentDaniel TrentDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to confirm resolution of AI change requests. Otherwise looks good

@oodigie
Copy link
Author

oodigie commented Sep 2, 2025

@TrentDaniel , these comments by the AI reviewer are not valid. I have resolved them.

@oodigie oodigie requested a review from TrentDaniel September 2, 2025 15:53
Copy link

@TrentDaniel TrentDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oodigie oodigie merged commit 1f08735 into EBP-327 Sep 2, 2025
8 checks passed
@oodigie oodigie deleted the EBP-1204 branch September 2, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants