-
Notifications
You must be signed in to change notification settings - Fork 1
EBP-1204: fix the supported cipher suite list for TLSv1.2 on the latest 10.25.0 broker version #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…st 10.25.0 broker version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR updates TLS cipher suite documentation for broker version 10.25.0, reorganizing supported and unsupported cipher suites. The changes are appropriate for security improvements, but there are formatting inconsistencies in the documentation tables.
2 issues detected:
🧾 Readability - Line 302 has malformed table formatting with extra pipe character and inconsistent spacing.
Details: The documentation table has malformed formatting with extra pipe characters and inconsistent spacing, making it difficult to read and potentially confusing for developers.
File:pkg/solace/config/messaging_service_properties.go (302-302)🧾 Readability - Line 264 has malformed table formatting with extra pipe character and inconsistent spacing.
Details: The documentation table has malformed formatting with extra pipe characters and inconsistent spacing, making it difficult to read and potentially confusing for developers.
File:pkg/solace/config/messaging_service_strategies.go (264-264)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
|
Please mark whether you used Copilot to assist coding in this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to confirm resolution of AI change requests. Otherwise looks good
|
@TrentDaniel , these comments by the AI reviewer are not valid. I have resolved them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes:
✨ PR Description
Purpose: Update TLSv1.2 cipher suite lists to support compatibility with latest 10.25.0 broker version by removing deprecated ciphers.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀