-
Notifications
You must be signed in to change notification settings - Fork 11
Jcsmp serdes feature #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jcsmp serdes feature #171
Conversation
Included JSON tutorial but left out AVRO and generic as they are essentially identical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The PR introduces a comprehensive tutorial for JCSMP SERDES features with good documentation structure. The changes include updating a commit reference and adding new tutorial content.
2 issues detected:
🧾 Readability - Image reference may point to a non-existent file causing broken link
Details: The tutorial references an image file 'image.png' that may not exist in the repository, which could result in a broken image link on the rendered tutorial page.
File:src/pages/tutorials/jcsmp/schema-registry-serdes.md (22-22)
🧾 Readability - Missing bullet point marker creates inconsistent list formatting
Details: The prerequisites section has inconsistent bullet point formatting where one line uses proper markdown bullet syntax while the following line does not.
File:src/pages/tutorials/jcsmp/schema-registry-serdes.md (38-38)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀
|
||
The Solace Schema Registry provides a centralized repository for managing message schemas, enabling schema validation, versioning, and evolution across your event-driven applications. The Schema Registry SERDES integration with JCSMP allows you to serialize and deserialize messages while automatically validating them against registered schemas. | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧾 Readability - Missing Image File: Verify that the image.png file exists in the correct location or update the image path to point to the correct file location.
 | |
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally rename image.png
to ./serdes_arch.png
or something similar
Please mark whether you used Copilot to assist coding in this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for the Schema Registry Serialize/Deserialize (SERDES) features to the JCSMP tutorial. The documentation covers JSON Schema serialization and deserialization capabilities with the Solace Schema Registry.
- Adds a new tutorial page explaining Schema Registry SERDES functionality
- Updates the Git commit reference for the JCSMP samples repository
- Provides code examples for both serialization and deserialization workflows
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/pages/tutorials/jcsmp/schema-registry-serdes.md | New tutorial documentation explaining Schema Registry SERDES features with JSON Schema examples |
gatsby-config.js | Updates commit hash reference for JCSMP samples repository |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Access to the Schema Registry with appropriate credentials | ||
* JSON Schema files uploaded to the Schema Registry | ||
* There must be a suitable [Client Profile](https://docs.solace.com/Configuring-and-Managing/Configuring-Client-Profiles.htm) configured on your broker | ||
For guidance on schema registry setup complete the [Schema registry codelab](https://codelabs.solace.dev/codelabs/schema-registry/?index=..%2F..index#0) |
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma after 'setup'. Should be 'For guidance on schema registry setup, complete the...'
For guidance on schema registry setup complete the [Schema registry codelab](https://codelabs.solace.dev/codelabs/schema-registry/?index=..%2F..index#0) | |
For guidance on schema registry setup, complete the [Schema registry codelab](https://codelabs.solace.dev/codelabs/schema-registry/?index=..%2F..index#0) |
Copilot uses AI. Check for mistakes.
hand crafted spelling errors Co-authored-by: Copilot <[email protected]>
…ace-dev-tutorials into jcsmp-serdes-feature
Updated the JCSMP tutorial page to include the SERDES features.
✨ PR Description
Purpose: Add Schema Registry serialization/deserialization (SERDES) tutorial for JCSMP API to document JSON Schema validation capabilities.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀