[filesystem] Greatly improve CBaseFileSystem::FixUpPath #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split into prs |
|
Thank you for all these changes! I find a lot of them handy and will land into main when finish basic HL2 Anniversary Update content support (will ask you to rebase). Could you please split this PR per commit so we can discuss, validate, merge (and rollback) every fix alone? It is easy to miss something when merging a lot of changes over entire codebase. |
RaphaelIT7
changed the title
|
Every change should how have it's own pr :D |
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
b388518 to
76fe8e0
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
41bd79f to
9544370
Compare
dimhotepus
force-pushed
the
master
branch
11 times, most recently
from
3fd9d80 to
dbb5131
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1d814a3 to
e099636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used this quite a bit to learn and find ways to optimize or solve things, so why not contribute to the main project :^
Changes:
CBaseFileSystem::FixUpPathmaking the filesystem generally faster.I also made a pr in the source-physics repo to solve a ivp bug that broke the entire physics engine.
Source-Authors/source-physics#1