[vstdlib] optimize CCvar::FindCommandBase #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
b388518 to
76fe8e0
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
41bd79f to
9544370
Compare
|
Just found a bug when testing it again, the source engine uses V_stricmp when comparing making FindCommandBase case-insensitive, and I failed to account for it making it currently case-sensitive. |
dimhotepus
force-pushed
the
master
branch
9 times, most recently
from
93c1043 to
05f3ca1
Compare
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
3fd9d80 to
dbb5131
Compare
Origin: 40d80d0 Just made this optimization, but since I found no issues with it, it should work fine
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1d814a3 to
e099636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimized CCvar::FindCommandBase
I made this optimization today and didn't find any issues, so it should work fine.
It's quiet a significant improvement but I don't got exact numbers, but from what I experienced it should be like 10x?
The improvement should become bigger with each new command/convar being added.