Skip to content
This repository was archived by the owner on Oct 28, 2022. It is now read-only.

feat: add outputs to get the preview-url and preview-name #22

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

semoal
Copy link

@semoal semoal commented Jul 22, 2021

Description

Basically I want to get the preview-url generated by netlify to run some e2e tests and Lighthouse suite to that URL.

Vercel deployment action already does this.

@T-Philipp
Copy link

@South-Paw this PR is opened since July....

@semoal
Copy link
Author

semoal commented Sep 16, 2021

@South-Paw this PR is opened since July....

I've ended up using mine which is the fork of South Paw.

You can see here https://github.com/verdaccio/verdaccio/blob/master/.github/workflows/website.yml#L92

@South-Paw
Copy link
Owner

South-Paw commented Sep 16, 2021

@T-Philipp Yeah, open source software is like that, sometimes people miss things, sometimes they are busy, sometimes they've chosen to not to use their spare time on free projects because they're looking after their own mental health and sometimes its just a combination of everything. I have PRs and issues that were raised years ago and never even got a maintainers response - that's just how free software is sometimes.

Now that being said, @semoal I apologize that it hasn't been looked at, I know how frustrating it is but its just one of those things that got lost in my notifications and I haven't been spending my spare time keeping track of.

I'll get it in now.

However, as mentioned in #21 deploy has been removed in a newer version of Netlify's js client and I have been planning to write up a migration path for people who use this action so they can just change over to using the Netlify CLI + a deployments action to replace this action.

@T-Philipp
Copy link

perfect.
Thanks a lot both of you 😁👍

@South-Paw South-Paw changed the base branch from master to next September 16, 2021 09:17
@South-Paw South-Paw merged commit b8693f5 into South-Paw:next Sep 16, 2021
@semoal semoal deleted the add-outputs branch September 16, 2021 09:29
South-Paw added a commit that referenced this pull request Sep 16, 2021
* feat: add outputs to get the preview-url and preview-name (#22)
* feat: add outputs to get the preview-url and preview-name
* chore: add dist/
* minor changes
* fix env variable in workflows
* update version
@South-Paw
Copy link
Owner

@T-Philipp @semoal v1.2.1 is on marketplace now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants