Skip to content

Feature/presistent state #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 4, 2020
Merged

Feature/presistent state #24

merged 4 commits into from
Aug 4, 2020

Conversation

AMalley
Copy link
Contributor

@AMalley AMalley commented Jul 31, 2020

No description provided.

@AMalley AMalley requested review from chipbell4 and 902seanryan July 31, 2020 17:14
chipbell4
chipbell4 reviewed Aug 3, 2020
View reviewed changes
chipbell4
chipbell4 reviewed Aug 3, 2020
View reviewed changes
chipbell4
chipbell4 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@chipbell4 chipbell4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me, but I do have a couple of questions around the usage of Vue.use(Vuex).

@AMalley AMalley requested a review from chipbell4 August 4, 2020 12:22
@chipbell4 chipbell4 merged commit 2f88ae0 into develop Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipbell4 chipbell4 chipbell4 approved these changes

@902seanryan 902seanryan 902seanryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMalley @chipbell4 @902seanryan