Return values instead of assigning to references #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminroosta
approved these changes
Feb 14, 2018
There was a problem hiding this comment.
So we are overloading get_col(/val)_from_db on result_type<T> (which is gonna be optimized away). And with RVO we might even gain a slightly better performance than using references (since we are not assinging to std::string or std::vector<T> anymore).
@zauguin Looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return extracted values in the type wrapper instead of assigning to references.
This makes the type specific functions easier and avoids unnecessary temporaries in some situations.
Compare https://github.com/SqliteModernCpp/sqlite_modern_cpp/pull/126/files#r163217134