Skip to content

Support OBJECT ENCODING #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 14, 2022
Merged

Support OBJECT ENCODING #2088

merged 10 commits into from
Apr 14, 2022

Conversation

Avital-Fine
Copy link
Contributor

NickCraver
NickCraver requested changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good - main thing is return type should be string? on these APIs

@slorello89 slorello89 mentioned this pull request Apr 13, 2022
Open
@Avital-Fine Avital-Fine requested a review from NickCraver April 14, 2022 11:12
NickCraver
NickCraver approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks :)

@NickCraver NickCraver merged commit 567527d into StackExchange:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees
No one assigned
Labels
⚙️ area:API ⚙️ area:commands ➕ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Avital-Fine @NickCraver