-
-
Notifications
You must be signed in to change notification settings - Fork 8
Fix CI/CD by correcting the version.h path in build_inc.py #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Stateford <[email protected]>
Co-authored-by: Stateford <[email protected]>
raise BuildError("Something went wrong with build") | ||
|
||
write_header( | ||
os.path.abspath("./Display-Lock/resources/version.h"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't fix the pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've enhanced the script to be more robust when finding the version.h file. The updated implementation in 46b4a16 will now:
- Try multiple possible file paths for the version.h file
- Add detailed logs about where it's searching and what it finds
- Work correctly regardless of the working directory it's run from
- Provide better error handling with detailed error messages
This should address the CI/CD pipeline issue by making the script more resilient to environment differences.
Co-authored-by: Stateford <[email protected]>
scripts/build_inc.py
Outdated
project_root = os.path.dirname(script_dir) # Assuming script is in a scripts/ directory at project root | ||
|
||
# Try different possible locations for the version.h file | ||
possible_paths = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is low IQ, do better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've simplified the implementation with a more elegant solution in a0d1af2. The script now uses a direct, concise approach to locate the version.h file without excessive debugging or complex path detection logic.
Co-authored-by: Stateford <[email protected]>
Issue
The CI/CD pipeline was failing because the
build_inc.py
script couldn't find the correct path to theversion.h
file during the build process.Changes
This PR makes a single targeted change to fix the CI/CD pipeline:
build_inc.py
from./Display-Lock/resources/version.h
to./src/resources/version.h
to match the actual project structureTesting
version.h
file with different configuration parametersThe fix is minimal and focused only on correcting the file path, ensuring the version information is correctly updated during the build process.
Fixes #127.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org
/usr/bin/fwupdmgr refresh
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.