Allow to set dimensions for metrics #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
frankreno,
perk-sumo,
samjsong and
vsinghal13
frankreno
approved these changes
Apr 7, 2020
lib/fluent/plugin/out_sumologic.rb
Outdated
| end | ||
|
|
||
| unless metadata.nil? | ||
| headers['X-Sumo-Metadata'] = metadata |
There was a problem hiding this comment.
As discussed on Slack, let's confirm Metadata is the best use, as opposed to dimensions.
There was a problem hiding this comment.
I change it to dimensions, but regarding another discussion I'm not sure if we want to merge those changes or not
lib/fluent/plugin/out_sumologic.rb
Outdated
| conf['custom_fields'] = nil | ||
| end | ||
|
|
||
| if conf['custom_metadata'].nil? || conf['custom_metadata'].strip.length == 0 |
There was a problem hiding this comment.
Should we do some validation on the configuration? Testing it is actually a KVP string?
There was a problem hiding this comment.
I added simple validation 👍
|
U updated PR description due to changes |
sumo-drosiek
force-pushed
the
drosiek-custom-metadata
branch
from
b31d158 to
8a1f307
Compare
sumo-drosiek
force-pushed
the
drosiek-custom-metadata
branch
from
8a1f307 to
a7b3a3c
Compare
sumo-drosiek
pushed a commit
that referenced
this pull request
Apr 8, 2020
sumo-drosiek
changed the title
samjsong
approved these changes
Apr 8, 2020
sumo-drosiek
added a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to add some dimensions directly from configuration.
custom_dimensionsallows to add dimensions inX-Sumo-Dimensionsheader.https://help.sumologic.com/03Send-Data/Sources/02Sources-for-Hosted-Collectors/HTTP-Source/Upload-Metrics-to-an-HTTP-Source#supported-http-headers