Skip to content

refactor: fix type instability within get_constants #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024
Merged

refactor: fix type instability within get_constants #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/NodeUtils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ given the output of this function.
Also return metadata that can will be used in the `set_constants!` function.
"""
function get_constants(tree::AbstractExpressionNode{T}) where {T}
refs = filter_map(is_node_constant, node -> Ref(node), tree, Ref{typeof(tree)})
refs = filter_map(
is_node_constant, node -> Ref(node), tree, Base.RefValue{typeof(tree)}
)
return map(ref -> ref[].val::T, refs), refs
# NOTE: Do not remove this `::T` as it is required for inference on empty collections
end
Expand Down