-
Notifications
You must be signed in to change notification settings - Fork 24
Physical constants #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That seems very reasonable to me. |
Hi, how does this square with the physical constants defined in Unitful Codes using these constants from different sources should be guaranteed to work together. |
Could you be more specific, I don't understand your question. PhysicalConstants.jl uses Unitful.jl unfortunately, so we cannot use it directly. The constants in PhysicalConstants.jl are taken from the same source as in #27 - from CODATA 2018. By CI do you mean to check the constants are equal? |
Right. If you think it makes sense the PR would be on me... |
I understand, that sounds good to me! Thanks. |
Closed with #32 |
[Diff since v0.5.0](v0.5.0...v0.6.0) **Closed issues:** - Physical constants (#26) **Merged pull requests:** - Create (1) physical constants, and (2) symbolic dimensions object (#32) (@MilesCranmer)
[Diff since v0.5.0](v0.5.0...v0.6.0) **Closed issues:** - Physical constants (#26) **Merged pull requests:** - Create (1) physical constants, and (2) symbolic dimensions object (#32) (@MilesCranmer)
We could have a submodule that delivers common physical constants. Already I am finding myself having to type out the speed of light by hand; it would be useful if it were just built-in.
This could work as follows:
Then,
C
would let you access constants, andU
the units. This is similar to howastropy
does it, to avoid mixing namespaces.e.g., the energy of a 500nm photon
This
Constants
namespace could also be exposed within the@u_str
macro, so you could also write this asI'd be interested to know if @odow or @ChrisRackauckas have any thoughts or ideas in this direction.
The text was updated successfully, but these errors were encountered: