This repository was archived by the owner on Sep 19, 2022. It is now read-only.
Input badge #1244
Draft
Input badge #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xjocke
reviewed
Aug 23, 2022
components/InputBadge/index.tsx
Outdated
| min-width: 170px; | ||
| border: 1px solid black; | ||
| cursor: pointer; | ||
| `; |
There was a problem hiding this comment.
I think we should avoid adding new styled component styles, the plan is probably to face out styled components? Does chakra have any solutions around this? If not it's worth a discussing how we style things like this
0xjocke
suggested changes
Aug 23, 2022
jmzwar
reviewed
Aug 23, 2022
components/InputBadge/index.tsx
Outdated
| import { InfoIcon } from '@chakra-ui/icons'; | ||
| import { Badge, BadgeProps, Flex, Text } from '@chakra-ui/react'; | ||
| import { PropsWithChildren } from 'react'; | ||
| import styled from 'styled-components'; |
There was a problem hiding this comment.
Joey has brought it up - but want to removed styled-components completely.
|
Alright, removed styled components. Thought we still using it. But no prob. |
|
@fritzschoff Can you link to the relevant component in figma? Ta. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.