fix(QTDI-1838): register ContainerFinder for studio #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* it was removed in 2020 and looks like we've missed it, it was added in a lot of modules for Cloud, but I think by mistake it was removed from component-runtime-manager.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing service registration for the ContainerFinder interface in the component-runtime-manager module. The change restores the StandaloneContainerFinder registration that was accidentally removed in 2020, ensuring proper functionality for studio components.
- Adds service provider configuration for ContainerFinder interface
- Registers StandaloneContainerFinder implementation for studio usage
Comments suppressed due to low confidence (1)
component-runtime-manager/src/main/resources/META-INF/services/org.talend.sdk.component.runtime.serialization.ContainerFinder:1
- The restoration of this service registration should be verified with a test to ensure the ContainerFinder service is properly discoverable and functional. Consider adding a test that validates the service provider mechanism loads the StandaloneContainerFinder correctly.
org.talend.sdk.component.runtime.manager.finder.StandaloneContainerFinder
This comment has been minimized.
This comment has been minimized.
undx
approved these changes
Jul 29, 2025
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
ozhelezniak-talend
deleted the
ozhelezniak/QTDI-1838_correct_isolated_loading
branch
undx
pushed a commit
that referenced
this pull request
Aug 5, 2025
* it was removed in 2020 and looks like we've missed it, it was added in a lot of modules for Cloud, but I think by mistake it was removed from component-runtime-manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
https://qlik-dev.atlassian.net/browse/QTDI-1838
What does this PR adds (design/code thoughts)?