fix: notify on updates between mounting and subscribing #1737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/od76fxr0l |
tannerlinsley
approved these changes
Feb 3, 2021
boschni
force-pushed
the
feature/fix-missed-updates
branch
from
632d542 to
0a3e2ea
Compare
boschni
force-pushed
the
feature/fix-missed-updates
branch
from
0a3e2ea to
58c30dd
Compare
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically query observers can miss updates from a query if there was a query update between creating the observer and subscribing to the observer. With this change the observer will check if anything changed on subscribing and update if needed. Hopefully fixes #1657 .