3031 continue retries #3032
3031 continue retries #3032
Conversation
if we are waiting for a retry to happen, unsubscribing he last observer will cancel retries and just return the error; however, if a new observer subscribes in the meantime, we should continue with the ongoing retries. this is especially important with "strict effects" in react18, where effects are run twice and thus observers are always unsubscribed and re-subscribed immediately.
add another test to include query cancellation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/A5Ru2ZeZ5iGeJ2Lda6ZMhpzhXeYW |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 323484c:
|
Codecov Report
@@ Coverage Diff @@
## master #3032 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 45 45
Lines 2254 2257 +3
Branches 641 641
=======================================
+ Hits 2174 2177 +3
Misses 77 77
Partials 3 3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.33.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #3031