Skip to content

feat: vue-query adapter #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2022
Merged

Conversation

DamianOsipiuk
Copy link
Contributor

@DamianOsipiuk DamianOsipiuk commented Oct 1, 2022

Todo

  • test if everything still works
  • test UMD build
  • migrate basic example
  • migrate vue-specific docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c82c83:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@DamianOsipiuk DamianOsipiuk mentioned this pull request Oct 1, 2022
21 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Base: 96.36% // Head: 96.94% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (84d8542) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4254      +/-   ##
==========================================
+ Coverage   96.36%   96.94%   +0.58%     
==========================================
  Files          45       86      +41     
  Lines        2281     3274     +993     
  Branches      640      882     +242     
==========================================
+ Hits         2198     3174     +976     
- Misses         80       98      +18     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
src/core/retryer.ts
...rc/createWebStoragePersistor-experimental/index.ts
src/core/mutation.ts
src/core/query.ts
src/core/hydration.ts
src/core/notifyManager.ts
src/core/queryClient.ts
src/react/QueryClientProvider.tsx
src/core/focusManager.ts
src/core/queryCache.ts
... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DamianOsipiuk DamianOsipiuk marked this pull request as ready for review October 2, 2022 12:27
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good 🚀

"dependencies": {
"@tanstack/query-core": "workspace:*",
"@vue/devtools-api": "^6.4.2",
"match-sorter": "^6.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've had problems with match-sorter, so we switched to the one Tanner has exposed from the react-table:

"@tanstack/match-sorter-utils": "^8.1.1",

Maybe it's worth also using this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a look at that afterwards

@TkDodo TkDodo merged commit 741cc3f into TanStack:main Oct 2, 2022
@TkDodo
Copy link
Collaborator

TkDodo commented Oct 14, 2022

@allcontributors please add @DamianOsipiuk for code, maintenance

@allcontributors
Copy link
Contributor

@TkDodo

I've put up a pull request to add @DamianOsipiuk! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants