-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: vue-query adapter #4254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vue-query adapter #4254
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3c82c83:
|
Codecov ReportBase: 96.36% // Head: 96.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4254 +/- ##
==========================================
+ Coverage 96.36% 96.94% +0.58%
==========================================
Files 45 86 +41
Lines 2281 3274 +993
Branches 640 882 +242
==========================================
+ Hits 2198 3174 +976
- Misses 80 98 +18
+ Partials 3 2 -1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0211a96
to
c785161
Compare
c785161
to
90131f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good 🚀
"dependencies": { | ||
"@tanstack/query-core": "workspace:*", | ||
"@vue/devtools-api": "^6.4.2", | ||
"match-sorter": "^6.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've had problems with match-sorter
, so we switched to the one Tanner has exposed from the react-table:
"@tanstack/match-sorter-utils": "^8.1.1", |
Maybe it's worth also using this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look at that afterwards
@allcontributors please add @DamianOsipiuk for code, maintenance |
I've put up a pull request to add @DamianOsipiuk! 🎉 |
Todo