-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(svelte-query): use store for reactivity in options #5050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(svelte-query): use store for reactivity in options #5050
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eef9534:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - please fix the merge conflict then it'll be right to go!
Conflicts should be solved |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## alpha #5050 +/- ##
==========================================
- Coverage 90.50% 90.42% -0.08%
==========================================
Files 104 105 +1
Lines 3811 3791 -20
Branches 961 952 -9
==========================================
- Hits 3449 3428 -21
- Misses 329 330 +1
Partials 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
New version of the accidentally closed PR: #4995
To fix #4851
This adds the option to use a writable store for the query options, so that svelte query can react appropriately when these options change. The current method of reactivity recreates the entire query each time an option is changed, which causes issues.