-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor: Sort imports with eslint #5634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0750784. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0750784:
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #5634 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 112 112
Lines 4283 4283
Branches 1117 1117
=======================================
Hits 3953 3953
Misses 309 309
Partials 21 21
☔ View full report in Codecov by Sentry. |
I agree, but it's gonna cause so many conflicts when merging back to Maybe we should this once v5 is released and we have only one branch to maintain? |
@TkDodo I was just going to merge main into alpha and only keep the changes to |
okay, let me just ship the fix for 5538 first. It has two PRs - one for main and one for alpha. |
I personally find imports sorted in a consistent order easier to approach, just like how prettier formats code in a consistent way. The rules here are totally flexible but would mean all packages follow the same structure.