Skip to content

refactor: Add new eslint sorting from main #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,31 @@ const config = {
],
'import/default': 'off',
'import/export': 'off',
'import/namespace': 'off',
'import/newline-after-import': 'error',
'import/no-cycle': 'error',
'import/no-duplicates': 'off',
'import/no-named-as-default-member': 'off',
'import/no-unresolved': ['error', { ignore: ['^@tanstack/'] }],
'import/no-unused-modules': ['off', { unusedExports: true }],
'import/order': [
'error',
{
groups: [
'builtin',
'external',
'internal',
'parent',
'sibling',
'index',
'object',
'type',
],
},
],
'no-redeclare': 'off',
'no-shadow': 'error',
'sort-imports': ['error', { ignoreDeclarationSort: true }],
},
overrides: [
{
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-query/src/configs/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { TSESLint } from '@typescript-eslint/utils'
import { rules } from '../rules'
import type { TSESLint } from '@typescript-eslint/utils'

function generateRecommendedConfig(
allRules: Record<string, TSESLint.RuleModule<any, any>>,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import type { TSESLint } from '@typescript-eslint/utils'
import { AST_NODE_TYPES } from '@typescript-eslint/utils'
import { ASTUtils } from '../../utils/ast-utils'
import { createRule } from '../../utils/create-rule'
import { uniqueBy } from '../../utils/unique-by'
import { ExhaustiveDepsUtils } from './exhaustive-deps.utils'
import type { TSESLint } from '@typescript-eslint/utils'

const QUERY_KEY = 'queryKey'
const QUERY_FN = 'queryFn'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { TSESLint } from '@typescript-eslint/utils'
import { AST_NODE_TYPES } from '@typescript-eslint/utils'
import { ASTUtils } from '../../utils/ast-utils'
import type { TSESLint } from '@typescript-eslint/utils'

export const ExhaustiveDepsUtils = {
isRelevantReference(params: {
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-plugin-query/src/utils/ast-utils.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { AST_NODE_TYPES } from '@typescript-eslint/utils'
import { uniqueBy } from './unique-by'
import type { TSESLint, TSESTree } from '@typescript-eslint/utils'
import type TSESLintScopeManager from '@typescript-eslint/scope-manager'
import { AST_NODE_TYPES } from '@typescript-eslint/utils'
import type { RuleContext } from '@typescript-eslint/utils/dist/ts-eslint'
import { uniqueBy } from './unique-by'

export const ASTUtils = {
isNodeOfOneOf<T extends AST_NODE_TYPES>(
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-query/src/utils/create-rule.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ESLintUtils } from '@typescript-eslint/utils'
import type { EnhancedCreate } from './detect-react-query-imports'
import { detectTanstackQueryImports } from './detect-react-query-imports'
import type { EnhancedCreate } from './detect-react-query-imports'

const getDocsUrl = (ruleName: string): string =>
`https://tanstack.com/query/v4/docs/eslint/${ruleName}`
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { vi } from 'vitest'
import { asyncThrottle } from '../asyncThrottle'
import { sleep as delay } from './utils'
import { vi } from 'vitest'

describe('asyncThrottle', () => {
test('basic', async () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/query-async-storage-persister/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { asyncThrottle } from './asyncThrottle'
import type {
PersistedClient,
Persister,
Promisable,
} from '@tanstack/query-persist-client-core'
import { asyncThrottle } from './asyncThrottle'

interface AsyncStorage {
getItem: (key: string) => Promise<string | null>
Expand Down
2 changes: 1 addition & 1 deletion packages/query-core/src/infiniteQueryBehavior.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { QueryBehavior } from './query'
import { addToEnd, addToStart } from './utils'
import type { QueryBehavior } from './query'
import type {
InfiniteData,
InfiniteQueryPageParamsOptions,
Expand Down
14 changes: 7 additions & 7 deletions packages/query-core/src/infiniteQueryObserver.ts
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
import { QueryObserver } from './queryObserver'
import {
hasNextPage,
hasPreviousPage,
infiniteQueryBehavior,
} from './infiniteQueryBehavior'
import type {
DefaultError,
DefaultedInfiniteQueryObserverOptions,
FetchNextPageOptions,
FetchPreviousPageOptions,
InfiniteData,
InfiniteQueryObserverOptions,
InfiniteQueryObserverResult,
QueryKey,
DefaultError,
} from './types'
import type { QueryClient } from './queryClient'
import type { NotifyOptions, ObserverFetchOptions } from './queryObserver'
import { QueryObserver } from './queryObserver'
import {
hasNextPage,
hasPreviousPage,
infiniteQueryBehavior,
} from './infiniteQueryBehavior'
import type { Query } from './query'

type InfiniteQueryObserverListener<TData, TError> = (
Expand Down
10 changes: 5 additions & 5 deletions packages/query-core/src/mutation.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { notifyManager } from './notifyManager'
import { Removable } from './removable'
import { canFetch, createRetryer } from './retryer'
import type {
DefaultError,
MutationMeta,
MutationOptions,
MutationStatus,
MutationMeta,
DefaultError,
} from './types'
import type { MutationCache } from './mutationCache'
import type { MutationObserver } from './mutationObserver'
import { notifyManager } from './notifyManager'
import { Removable } from './removable'
import type { Retryer } from './retryer'
import { canFetch, createRetryer } from './retryer'

// TYPES

Expand Down
10 changes: 5 additions & 5 deletions packages/query-core/src/mutationCache.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import type { MutationObserver } from './mutationObserver'
import type { NotifyEvent, MutationOptions, DefaultError } from './types'
import type { QueryClient } from './queryClient'
import { notifyManager } from './notifyManager'
import type { Action, MutationState } from './mutation'
import { Mutation } from './mutation'
import type { MutationFilters } from './utils'
import { matchMutation, noop } from './utils'
import { Subscribable } from './subscribable'
import type { MutationObserver } from './mutationObserver'
import type { DefaultError, MutationOptions, NotifyEvent } from './types'
import type { QueryClient } from './queryClient'
import type { Action, MutationState } from './mutation'
import type { MutationFilters } from './utils'

// TYPES

Expand Down
10 changes: 5 additions & 5 deletions packages/query-core/src/mutationObserver.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import type { Action, Mutation } from './mutation'
import { getDefaultState } from './mutation'
import { notifyManager } from './notifyManager'
import type { QueryClient } from './queryClient'
import { Subscribable } from './subscribable'
import { shallowEqualObjects } from './utils'
import type { QueryClient } from './queryClient'
import type {
DefaultError,
MutateOptions,
MutationObserverResult,
MutationObserverOptions,
DefaultError,
MutationObserverResult,
} from './types'
import { shallowEqualObjects } from './utils'
import type { Action, Mutation } from './mutation'

// TYPES

Expand Down
8 changes: 4 additions & 4 deletions packages/query-core/src/queriesObserver.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { notifyManager } from './notifyManager'
import { QueryObserver } from './queryObserver'
import { Subscribable } from './subscribable'
import { replaceEqualDeep } from './utils'
import type {
DefaultedQueryObserverOptions,
QueryObserverOptions,
QueryObserverResult,
DefaultedQueryObserverOptions,
} from './types'
import type { QueryClient } from './queryClient'
import type { NotifyOptions } from './queryObserver'
import { QueryObserver } from './queryObserver'
import { Subscribable } from './subscribable'
import { replaceEqualDeep } from './utils'

function difference<T>(array1: T[], array2: T[]): T[] {
return array1.filter((x) => !array2.includes(x))
Expand Down
16 changes: 8 additions & 8 deletions packages/query-core/src/query.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
import { noop, replaceData, timeUntilStale } from './utils'
import { notifyManager } from './notifyManager'
import { canFetch, createRetryer, isCancelledError } from './retryer'
import { Removable } from './removable'
import type {
CancelOptions,
DefaultError,
FetchStatus,
InitialDataFunction,
QueryFunctionContext,
QueryKey,
QueryMeta,
QueryOptions,
QueryStatus,
QueryFunctionContext,
QueryMeta,
CancelOptions,
SetDataOptions,
FetchStatus,
DefaultError,
} from './types'
import type { QueryCache } from './queryCache'
import type { QueryObserver } from './queryObserver'
import { notifyManager } from './notifyManager'
import type { Retryer } from './retryer'
import { isCancelledError, canFetch, createRetryer } from './retryer'
import { Removable } from './removable'

// TYPES

Expand Down
10 changes: 5 additions & 5 deletions packages/query-core/src/queryCache.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import type { QueryFilters } from './utils'
import { hashQueryKeyByOptions, matchQuery } from './utils'
import type { Action, QueryState } from './query'
import { Query } from './query'
import { notifyManager } from './notifyManager'
import { Subscribable } from './subscribable'
import type { QueryFilters } from './utils'
import type { Action, QueryState } from './query'
import type {
DefaultError,
NotifyEvent,
QueryKey,
QueryOptions,
DefaultError,
WithRequired,
} from './types'
import { notifyManager } from './notifyManager'
import type { QueryClient } from './queryClient'
import { Subscribable } from './subscribable'
import type { QueryObserver } from './queryObserver'

// TYPES
Expand Down
28 changes: 14 additions & 14 deletions packages/query-core/src/queryClient.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
import type { QueryFilters, Updater, MutationFilters } from './utils'
import {
functionalUpdate,
hashKey,
hashQueryKeyByOptions,
noop,
partialMatchKey,
hashQueryKeyByOptions,
functionalUpdate,
} from './utils'
import { QueryCache } from './queryCache'
import { MutationCache } from './mutationCache'
import { focusManager } from './focusManager'
import { onlineManager } from './onlineManager'
import { notifyManager } from './notifyManager'
import { infiniteQueryBehavior } from './infiniteQueryBehavior'
import type { QueryState } from './query'
import type {
QueryClientConfig,
CancelOptions,
DefaultError,
DefaultOptions,
DefaultedQueryObserverOptions,
FetchInfiniteQueryOptions,
FetchQueryOptions,
InfiniteData,
Expand All @@ -17,24 +25,16 @@ import type {
MutationKey,
MutationObserverOptions,
MutationOptions,
QueryClientConfig,
QueryKey,
QueryObserverOptions,
QueryOptions,
RefetchOptions,
RefetchQueryFilters,
ResetOptions,
SetDataOptions,
DefaultError,
CancelOptions,
DefaultedQueryObserverOptions,
} from './types'
import type { QueryState } from './query'
import { QueryCache } from './queryCache'
import { MutationCache } from './mutationCache'
import { focusManager } from './focusManager'
import { onlineManager } from './onlineManager'
import { notifyManager } from './notifyManager'
import { infiniteQueryBehavior } from './infiniteQueryBehavior'
import type { MutationFilters, QueryFilters, Updater } from './utils'

// TYPES

Expand Down
26 changes: 13 additions & 13 deletions packages/query-core/src/queryObserver.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,3 @@
import type {
DefaultedQueryObserverOptions,
DefaultError,
PlaceholderDataFunction,
QueryKey,
QueryObserverBaseResult,
QueryObserverOptions,
QueryObserverResult,
QueryOptions,
RefetchOptions,
} from './types'
import {
isServer,
isValidTimeout,
Expand All @@ -18,11 +7,22 @@ import {
timeUntilStale,
} from './utils'
import { notifyManager } from './notifyManager'
import type { Query, QueryState, FetchOptions } from './query'
import type { QueryClient } from './queryClient'
import { focusManager } from './focusManager'
import { Subscribable } from './subscribable'
import { canFetch } from './retryer'
import type { QueryClient } from './queryClient'
import type { FetchOptions, Query, QueryState } from './query'
import type {
DefaultError,
DefaultedQueryObserverOptions,
PlaceholderDataFunction,
QueryKey,
QueryObserverBaseResult,
QueryObserverOptions,
QueryObserverResult,
QueryOptions,
RefetchOptions,
} from './types'

type QueryObserverListener<TData, TError> = (
result: QueryObserverResult<TData, TError>,
Expand Down
2 changes: 1 addition & 1 deletion packages/query-core/src/retryer.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { focusManager } from './focusManager'
import { onlineManager } from './onlineManager'
import { sleep } from './utils'
import type { CancelOptions, NetworkMode, DefaultError } from './types'
import type { CancelOptions, DefaultError, NetworkMode } from './types'

// TYPES

Expand Down
2 changes: 1 addition & 1 deletion packages/query-core/src/tests/focusManager.test.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { vi } from 'vitest'
import { sleep } from '../utils'
import { FocusManager } from '../focusManager'
import { setIsServer } from './utils'
import { vi } from 'vitest'

describe('focusManager', () => {
let focusManager: FocusManager
Expand Down
6 changes: 3 additions & 3 deletions packages/query-core/src/tests/hydration.test.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { vi } from 'vitest'
import { QueryCache } from '../queryCache'
import { dehydrate, hydrate } from '../hydration'
import {
createQueryClient,
executeMutation,
mockNavigatorOnLine,
sleep,
} from './utils'
import { QueryCache } from '../queryCache'
import { dehydrate, hydrate } from '../hydration'
import { vi } from 'vitest'

async function fetchData<TData>(value: TData, ms?: number): Promise<TData> {
await sleep(ms || 0)
Expand Down
Loading