Skip to content

fix(eslint-plugin-query): Reorganise internal modules #5821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023
Merged

fix(eslint-plugin-query): Reorganise internal modules #5821

merged 1 commit into from
Aug 1, 2023

Conversation

lachlancollins
Copy link
Member

By default, tsup bundles all modules into chunks, and correctly adds ESM/CJS extensions to imported chunks. However, this is incompatible with "use client" directives, so we've added esbuild-plugin-file-path-extensions, which prevents modules getting bundled and adds ESM/CJS extensions.

However, this approach doesn't seem to work with presumed index imports (e.g. ./config referring to ./config/index.js). To fix this, I've re-organised the files in esbuild-plugin-query so that there are no presumed index imports. This seems to be the only package where this sort of import is used.

Fixes #5795

@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Aug 1, 2023 2:28am

@nx-cloud
Copy link

nx-cloud bot commented Aug 1, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 657d396. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 657d396:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -16.36% ⚠️

Comparison is base (e0aad73) 97.11% compared to head (657d396) 80.75%.
Report is 638 commits behind head on beta.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##             beta    #5821       +/-   ##
===========================================
- Coverage   97.11%   80.75%   -16.36%     
===========================================
  Files          50        9       -41     
  Lines        2391      265     -2126     
  Branches      706       94      -612     
===========================================
- Hits         2322      214     -2108     
+ Misses         67       35       -32     
- Partials        2       16       +14     

see 59 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lachlancollins lachlancollins merged commit 07ddcd1 into TanStack:beta Aug 1, 2023
@lachlancollins lachlancollins deleted the restructure-eslint-plugin branch August 1, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants