Skip to content

test(query-core/notifyManager): replace 'queueMicrotask' with 'advanceTimersByTimeAsync' #9329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2025
Merged

test(query-core/notifyManager): replace 'queueMicrotask' with 'advanceTimersByTimeAsync' #9329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f340ca
test(query-core/notifyManager): replace 'queueMicrotask' with 'advanc…
sukvvon Jun 29, 2025
e73e77b
Merge branch 'main' into test/query-core-notifyManager-replace-promis…
manudeli Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/query-core/src/__tests__/notifyManager.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe('notifyManager', () => {
})
notifyManagerTest.batch(callbackBatchLevel1Spy)

await vi.advanceTimersByTimeAsync(20)
await vi.advanceTimersByTimeAsync(0)
expect(callbackBatchLevel1Spy).toHaveBeenCalledTimes(1)
expect(callbackBatchLevel2Spy).toHaveBeenCalledTimes(1)
expect(callbackScheduleSpy).toHaveBeenCalledTimes(1)
Expand All @@ -57,9 +57,7 @@ describe('notifyManager', () => {

expect(customCallback).toHaveBeenCalledOnce()

// wait until the microtask has run
await new Promise<void>((res) => queueMicrotask(res))

await vi.advanceTimersByTimeAsync(0)
expect(notifySpy).toHaveBeenCalledTimes(1)
})

Expand Down
Loading