Skip to content

test(vue-query/useIsMutating): switch to fake timers and replace 'sleep' with 'advanceTimersByTimeAsync' #9373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025
Merged

test(vue-query/useIsMutating): switch to fake timers and replace 'sleep' with 'advanceTimersByTimeAsync' #9373

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
315b898
test(vue-query/useIsMutating): switch to fake timers and replace 'sle…
sukvvon Jul 7, 2025
2a63cd3
Merge branch 'main' into test/vue-query-useIsMutating-fake-timers-rep…
manudeli Jul 11, 2025
4db9509
Merge branch 'main' into test/vue-query-useIsMutating-fake-timers-rep…
manudeli Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions packages/vue-query/src/__tests__/useIsMutating.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { describe, expect, it, test, vi } from 'vitest'
import { afterEach, beforeEach, describe, expect, it, test, vi } from 'vitest'
import { onScopeDispose, reactive } from 'vue-demi'
import { sleep } from '@tanstack/query-test-utils'
import { useMutation } from '../useMutation'
Expand All @@ -9,12 +9,20 @@ import type { MockedFunction } from 'vitest'
vi.mock('../useQueryClient')

describe('useIsMutating', () => {
beforeEach(() => {
vi.useFakeTimers()
})

afterEach(() => {
vi.useRealTimers()
})

test('should properly return isMutating state', async () => {
const mutation = useMutation({
mutationFn: (params: string) => sleep(0).then(() => params),
mutationFn: (params: string) => sleep(10).then(() => params),
})
const mutation2 = useMutation({
mutationFn: (params: string) => sleep(0).then(() => params),
mutationFn: (params: string) => sleep(10).then(() => params),
})
const isMutating = useIsMutating()

Expand All @@ -23,11 +31,11 @@ describe('useIsMutating', () => {
mutation.mutateAsync('a')
mutation2.mutateAsync('b')

await sleep(0)
await vi.advanceTimersByTimeAsync(0)

expect(isMutating.value).toStrictEqual(2)

await sleep(0)
await vi.advanceTimersByTimeAsync(10)

expect(isMutating.value).toStrictEqual(0)
})
Expand All @@ -51,11 +59,11 @@ describe('useIsMutating', () => {
mutation.mutateAsync('a')
mutation2.mutateAsync('b')

await sleep(0)
await vi.advanceTimersByTimeAsync(0)

expect(isMutating.value).toStrictEqual(0)

await sleep(0)
await vi.advanceTimersByTimeAsync(0)

expect(isMutating.value).toStrictEqual(0)

Expand All @@ -66,7 +74,7 @@ describe('useIsMutating', () => {
const filter = reactive({ mutationKey: ['foo'] })
const { mutate } = useMutation({
mutationKey: ['isMutating'],
mutationFn: (params: string) => sleep(0).then(() => params),
mutationFn: (params: string) => sleep(10).then(() => params),
})
mutate('foo')

Expand All @@ -76,7 +84,7 @@ describe('useIsMutating', () => {

filter.mutationKey = ['isMutating']

await sleep(0)
await vi.advanceTimersByTimeAsync(0)

expect(isMutating.value).toStrictEqual(1)
})
Expand Down
Loading