chore(deps): update all non-major dependencies #9628
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
github-actions
bot
added
package: react-query-devtools
package: react-query
package: react-query-persist-client
package: vue-query
package: query-core
package: solid-query
package: query-persist-client-core
package: eslint-plugin-query
package: svelte-query
package: svelte-query-devtools
package: query-devtools
package: angular-query-experimental
package: angular-query-devtools-experimental
package: query-async-storage-persister
labels
WalkthroughThis PR updates dependency versions across example apps, integrations, the root workspace, and package manifests. Changes are limited to package.json files, primarily bumping framework/tooling versions (Angular, React/Vite, Solid, Svelte, Vue, Babel/Webpack, testing utilities). No source code or public API declarations were modified. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
github-actions
bot
added
package: query-sync-storage-persister
package: solid-query-persist-client
package: svelte-query-persist-client
package: vue-query-devtools
package: solid-query-devtools
package: query-broadcast-client-experimental
package: react-query-next-experimental
package: angular-query-persist-client
package: query-test-utils
labels
|
View your CI Pipeline Execution ↗ for commit 0b11537
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 20
🧹 Nitpick comments (13)
examples/react/eslint-legacy/package.json (1)
23-26: Align React 19 with @types v19 across all React examples
The following examples depend on React 19 but still reference @types/react@18 and @types/react-dom@18, which can cause type mismatches with TypeScript 5.8:
- examples/react/algolia/package.json
- examples/react/basic/package.json
- examples/react/eslint-legacy/package.json
- examples/react/react-router/package.json
In each, update the devDependencies to:
"@types/react": "^19.0.1", "@types/react-dom": "^19.0.2",.github/workflows/autofix.yml (1)
21-21: Pin actions/checkout to a commit SHA for supply-chain hardening
Optional, but recommended for immutable CI builds.
Example:- uses: actions/[email protected] + uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feacpackages/solid-query/package.json (1)
74-78: Solid toolchain bumps look consistentnpm-run-all2, solid-js, and vite-plugin-solid are aligned with other Solid packages in this PR. Peer range remains "^1.6.0", which is fine but broad; consider tightening the min if features require ≥1.9.
examples/react/algolia/package.json (1)
11-24: Use caret for @algolia/client-search
Replace the pinned version with a caret for consistency:- "@algolia/client-search": "5.37.0", + "@algolia/client-search": "^5.37.0",npm view confirms it requires Node ≥ 14.0.0 and its ESM/CJS exports align with your “type”: “module” + Vite setup.
packages/solid-query-devtools/package.json (1)
68-72: Peer range still valid; optional tighten-upDevDeps bumped (solid-js 1.9.9, vite-plugin-solid 2.11.8). Peer dep on solid-js is "^1.6.0", which covers 1.9.x—no action required. Optionally, document tested range (e.g., “>=1.6 <2”) in README to set expectations.
packages/react-query/package.json (1)
1-87: Add missing Vite devDependencyIn packages/react-query/package.json you have
@vitejs/plugin-react(^4.7.0) but noviteentry—add underdevDependencies:"devDependencies": { - "@vitejs/plugin-react": "^4.7.0" + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.0" }.github/workflows/pr.yml (1)
25-25: Consider pinning GitHub Actions to commit SHAs and adding job timeouts.actions/checkout and nrwl/nx-set-shas are on version tags. For supply‑chain hardening, pin to the release commit SHA with an inline comment for the tag. Also consider
timeout-minuteson jobs to prevent hangs.Also applies to: 33-33, 54-54
packages/solid-query-persist-client/package.json (1)
73-77: Dev deps bumped; peer range remains broad—consider CI matrix for Solid versions.Peer allows solid-js >=1.6 while tests run on 1.9.x. Optional: add a small CI matrix to smoke‑test a lower Solid within the supported peer range to catch regressions.
.github/workflows/ci.yml (1)
30-30: Same as pr.yml: optionally pin actions and add timeouts.Pin actions/checkout to a commit SHA and consider
timeout-minuteson the job/steps for resilience.packages/query-devtools/package.json (1)
67-81: Unifysolid-jsversions across the workspace
Update allsolid-jsentries to the same range (for example,^1.9.9), replacing the older^1.6.0in:
- packages/solid-query/package.json (lines 75 & 80)
- packages/solid-query-persist-client/package.json (lines 74 & 80)
- packages/solid-query-devtools/package.json (lines 69 & 75)
Then runpnpm -w dedupeto collapse duplicate versions in the lockfile.examples/react/rick-morty/package.json (1)
11-14: MUI upgrades OK; consider migrating off @mui/styles (deprecated).@mui/styles is legacy and discouraged for new code; plan a follow-up to replace it (e.g., Emotion/Pigment CSS). This is optional for this Renovate PR. (npmjs.com, mui.com)
package.json (1)
53-55: React Hooks plugin is RCeslint-plugin-react-hooks is on 6.0.0-rc1. If not intentional, prefer a stable tag to avoid churn; otherwise document the reason in the PR description.
- "eslint-plugin-react-hooks": "^6.0.0-rc1", + "eslint-plugin-react-hooks": "^6.0.0" # when GA landsexamples/angular/pagination/package.json (1)
19-19: Unify semver strategy for zone.jsThis example pins zone.js exactly (0.15.1) while other packages use ~0.15.1. Consider aligning to a single strategy for predictability.
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-sync-storage-persister/package.jsonexamples/solid/astro/package.jsonpackages/solid-query-devtools/package.jsonpackages/react-query-persist-client/package.jsonpackages/solid-query/package.jsonpackages/query-persist-client-core/package.jsonpackages/angular-query-persist-client/package.jsonpackages/svelte-query/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/vue-query/package.jsonpackages/react-query-devtools/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/vue-query-devtools/package.jsonpackages/query-core/package.jsonexamples/angular/basic-persister/package.jsonpackages/query-async-storage-persister/package.jsonpackages/react-query/package.jsonpackages/angular-query-experimental/package.jsonintegrations/react-vite/package.jsonintegrations/react-next-15/package.jsonpackages/react-query-next-experimental/package.jsonpackages/solid-query-persist-client/package.jsonexamples/vue/persister/package.jsonpackages/query-broadcast-client-experimental/package.jsonexamples/solid/basic/package.jsonexamples/solid/default-query-function/package.jsonpackages/angular-query-devtools-experimental/package.jsonpackages/svelte-query-devtools/package.jsonexamples/solid/simple/package.jsonpackages/svelte-query-persist-client/package.jsonintegrations/solid-vite/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
PR: TanStack/query#9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (58)
examples/vue/2.7-basic/package.json (1)
17-17: Vite 4.x bump for Vue 2.7 example looks good.No compatibility concerns with vue2 + vite-plugin-vue2 2.0.3.
packages/query-persist-client-core/package.json (1)
66-66: npm-run-all2 patch bump is safe.No script changes needed; CLI remains
npm-run-all.examples/react/shadow-dom/package.json (1)
19-22: Vite 6.3 + plugin-react 4.7 with React 19 types is consistent.This example is already on @types v19; upgrade set looks coherent.
packages/query-test-utils/package.json (1)
38-38: Uniform npm-run-all2 patch bump acknowledged.Matches the repo-wide update pattern.
examples/vue/2.6-basic/package.json (1)
18-18: Vite 4.x patch bump for Vue 2.6 example is fine.Keeps compatibility with vite-plugin-vue2 2.0.3.
examples/react/devtools-panel/package.json (1)
17-20: React devtools-panel: Vite/tooling bumps look consistent.No API or script changes required.
examples/vue/dependent-queries/package.json (1)
15-18: Vite 6.x bump: declare Node >=18 and regenerate lockfileOnly
examples/solid/basic-graphql-request/package.jsondeclaresengines.node(≥18); the root andexamples/vue/dependent-queries/package.jsonlack a Node version constraint. Addengines.node: ">=18"(and update your CI matrix), then reinstall to refresh the lockfile and lock Vite/plugin minors.examples/vue/nuxt3/package.json (1)
13-14: Nuxt upgrade sanity check
Version ^3.19.1 confirmed;nuxt.config.tscontains nonitro,experimental, orviteflags. Runnpm run dev,npm run build, andnpm run previewto catch any config regressions.examples/svelte/simple/package.json (1)
16-21: Ignore SvelteKit compatibility check for this example
Theexamples/svelte/simplesetup is a plain Svelte template—there’s no@sveltejs/kitdependency or Kit-specific config (noadapter-autoorvitePlugininsvelte.config.js), so verifying SvelteKit defaults isn’t applicable.Likely an incorrect or invalid review comment.
examples/solid/default-query-function/package.json (1)
13-19: Solid/Vite alignment looks goodsolid-js ^1.9.9 with vite ^6.3.5 and vite-plugin-solid ^2.11.8 is a known-good combo. No action beyond lockfile update.
examples/vue/persister/package.json (1)
15-22: Run build & smoke-test forexamples/vue/persister
Verifiedidb-keyvalis ^6.2.2 (no duplicates) and Vite is ^6.3.5 with @vitejs/plugin-vue ^5.2.4—please do a quick install, build, and runtime check to ensure ESM/CJS bundling works.packages/query-core/package.json (1)
61-64: npm-run-all2 bump validated
All package scripts continue to invoke “npm-run-all” (no hardcoded “npm-run-all2” usages detected).examples/solid/astro/package.json (1)
15-22: Approve dependencies bump in examples/solid/astro/package.json
Dependencies align with repo-wide versions (astro 5.5.6, solid-js 1.9.9, @astrojs/solid-js 5.1.0, tailwindcss 3.4.17); no compatibility issues detected.packages/react-query-persist-client/package.json (1)
67-71: Version consistency across workspaces: All instances of@vitejs/plugin-reactare^4.7.0and@testing-library/reactare^16.3.0in everypackage.json—no skew detected.integrations/react-vite/package.json (1)
11-15: Approve code changes: Vite and plugin-react versions are consistent across all React Vite integrations and examples. All scanned package.json files use Vite ^6.3.5 and @vitejs/plugin-react ^4.7.0.packages/react-query-next-experimental/package.json (1)
61-64: Approve dev-only dependency bumps
Vite plugin is imported inpackages/react-query-next-experimental/vite.config.ts, so the@vitejs/plugin-reactdev bump is used and safe; runtime surface remains unchanged.examples/solid/solid-start-streaming/package.json (1)
14-19: Approve: SolidStart 1.1.7 & vinxi 0.5.8 updates
Node >=18 is enforced in examples/solid/solid-start-streaming/package.json; no breaking changes expected.integrations/svelte-vite/package.json (1)
12-13: Approve Svelte/Vite version alignment
All Svelte (^5.38.7) and Vite (^6.3.5) versions are consistent across relevant workspaces and examples; peer ranges in svelte-query packages cover Svelte 5.packages/svelte-query/package.json (1)
50-57: Approve Svelte dev tooling version updates
PeerDependencies already allow Svelte ^5.0.0 and all Svelte examples use ^5.38.7; no breaking changes or CI impact.examples/react/playground/package.json (1)
17-20: Approve React playground toolchain bump – dependencies now align with other React examples; React ^19 verified consistently across all examples and packages.examples/react/suspense/package.json (1)
19-22: Verified Suspense example build with updated Vite/plugin
Suspense example builds successfully using Vite ^6.3.5 and @vitejs/plugin-react ^4.7.0 with no SWC/plugin default regressions or Suspense-related warnings.packages/query-sync-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump.Matches repo-wide update; no runtime impact expected.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump; deps align with learning.@tanstack/query-core is already a workspace dep (per prior learning); safe patch update.
examples/solid/basic-graphql-request/package.json (2)
13-16: Build passed with [email protected] & [email protected]—run TS type check
The Solid GraphQL example builds successfully; to catch any tightened type errors, run a full type‐check in the example:pnpm --filter "./examples/solid/basic-graphql-request" exec tsc --noEmit
19-21: Example build is green; verify Vite/Solid plugin version parity
Runcd examples/solid/basic-graphql-request && pnpm install && pnpm run buildto confirm the example builds cleanly, then ensure itsviteandvite-plugin-solidversions align with those in the otherexamples/solid/*/package.json.examples/react/simple/package.json (1)
17-19: examples/react/simple: build passed with Vite 6.3.5 & @vitejs/plugin-react 4.7.0
Build completed successfully with the updated tooling; no further changes required.examples/svelte/optimistic-updates/package.json (1)
15-22: Confirm Node engine ranges and svelte-check compatibility
- @sveltejs/kit 2.37.1 requires Node ≥18.13; vite 6.3.5 supports Node 18.x, 20.x or ≥22; svelte 5.38.7 requires Node ≥18. Ensure your CI matrix covers at least Node 18.13 and 20.x.
- svelte-check 4.3.1 peer-declares
svelte: "^4.0.0 || ^5.0.0-next.0"andtypescript: ">=5.0.0". Stable Svelte 5.38.7 falls outside the prerelease range and will trigger a peer-dependency warning—confirm support for Svelte 5 stable or upgrade to a svelte-check version that officially includes it.examples/react/basic-graphql-request/package.json (1)
13-20: Peer dependencies are compatible
- @vitejs/plugin-react 4.7.0 declares vite '^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0', satisfying vite ^6.3.5.
- graphql-request 7.2.0 declares graphql '14 - 16', satisfying graphql ^16.11.0.
integrations/vue-vite/package.json (1)
13-16: Peer ranges are already compatible
@vitejs/[email protected] declares vue^3.2.25(includes 3.4.27) and vite^5.0.0 || ^6.0.0(includes 6.3.5), so no changes required.examples/solid/simple/package.json (1)
13-20: No changes needed: peer dependencies satisfied
[email protected] requires vite ^3.0.0‒^7.0.0 and solid-js ^1.7.2; the project’s versions (^6.3.5 and ^1.9.9) satisfy these ranges.integrations/react-webpack-5/package.json (1)
14-19: Approve Babel/Webpack configuration
Peer dependencies for @babel/[email protected] and @babel/[email protected] both support @babel/core >= 7.0.0-0, and the chosen versions align with React 19’s automatic runtime and Webpack 5—no issues.packages/query-broadcast-client-experimental/package.json (1)
61-68: Ensure CJS interop viatest:build
Imports only use ESM-style named exports frombroadcast-channel(no CommonJSrequirefound). Now runnpm run test:buildand verify that the generated CJS bundle resolvesbroadcast-channelcorrectly.examples/angular/devtools-panel/package.json (1)
12-27: Verify @angular/compiler-cli TypeScript peer dependency
All Angular examples pin TS to 5.8.3; confirm that @angular/[email protected] peerDependencies.typescript accepts TS 5.8.x (e.g. runnpm view @angular/[email protected] peerDependencies.typescript).integrations/react-next-15/package.json (1)
9-9: Temporal polyfill bump is safe.No breaking changes expected for typical usage; Next 15 + React 19 remain unaffected.
packages/angular-query-devtools-experimental/package.json (1)
57-62: Dev Angular bumps LGTM; peer ranges remain wide enough.No runtime deps changed; only dev tooling. Good.
packages/react-query-devtools/package.json (1)
86-91: Aligns with React 19 and Testing Library v16.Peer range already allows ^18 || ^19; this is consistent.
examples/svelte/ssr/package.json (1)
15-22: Svelte/Kit/Vite bumps look consistent.No API surface here; just tooling updates.
packages/react-query/package.json (1)
73-82: Dev tooling bumps look consistent across workspace.React 19 + @types/react 19 + plugin-react 4.7 + Vite 6.3 is a good set.
examples/svelte/star-wars/package.json (1)
15-25: Svelte + Vite bumps look good; verify Node runtime ≥18.Vite 6 and SvelteKit 2 require modern Node. CI likely uses Node 20, but double‑check local/engines consistency to avoid dev-time surprises.
If you want, I can add an engines field or confirm Node versions across the repo.
examples/react/offline/package.json (1)
16-25: Verify MSW registration with bumped dependencies
Run the offline React example (pnpm -w -F @tanstack/query-example-react-offline dev) to confirm service worker registration remains clean under Vite 6.3 with MSW v2.11.1 and react-hot-toast v2.6.0.examples/react/basic/package.json (1)
21-22: Retain @types/react and @types/react-dom
React v19 does not include its own TypeScript definitions—continue installing @types/react and @types/react-dom to ensure proper typings. (19.react.dev, docs.codemod.com)Likely an incorrect or invalid review comment.
packages/svelte-query-devtools/package.json (1)
45-54: Svelte tooling bumps LGTM.Peer range already includes ^5, and the svelte/svelte-check bumps align with Kit/Vite updates elsewhere.
examples/svelte/auto-refetching/package.json (1)
15-16: Confirm uniform versions; manual build & type-check requiredAll Svelte examples (except
simple, which is plain Svelte) now use
• @sveltejs/kit ^2.37.1
• @sveltejs/adapter-auto ^6.1.0
• vite ^6.3.5
• svelte ^5.38.7Run local builds and
svelte-checkagainst TS 5.8.3 to verify plugin/peer compatibility with @sveltejs/vite-plugin-svelte (^5.1.1).examples/react/chat/package.json (1)
17-19: validate Tailwind v4 config in examples/react/chat
Notailwind.config.*orpostcss.config.*found underexamples/react/chat—Tailwind will fall back to its defaults. If you require custom settings, add atailwind.config.jswith acontentarray (replacing any oldpurgekey) and remove any v3-only options.examples/svelte/load-more-infinite-scroll/package.json (1)
15-16: Approve Svelte toolchain bumps – smoke build succeeded
Minimal canary build passed with @sveltejs/adapter-auto@^6.1.0 and @sveltejs/kit@^2.37.1 matching other examples.packages/svelte-query-persist-client/package.json (1)
50-50: Approve changes: eslint-plugin-svelte@^3.12.2 supports ESLint v8.57.1 and above (including v9.x) and our ESLint ^9.35.0 satisfies this (npmjs.com)packages/angular-query-experimental/package.json (1)
71-81: DTS output verified for angular-query-experimental
[email protected] correctly generates declaration files with TS 5.8.3—no regressions detected.examples/react/default-query-function/package.json (1)
17-20: Versions confirmed for Vite‐based examplesAll React examples that use Vite list @vitejs/plugin-react ^4.7.0 and vite ^6.3.5. The Next.js and React Native samples intentionally don’t include Vite and can be ignored. A smoke build of default-query-function passed; consider also verifying the basic and chat examples build correctly under TS 5.8.3 to sanity-check fast refresh and the JSX transform.
packages/eslint-plugin-query/package.json (1)
62-70: ESLint 9 + @typescript-eslint 8.42 alignment looks good; Node pinned in .nvmrc to 24.4.1 – verify your CI honors this or explicitly sets Node ≥18.18.0examples/svelte/playground/package.json (1)
15-22: Validate with svelte-check and build smoke test
Run svelte-check viapnpm -C examples/svelte/playground exec svelte-check(or add
"check": "svelte-check"to package.json)
and verifypnpm -C examples/svelte/playground run buildcompletes without errors.
examples/angular/basic-persister/package.json (1)
12-27: Fixexamples/angular/basic-persisterbuild failure
Build is currently failing with an Angular compilation error:Error: ENOENT: no such file or directory, uv_resident_set_memoryfrom the Angular compiler plugin. Investigate and resolve this issue so the example can successfully build and we can validate the persister interop.
⛔ Skipped due to learnings
Learnt from: TkDodo PR: TanStack/query#9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.examples/angular/optimistic-updates/package.json (1)
12-25: Confirm form-related typings with TS 5.8 in a proper environment. Build failed here due to missing/proc/self/statin this sandbox (uv_resident_set_memory error) (stackoverflow.com); Angular 20.2.x supports Node v24.3.0 (angular.dev). Re-run build in CI or a local full-Linux environment to validate strict template type drift.integrations/solid-vite/package.json (1)
11-13: Solid + Vite bumps look fine; ensure CI Node matrix aligns with Vite 6 support.Vite 6 supports Node 18/20/22+. If your CI still runs Node 16/19, adjust it to avoid spurious failures. (main.vite.dev, main.vitejs.dev)
packages/angular-query-persist-client/package.json (1)
60-71: Angular 20.2 devDeps: verify workspace TypeScript ≥5.9 and Node ≥20.19.Angular 20.2.x requires TS >=5.9 and Node >=20.19. If the workspace/root still pins TS 5.8.3, local builds/tests here may fail. (angular.dev)
integrations/react-webpack-4/package.json (1)
14-17: Babel deps upgraded — still compatible with webpack 4.babel-loader 8.x supports webpack 4 and 5; this bump is safe for the v4 example. (webpack.js.org, github.com)
package.json (2)
41-45: ESLint plugin peer dependencies verifiedAll listed plugins resolved against eslint 9.35.0 with no peer-dependency warnings on install.
69-76: CI covers TS 5.x aliases via existingtest:typestarget
Theci.ymlandpr.ymlworkflows runpnpm run test:ci/test:pr, which invoke the NXtest:typestarget across all packages. Each package’stest:typesscript in turn runs itstest:types:ts50–test:types:ts57commands, exercising every TS alias without needing an explicit matrix.integrations/angular-cli-20/package.json (1)
12-21: Angular 20.2.x dependency set looks consistentCore/angular and rxjs/tslib/zone.js versions are in lockstep and match examples. LGTM.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2 upgrade: double-check TypeScript support window.
Angular often pins a TS range. You have TS 5.8.3 here; ensure it’s within Angular 20.2.x supported versions to avoid ngc/CLI issues.
Also applies to: 19-19, 22-24
🌐 Web query:
What TypeScript versions are officially supported by Angular v20.2.x (framework and CLI)?
💡 Result:
Angular v20.2.x supports TypeScript >=5.9.0 and <6.0.0 (applies to the framework and CLI). [1][2]
Sources:
[1] Angular — Version compatibility (angular.dev).
[2] "What’s new in Angular 20.2?" — Ninja Squad blog.
Upgrade TypeScript to ≥5.9.0 for Angular 20.2.x
In examples/angular/auto-refetching/package.json devDependencies, bump "typescript" from ^5.8.3 to at least ^5.9.0 (Angular 20.2.x requires TS ≥5.9.0 <6.0.0).
🤖 Prompt for AI Agents
In examples/angular/auto-refetching/package.json around lines 12 to 15, the
devDependency "typescript" is still ^5.8.3 which is incompatible with Angular
20.2.x; update the "typescript" entry in devDependencies to at least "^5.9.0"
(ensure the range stays <6.0.0), save package.json and run the package manager
install to update lockfile/dependencies.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", | ||
| "@tanstack/angular-query-experimental": "^5.87.1", | ||
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.15.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2 + TS 5.8 combo: please verify supported TypeScript range.
Core/framework is ^20.2.4 while the workspace uses TypeScript 5.8.3. That’s likely fine, but Angular’s supported TS matrix can be strict across minors.
🌐 Web query:
Which TypeScript versions are officially supported by Angular 20.2.x (framework and CLI)?
💡 Result:
Angular 20.2.x officially supports TypeScript >=5.9.0 and <6.0.0 (framework and CLI). (angular.dev)
Citations:
Upgrade TypeScript to ≥5.9.0 <6.0.0
Angular 20.2.x officially requires TS >=5.9.0 <6.0.0; devDependencies currently specify 5.8.3—bump to at least 5.9.0 (examples/angular/infinite-query-with-max-pages/package.json) (angular.dev)
🤖 Prompt for AI Agents
In examples/angular/infinite-query-with-max-pages/package.json around lines 12
to 25 the devDependency "typescript" is pinned to 5.8.3 which is incompatible
with Angular 20.2.x; update the "typescript" version to a value in the supported
range (>=5.9.0 <6.0.0), e.g., set it to "5.9.0" or a later 5.x patch (5.9.x),
and then run npm install (or pnpm/ yarn) and verify the example builds.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2.x with TS 5.8.3: verify supported range
Angular’s supported TypeScript ranges can be tight. Please confirm 20.2.x officially supports TS 5.8.3 used here.
🌐 Web query:
What TypeScript versions are officially supported by Angular 20.2.x (framework and CLI)?
💡 Result:
Angular 20.2.x (framework and CLI) officially supports TypeScript >= 5.9.0 and < 6.0.0. [1]
Sources
[1] Angular Version compatibility (Angular docs).
Upgrade TypeScript to ≥5.9.0 <6.0.0
Angular 20.2.x requires TypeScript versions ≥5.9.0 and <6.0.0; TS 5.8.3 is unsupported. Update your devDependencies (e.g. in examples/angular/pagination/package.json) to bump TypeScript accordingly.
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 12–15 the project lists
Angular 20.2.x but still uses an unsupported TypeScript (5.8.3); update the
devDependencies TypeScript entry to a version compatible with Angular 20
(>=5.9.0 <6.0.0) such as ^5.9.0, then run npm/yarn install to refresh the
lockfile; ensure the updated version satisfies the peer range and rebuild/test
the example.
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular build/CLI/compiler-cli bumps: confirm CLI↔TS compatibility
Ensure @angular/cli@^20.2.2 and compiler-cli@^20.2.4 are compatible with TypeScript 5.8.3 and your tsconfig settings.
🌐 Web query:
Is TypeScript 5.8 supported by @angular/cli 20.2 and @angular/compiler-cli 20.2?
💡 Result:
Short answer: No. Angular 20.2 requires TypeScript >= 5.9 (< 6.0); TypeScript 5.8 is supported by earlier 20.0/20.1 releases but not by 20.2. [1][2]
Sources:
- Angular version compatibility table (Angular docs). [1]
- Angular (next) version compatibility table / release notes. [2]
Upgrade TypeScript to ≥5.9 <6.0 for Angular 20.2 compatibility
Change "typescript": "5.8.3" to at least "^5.9.0" (<6.0.0) in examples/angular/pagination/package.json to satisfy @angular/[email protected] and @angular/[email protected] requirements. (angular.dev)
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 22 to 25, the
TypeScript version is pinned to "5.8.3" which is incompatible with
@angular/[email protected] and @angular/[email protected]; update the TypeScript
dependency to a version >=5.9 and <6.0 (e.g. "^5.9.0") to satisfy Angular 20.2
compatibility and ensure the version range is reflected in package.json
dependencies or devDependencies accordingly.
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "~5.8.2" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
TS ~5.8.2: align with example or confirm range
This uses ~5.8.2 while the example uses 5.8.3. Optional: align to 5.8.3 for determinism, or keep ~ for patch drift—just be consistent across Angular samples.
- "typescript": "~5.8.2"
+ "typescript": "5.8.3"🌐 Web query:
Does Angular 20.2.x officially support TypeScript 5.8.x?
💡 Result:
Short answer: No — Angular 20.2.x requires TypeScript >=5.9 and does not officially support TypeScript 5.8.x. [1]
Source: Angular "Version compatibility" table. [1]
Upgrade TypeScript to >=5.9.0 for Angular 20.2.x compatibility
Angular 20.2.x requires TypeScript >=5.9.0 <6.0.0, so ~5.8.2 is unsupported. (angular.dev)
- "typescript": "~5.8.2"
+ "typescript": ">=5.9.0 <6.0.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@angular/build": "^20.2.2", | |
| "@angular/cli": "^20.2.2", | |
| "@angular/compiler-cli": "^20.2.4", | |
| "typescript": "~5.8.2" | |
| "@angular/build": "^20.2.2", | |
| "@angular/cli": "^20.2.2", | |
| "@angular/compiler-cli": "^20.2.4", | |
| "typescript": ">=5.9.0 <6.0.0" |
🤖 Prompt for AI Agents
integrations/angular-cli-20/package.json lines 24-27: the TypeScript version is
pinned to ~5.8.2 which is incompatible with Angular 20.2.x; update the
dependency to a TypeScript range that satisfies Angular's requirement (>=5.9.0
<6.0.0) — for example set "typescript" to "^5.9.0" (or "~5.9.0") in
package.json, then run your package manager (npm/yarn/pnpm) to reinstall and run
the project build/tests to verify compatibility.
package.json
Outdated
| "url": "https://github.com/TanStack/query.git" | ||
| }, | ||
| "packageManager": "pnpm@10.13.1", | ||
| "packageManager": "pnpm@10.15.1", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm CI/dev environments support pnpm 10.15.1
Make sure GitHub Actions, local dev docs, and any version managers (.nvmrc/.node-version/Volta) align with [email protected] and its Node.js requirements.
Run:
🏁 Script executed:
#!/bin/bash
# Where do we pin Node?
fd -a '(\.nvmrc|\.node-version|package\.json|README\.md)' -HI | xargs -I {} sh -c 'echo "---- {}"; sed -n "1,120p" "{}" | rg -n "node|engines|volta|pnpm" -n || true'
# CI: check Node / pnpm setup
fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'Length of output: 29271
🏁 Script executed:
#!/bin/bash
echo ".nvmrc content:"
sed -n '1,20p' .nvmrc
echo "CI workflows search:"
rg -nE 'setup-node|node-version|pnpm' -n .github/workflowsLength of output: 109
🏁 Script executed:
#!/bin/bash
echo ".nvmrc:"
head -n 5 .nvmrc || echo "no .nvmrc"
echo "Find .node-version:"
test -f .node-version && head -n 5 .node-version || echo "no .node-version"
echo "List CI workflow files:"
find .github/workflows -type f -maxdepth 2 -print || echo "no workflows directory"
echo "Search workflows for Node/pnpm setup:"
rg -n 'setup-node|node-version|pnpm' .github/workflows || echo "no matches"Length of output: 740
Align Node.js version and pin in CI
- .nvmrc sets Node.js v24.4.1, but pnpm@10 only officially supports Node.js 18–22 (pnpm.io); adjust .nvmrc (or use
.npmrcuse-node-version) to a supported LTS. - Add
actions/setup-node@v3with the samenode-versionin.github/workflows/ci.ymlandpr.yml. - Document the Node.js requirement in README (or add a
.node-version/Volta config) for local-dev consistency.
🤖 Prompt for AI Agents
In package.json around line 8 (the [email protected] pin) the project Node version in
.nvmrc (v24.4.1) is incompatible with pnpm@10 which officially supports Node
18–22; update .nvmrc to a supported LTS (for example 22.x) or upgrade/downgrade
the pinned pnpm to a version that supports Node 24, then add
actions/setup-node@v3 to .github/workflows/ci.yml and .github/workflows/pr.yml
with the same node-version value to enforce the runtime in CI, and document the
chosen Node requirement in README or add a .node-version / Volta config file for
local-dev consistency.
package.json
Outdated
| "@vitest/coverage-istanbul": "3.2.4", | ||
| "@vitest/eslint-plugin": "^1.3.9", | ||
| "cpy-cli": "^5.0.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Vitest upgrades: double-check coverage + eslint integration
After bumping vitest and @vitest/coverage-istanbul, confirm coverage provider config matches (istanbul vs v8) and lint rules still detect test globals.
Run:
Also applies to: 78-79
🏁 Script executed:
#!/bin/bash
# Look for coverage provider setting
fd -a 'vitest.config.*' -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "coverage|provider" "{}" -n || true'
# Ensure ESLint knows vitest env
fd -a '.eslintrc*' -HI | xargs -I {} sh -c 'echo "---- {}"; rg -n "vitest|jest" "{}" -n || true'Length of output: 1894
Add Vitest configuration for Istanbul coverage and enable Vitest in ESLint
- No
vitest.config.*detected → Vitest will use its default (V8) provider. Create a root config (e.g.vitest.config.ts) with:import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })
- None of the existing
.eslintrc.*files declare the Vitest plugin or environment → add to your ESLint config:so test globals are recognized.extends: ['plugin:vitest/recommended'], env: { vitest: true }
🤖 Prompt for AI Agents
In package.json around lines 49 to 51, there is no Vitest project config and
ESLint is not set up for Vitest; add a root vitest.config.* (e.g.,
vitest.config.ts) that calls defineConfig and sets test.coverage.provider to
"istanbul" so the @vitest/coverage-istanbul package is used, and update your
root ESLint configuration file(s) (.eslintrc.js/.json/.ts) to extend
"plugin:vitest/recommended" and add env: { vitest: true } so Vitest globals are
recognized by the linter.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
b611e96 to
c307bb6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
packages/vue-query-devtools/package.json (1)
58-61: eslint-plugin-vue 9.33.0 + Vite 6.3.6 — rerun lint/build to catch rule flips.Please rerun the package’s ESLint and build to ensure no new violations or bundling regressions. This echoes an earlier comment about eslint-plugin-vue upgrades across the repo.
Suggested commands:
#!/bin/bash pnpm install --frozen-lockfile pnpm -w -F @tanstack/vue-query-devtools run test:eslint pnpm -w -F @tanstack/vue-query-devtools run buildpackage.json (2)
8-8: pnpm 10.15.1 — ensure Node version alignment in local/CI.Verify the repo’s pinned Node version(s) (.nvmrc/.node-version/Volta) and CI workflows match a Node release supported by pnpm 10. If mismatched, bump Node in those places or adjust pnpm. Mirrors a prior note on this topic.
Script to surface versions:
#!/bin/bash set -euo pipefail echo "Node pins:" fd -HI '(\.nvmrc|\.node-version|package\.json)' | xargs -I {} sh -c 'echo "---- {}"; rg -n "engines|volta|node" "{}" -n || true' echo echo "Workflows Node/pnpm setup:" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'
49-51: Ensure Istanbul coverage is configured for @vitest/coverage-istanbul.If no vitest.config.* sets coverage.provider, Vitest defaults to v8. Add a root config to opt into Istanbul and enable ESLint’s Vitest rules. (Reiterating an earlier suggestion.)
Add files:
// vitest.config.ts import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })- "devDependencies": { + "devDependencies": { "@vitest/eslint-plugin": "^1.3.9", ... "vitest": "3.2.4" }, + "eslintConfig": { + "extends": ["plugin:vitest/recommended"], + "env": { "vitest/globals": true } + }Also applies to: 77-79
🧹 Nitpick comments (2)
integrations/react-vite/package.json (1)
11-15: Vite 6.3.6 + @vitejs/plugin-react 4.7.0 upgrade — looks fine; consider moving to devDependencies.Tooling like Vite and its plugins are typically dev-only to avoid inflating consumers’ installs. If this package isn’t published with a runtime need for them, consider relocating to devDependencies.
Proposed change:
{ "dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", - "react": "^19.0.0", - "react-dom": "^19.0.0", - "vite": "^6.3.6" + "react": "^19.0.0", + "react-dom": "^19.0.0" }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.6" + } }package.json (1)
1-10: Optional: declare engines to codify supported Node/pnpm.Codifies runtime expectations and helps tooling.
{ "name": "root", "private": true, + "engines": { + "node": ">=18 <25", + "pnpm": ">=10.15.0" + }, "repository": {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/query-sync-storage-persister/package.json
- examples/vue/2.7-basic/package.json
- packages/query-core/package.json
- examples/solid/simple/package.json
- examples/vue/dependent-queries/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- integrations/react-next-15/package.json
- examples/solid/basic/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/basic/package.json
- examples/react/suspense/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/star-wars/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/simple/package.json
- packages/solid-query-devtools/package.json
- examples/angular/rxjs/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/playground/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/simple/package.json
- examples/solid/astro/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/ci.yml
- examples/solid/basic-graphql-request/package.json
- examples/react/devtools-panel/package.json
- examples/react/react-router/package.json
- packages/react-query/package.json
- integrations/react-webpack-5/package.json
- packages/query-test-utils/package.json
- integrations/react-webpack-4/package.json
- examples/react/basic-graphql-request/package.json
- .github/workflows/autofix.yml
- examples/react/shadow-dom/package.json
- packages/svelte-query/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/persister/package.json
- examples/vue/nuxt3/package.json
- examples/angular/pagination/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/default-query-function/package.json
- packages/solid-query/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/default-query-function/package.json
- integrations/solid-vite/package.json
- examples/angular/basic/package.json
- examples/vue/basic/package.json
- packages/vue-query/package.json
- examples/react/playground/package.json
- examples/svelte/simple/package.json
- packages/query-persist-client-core/package.json
- examples/angular/router/package.json
- examples/react/star-wars/package.json
- examples/react/chat/package.json
- packages/angular-query-experimental/package.json
- integrations/vue-vite/package.json
- examples/svelte/ssr/package.json
- examples/svelte/optimistic-updates/package.json
- .github/workflows/pr.yml
- examples/react/react-native/package.json
- examples/react/rick-morty/package.json
- examples/svelte/auto-refetching/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/basic-persister/package.json
- examples/svelte/basic/package.json
- examples/react/algolia/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/devtools-panel/package.json
- examples/react/simple/package.json
- packages/query-devtools/package.json
- packages/angular-query-devtools-experimental/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- examples/angular/optimistic-updates/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonintegrations/react-vite/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (3)
examples/react/offline/package.json (1)
16-25: MSW 2.11.1 and react-hot-toast 2.6.0 — quick smoke test the example.
- MSW: confirm the worker still registers with the existing "msw.workerDirectory": ["public"] config.
- react-hot-toast: verify toasts render under React 19 with no act warnings.
Commands to validate locally:
#!/bin/bash pnpm -F @tanstack/query-example-react-offline install --frozen-lockfile pnpm -F @tanstack/query-example-react-offline run dev # In the browser console: ensure MSW starts (no 404 for /mockServiceWorker.js) and UI toasts display.packages/solid-query-persist-client/package.json (1)
73-77: Dev dependency bumps align with peer ranges — LGTM.solid-js dev bump to ^1.9.9 is compatible with peer "^1.6.0"; vite-plugin-solid and npm-run-all2 minors are safe. No action needed.
package.json (1)
41-79: ESLint 9.35 + React Hooks plugin rc + Vitest 3.2 — re-run repo lint/tests.Major/minor linter/test bumps can surface new errors. Please run the affected scripts repo-wide.
#!/bin/bash pnpm install --frozen-lockfile pnpm run test:eslint pnpm run test:lib pnpm run test:types pnpm run test:build
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.37.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.36.8", | ||
| "svelte-check": "^4.3.0", | ||
| "svelte": "^5.38.7", | ||
| "svelte-check": "^4.3.1", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.6" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
SvelteKit 2.37.1 + Svelte 5.38.7 — run svelte-check and build.
Minor/patch bumps should be safe; please validate types and a production build.
🏁 Script executed:
#!/bin/bash
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll install --frozen-lockfile
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll exec svelte-check
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll run buildLength of output: 3975
Fix SvelteKit setup and missing @tanstack/svelte-query dependency
svelte-check errored: cannot find ./.svelte-kit/tsconfig.json (you need to generate it before running type checks—e.g. run pnpm run dev or add a prepare: svelte-kit sync script).
vite build failed: cannot resolve package entry for @tanstack/svelte-query—you must install it (e.g. add "@tanstack/svelte-query" to your dependencies in examples/svelte/load-more-infinite-scroll/package.json) and verify its exports field.
🤖 Prompt for AI Agents
In examples/svelte/load-more-infinite-scroll/package.json around lines 15 to 22,
the project is missing a prepare script to generate .svelte-kit/tsconfig.json
and the @tanstack/svelte-query dependency required by the app; add a "prepare"
script that runs svelte-kit sync (so the tsconfig is generated for type checks)
and add "@tanstack/svelte-query" to the dependencies with a compatible version,
then run the package manager to install and confirm the package resolves (or pin
a version known to export correctly), and finally run the dev build to ensure
.svelte-kit is created and vite can resolve the new dependency.
c307bb6 to
2aa5b29
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (73)
- examples/solid/solid-start-streaming/package.json
- integrations/svelte-vite/package.json
- integrations/react-vite/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-test-utils/package.json
- examples/react/offline/package.json
- examples/react/shadow-dom/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/basic/package.json
- integrations/angular-cli-20/package.json
- examples/react/basic/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/simple/package.json
- packages/svelte-query-devtools/package.json
- examples/react/chat/package.json
- examples/react/simple/package.json
- examples/svelte/ssr/package.json
- examples/react/star-wars/package.json
- examples/react/rick-morty/package.json
- examples/react/basic-graphql-request/package.json
- examples/solid/simple/package.json
- packages/eslint-plugin-query/package.json
- examples/svelte/playground/package.json
- packages/query-core/package.json
- packages/react-query/package.json
- examples/angular/basic-persister/package.json
- examples/solid/astro/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/suspense/package.json
- examples/react/playground/package.json
- packages/query-async-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- integrations/vue-vite/package.json
- examples/angular/router/package.json
- integrations/solid-vite/package.json
- packages/solid-query/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/angular-query-experimental/package.json
- packages/solid-query-persist-client/package.json
- packages/react-query-persist-client/package.json
- examples/react/algolia/package.json
- integrations/react-next-15/package.json
- examples/react/devtools-panel/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/svelte-query/package.json
- integrations/react-webpack-5/package.json
- examples/vue/nuxt3/package.json
- examples/svelte/simple/package.json
- examples/react/react-router/package.json
- examples/vue/persister/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-devtools/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/simple/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/auto-refetching/package.json
- examples/solid/default-query-function/package.json
- packages/react-query-devtools/package.json
- examples/svelte/star-wars/package.json
- examples/angular/basic/package.json
- packages/vue-query-devtools/package.json
- packages/angular-query-persist-client/package.json
- examples/solid/basic/package.json
- examples/react/react-native/package.json
- packages/vue-query/package.json
- packages/query-persist-client-core/package.json
- examples/vue/basic/package.json
- examples/angular/rxjs/package.json
- packages/svelte-query-persist-client/package.json
- packages/solid-query-devtools/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (3)
examples/react/default-query-function/package.json (1)
17-17: Ensure Node ≥20.19 for @vitejs/plugin-react 4.7.0The plugin requires Node 20.19+ (or 22.12+). Make sure local/CI Node versions meet this, or installs will fail. Consider adding an engines.node entry here or enforcing at the root/CI.
#!/bin/bash # Verify Node version pins and CI setup across the repo. echo "Root/package engines:" rg -nC1 '"engines"\s*:' -g package.json echo echo "Example engines:" fd -a package.json examples | xargs -I {} sh -c 'rg -nC1 "\"engines\"\\s*:" "{}" || true' echo echo "Node setup in GitHub Actions:" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|cache: pnpm|pnpm/action-setup" "{}" || true' echo echo ".nvmrc / .node-version:" test -f .nvmrc && { echo ".nvmrc:"; cat .nvmrc; } || echo "no .nvmrc" test -f .node-version && { echo ".node-version:"; cat .node-version; } || echo "no .node-version"examples/angular/auto-refetching/package.json (1)
22-25: Bump TypeScript to ≥5.9 <6.0 for Angular 20.3.x compatibilityAngular 20.3.x (framework/CLI/compiler-cli) requires TS >=5.9,<6.0. The current 5.8.3 will error.
Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/pagination/package.json (1)
22-25: Upgrade TypeScript to satisfy Angular 20.3.xAngular 20.3.x requires TS >=5.9,<6.0. Update from 5.8.3 to avoid install/build failures.
- "typescript": "5.8.3" + "typescript": "^5.9.0"
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
4 times, most recently
from
8bb6853 to
6993c4e
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/react/basic/package.json (1)
21-22: React 19 ships its own types; remove @types/react to avoid conflicts.*Keeping
@types/react/@types/react-dom(v18) with React 19 can cause duplicate/incorrect types.Apply:
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.90.1", - "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.3.6" },After removal, ensure TS still compiles cleanly in this example.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (75)
- examples/react/simple/package.json
- integrations/svelte-vite/package.json
- packages/query-test-utils/package.json
- examples/react/chat/package.json
- examples/react/default-query-function/package.json
- examples/solid/default-query-function/package.json
- packages/query-persist-client-core/package.json
- integrations/vue-vite/package.json
- examples/react/suspense/package.json
- examples/svelte/optimistic-updates/package.json
- integrations/solid-vite/package.json
- integrations/react-next-15/package.json
- packages/solid-query/package.json
- packages/react-query-devtools/package.json
- examples/vue/basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/react-native/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/auto-refetching/package.json
- packages/react-query/package.json
- examples/solid/astro/package.json
- packages/solid-query-persist-client/package.json
- examples/react/playground/package.json
- examples/react/star-wars/package.json
- packages/query-core/package.json
- examples/react/shadow-dom/package.json
- packages/svelte-query-persist-client/package.json
- packages/angular-query-experimental/package.json
- examples/react/rick-morty/package.json
- integrations/angular-cli-20/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/angular/rxjs/package.json
- examples/svelte/simple/package.json
- examples/angular/basic/package.json
- examples/angular/pagination/package.json
- examples/vue/dependent-queries/package.json
- examples/react/algolia/package.json
- examples/vue/nuxt3/package.json
- examples/angular/simple/package.json
- examples/vue/persister/package.json
- examples/svelte/basic/package.json
- examples/solid/simple/package.json
- examples/vue/simple/package.json
- packages/react-query-next-experimental/package.json
- integrations/react-vite/package.json
- examples/solid/solid-start-streaming/package.json
- packages/query-devtools/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/basic-graphql-request/package.json
- packages/svelte-query-devtools/package.json
- packages/solid-query-devtools/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/router/package.json
- packages/eslint-plugin-query/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/playground/package.json
- examples/svelte/star-wars/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/offline/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/optimistic-updates/package.json
- examples/svelte/ssr/package.json
- package.json
- examples/react/react-router/package.json
- packages/angular-query-persist-client/package.json
- integrations/react-webpack-5/package.json
- examples/react/devtools-panel/package.json
- packages/svelte-query/package.json
- examples/angular/devtools-panel/package.json
- packages/vue-query-devtools/package.json
- integrations/react-webpack-4/package.json
- packages/vue-query/package.json
- examples/solid/basic/package.json
- examples/angular/basic-persister/package.json
- packages/react-query-persist-client/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-broadcast-client-experimental/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (3)
examples/react/basic/package.json (1)
23-23: Approved — @vitejs/[email protected] is compatible with Vite 6.
peerDependencies: "vite": "^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0"; local devDependency: ^6.3.6; engines: node ^14.18.0 || >=16.0.0packages/query-broadcast-client-experimental/package.json (2)
65-67: Check peer/engine compatibility for updated devDeps.
- @testing-library/react@^16.3.0 — OK: workspace contains React/React‑DOM >=18 (root and many example packages use ^18/^19).
- @vitejs/plugin-react@^4.7.0 — OK: workspace Vite is ^6.3.6 (>=5).
- npm-run-all2@^5.0.2 — requires Node >=18; repo root has no engines.node and no .github workflow sets Node version. Confirm CI/build Node >=18 or add engines.node at the repo root / update CI.
Location: packages/query-broadcast-client-experimental/package.json (devDeps updated).
62-62: Confirm [email protected] exports/packaging compatibility (ESM/CJS/browser)7.1.0 publishes exports-based entrypoints (separate ESM/CJS/browser builds) — this can block undocumented subpath imports; changelog shows no other breaking API changes.
- Check packages/query-broadcast-client-experimental/package.json (depends on ^7.1.0) and ensure all imports use the package root (import 'broadcast-channel') — search repo for "broadcast-channel/" or require('broadcast-channel/...') and fix any subpath usage.
- Run the full build and CI tests on the Node/bundler targets you support to confirm package "exports" resolve correctly.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
6993c4e to
55e0429
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
package.json (1)
53-53: Potential downgrade/pre-release: eslint-plugin-react-hooks set to rc1. rc1 is a prerelease and may be older or less stable than the latest stable release—update to the latest stable version or ensure consistency across all package.json files.examples/vue/simple/package.json (1)
16-16: LGTM on plugin-vue bump; consider enforcing Node ≥18.Vite 6.x and plugin-vue 5.x expect Node 18+. Consider adding an engines field and pinning CI to Node ≥18 to avoid environment drift.
examples/vue/dependent-queries/package.json (1)
15-15: LGTM on plugin-vue bump; consider enforcing Node ≥18.Same note as other Vue examples: add
"engines": { "node": ">=18" }and ensure CI uses Node ≥18 for Vite 6.examples/svelte/load-more-infinite-scroll/package.json (1)
16-21: SvelteKit/tooling bumps look good; enforce Node ≥18.SvelteKit 2.x and Vite 6 run best on Node ≥18.13. Add an engines field and pin CI accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (54)
- packages/query-async-storage-persister/package.json
- examples/react/algolia/package.json
- packages/svelte-query-persist-client/package.json
- integrations/solid-vite/package.json
- integrations/vue-vite/package.json
- packages/eslint-plugin-query/package.json
- packages/react-query/package.json
- examples/svelte/simple/package.json
- examples/angular/optimistic-updates/package.json
- packages/solid-query-devtools/package.json
- examples/react/star-wars/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/suspense/package.json
- packages/solid-query/package.json
- integrations/react-vite/package.json
- examples/solid/basic/package.json
- examples/react/basic/package.json
- examples/react/default-query-function/package.json
- examples/svelte/ssr/package.json
- examples/solid/basic-graphql-request/package.json
- examples/vue/basic/package.json
- examples/react/rick-morty/package.json
- examples/solid/simple/package.json
- examples/react/react-native/package.json
- examples/angular/auto-refetching/package.json
- integrations/svelte-vite/package.json
- packages/query-test-utils/package.json
- packages/solid-query-persist-client/package.json
- packages/svelte-query/package.json
- integrations/react-webpack-5/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-devtools/package.json
- examples/vue/persister/package.json
- examples/angular/basic-persister/package.json
- examples/angular/basic/package.json
- examples/react/react-router/package.json
- examples/solid/default-query-function/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/react-query-next-experimental/package.json
- examples/react/simple/package.json
- packages/angular-query-persist-client/package.json
- packages/vue-query/package.json
- examples/react/chat/package.json
- examples/solid/astro/package.json
- packages/query-devtools/package.json
- packages/angular-query-experimental/package.json
- integrations/react-webpack-4/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/star-wars/package.json
- examples/react/playground/package.json
- examples/angular/rxjs/package.json
- examples/angular/devtools-panel/package.json
- packages/query-broadcast-client-experimental/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-sync-storage-persister/package.jsonpackages/vue-query-devtools/package.jsonintegrations/react-next-15/package.jsonpackages/svelte-query-devtools/package.jsonpackages/query-persist-client-core/package.jsonpackages/query-core/package.jsonpackage.jsonexamples/solid/solid-start-streaming/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (21)
integrations/react-next-15/package.json (1)
9-9: LGTM: Temporal polyfill bump looks safe.^0.5.x stays within the same minor; no API‑surface in our code here. Nothing else to do.
examples/react/devtools-panel/package.json (1)
17-17: LGTM: @vitejs/plugin-react aligns with Vite ^6.3.6.No config changes required here.
examples/vue/nuxt3/package.json (1)
13-13: Add engines.node to match Nuxt 3.19.x requirements.Nuxt 3.19.x requires modern Node (Nuxt docs list Node ≥20.19 or ≥22.12). Add an engines field to prevent CI/dev drift.
Apply:
"devDependencies": { "nuxt": "^3.19.2" }, + "engines": { + "node": "^20.19.0 || >=22.12.0" + }Also ensure your Vue version (resolved by Nuxt) satisfies @tanstack/vue-query peer "vue": "^3.3.0".
#!/bin/bash # Check Nuxt node engines and vue peer range jq -r '.engines // "no engines in package.json"' examples/vue/nuxt3/package.json # Verify the installed/resolved vue version in the lockfile (if present) rg -n '^ {2}"vue@' pnpm-lock.yaml -n || truepackages/query-persist-client-core/package.json (1)
66-66: LGTM: npm-run-all2 patch update.Drop‑in patch; scripts already use npm-run-all binary name.
examples/react/shadow-dom/package.json (1)
19-19: LGTM: @vitejs/plugin-react → ^4.7.0.Matches Vite ^6.3.6 used here.
package.json (2)
8-8: pnpm 10.17.1 vs Node version in CI/dev — ensure compatibility.If your repo/CI uses Node 24 (e.g., .nvmrc), pnpm 10.x doesn’t officially support it. Align Node (20/22) or upgrade pnpm to a Node‑24 compatible release.
#!/bin/bash echo "packageManager line:" rg -n '"packageManager":' package.json echo -e "\n.nvmrc (if present):" test -f .nvmrc && cat .nvmrc || echo "no .nvmrc" echo -e "\nWorkflows Node/pnpm setup:" rg -n 'setup-node|node-version|pnpm' .github/workflows || true
49-50: Ensure Vitest coverage config uses Istanbul provider.You’re pinning @vitest/coverage-istanbul but no root vitest.config was found in prior checks. Add test.coverage.provider = "istanbul" so coverage runs as expected, and enable Vitest env in ESLint.
// vitest.config.ts import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })Also applies to: 76-77
examples/solid/solid-start-streaming/package.json (1)
14-19: SSR build may still fail to resolve @tanstack/query-core.Earlier builds showed vinxi/Vite failing to resolve a transitive import from packages/solid-query. If that persists, add "@tanstack/query-core" to this example’s dependencies or adjust bundling/externalization.
#!/bin/bash # Look for unresolved imports to @tanstack/query-core in solid-query outputs/sources rg -nP "@tanstack/query-core" packages/solid-query -C2 || truepackages/vue-query-devtools/package.json (1)
58-58: Install dependencies & re-run ESLint for vue-query-devtools.
Run in the repo root:pnpm install pnpm -w -F @tanstack/vue-query-devtools run test:eslintConfirm [email protected] introduces no new lint errors.
packages/query-sync-storage-persister/package.json (1)
67-67: LGTM: tooling bump only.npm-run-all2 minor bump looks safe; workspace deps on query-core/persist-client-core are present as required.
examples/react/offline/package.json (1)
22-24: Add engines: Node ≥18 for Vite 6 and @vitejs/plugin-react 4.7.0.Prevents installs on unsupported Node in local/CI. Also update workflows to set up Node ≥18.
Here’s a minimal addition you can place after the "type" field:
"engines": { "node": ">=18" }packages/query-core/package.json (1)
63-63: LGTM: dev tooling bump only.No runtime/API impact.
examples/react/eslint-legacy/package.json (1)
20-24: Align React type packages with React 19 to avoid TS type mismatches.React/react-dom are ^19 but @types/* are ^18. Recommend bumping types to ^19.
Apply:
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.90.1", - "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0", "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.3.6"packages/svelte-query-devtools/package.json (1)
45-46: LGTM: deps/devDeps bumps are consistent with Svelte 5.39.5.Peer range already allows Svelte 3/4/5; no action needed.
examples/svelte/playground/package.json (1)
16-19: SvelteKit/Svelte patch bumps look goodNo breaking manifest changes detected.
Please confirm CI uses a Node version compatible with Vite 6/SvelteKit (Node >=18; Node 20+ recommended).
examples/svelte/auto-refetching/package.json (1)
16-19: SvelteKit/Svelte patch bumps look goodNo breaking manifest changes detected.
Please confirm CI uses a Node version compatible with Vite 6/SvelteKit (Node >=18; Node 20+ recommended).
examples/svelte/basic/package.json (1)
18-21: SvelteKit/Svelte patch bumps look goodMatches the other Svelte examples; no regressions expected.
Please confirm CI uses a Node version compatible with Vite 6/SvelteKit (Node >=18; Node 20+ recommended).
examples/angular/simple/package.json (1)
12-26: TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to >=5.9 <6.0Angular 20.3.x requires TS >=5.9,<6.0. Current pin (5.8.3) will cause install/build failures.
Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/router/package.json (1)
12-26: TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to >=5.9 <6.0With Angular bumped to 20.3.x, TS 5.8.3 no longer satisfies the peer range.
Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/pagination/package.json (1)
12-26: TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to >=5.9 <6.0The Angular upgrades necessitate moving TypeScript to 5.9.x to match official support.
Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/infinite-query-with-max-pages/package.json (1)
12-26: TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to >=5.9 <6.0Align TypeScript with Angular 20.3.x requirements to avoid build/install errors.
Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
55e0429 to
34ab05a
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (48)
- examples/solid/simple/package.json
- examples/vue/nuxt3/package.json
- packages/solid-query-persist-client/package.json
- examples/vue/persister/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/optimistic-updates/package.json
- examples/solid/basic/package.json
- packages/query-devtools/package.json
- packages/vue-query/package.json
- integrations/solid-vite/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/basic-graphql-request/package.json
- packages/solid-query/package.json
- packages/query-test-utils/package.json
- integrations/react-vite/package.json
- examples/vue/basic/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/angular/basic/package.json
- packages/svelte-query/package.json
- examples/angular/simple/package.json
- packages/vue-query-devtools/package.json
- packages/solid-query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/simple/package.json
- examples/react/playground/package.json
- packages/react-query/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/chat/package.json
- examples/angular/basic-persister/package.json
- packages/react-query-persist-client/package.json
- examples/react/rick-morty/package.json
- examples/vue/dependent-queries/package.json
- integrations/svelte-vite/package.json
- examples/svelte/basic/package.json
- examples/solid/default-query-function/package.json
- examples/react/shadow-dom/package.json
- packages/react-query-next-experimental/package.json
- packages/eslint-plugin-query/package.json
- examples/react/offline/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/react-webpack-5/package.json
- integrations/angular-cli-20/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/ssr/package.json
- packages/angular-query-experimental/package.json
- examples/react/star-wars/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/query-async-storage-persister/package.jsonpackages/query-persist-client-core/package.jsonintegrations/react-next-15/package.jsonpackages/svelte-query-devtools/package.jsonpackages/angular-query-persist-client/package.jsonpackages/react-query-devtools/package.jsonexamples/solid/astro/package.jsonexamples/react/basic-graphql-request/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (27)
examples/react/default-query-function/package.json (1)
17-17: Node engines check for @vitejs/plugin-react v4.7.0.Same note as earlier: make sure CI/local Node ≥20.19 to satisfy plugin-react 4.7’s requirement.
integrations/react-next-15/package.json (1)
9-9: Temporal polyfill bump: confirm no double‑polyfill and SSR/Edge behavior.If using the polyfill globally, ensure it’s initialized once and doesn’t leak into Edge/runtime-specific bundles. Sanity-check SSR and any Edge routes after the bump.
examples/solid/astro/package.json (1)
15-22: Astro/Solid/Vercel adapter bumps look good; confirm Node/CI compatibility.Astro 5 + @astrojs/vercel 8.x typically expect Node ≥18. Verify CI/runtime images and run a quick build to ensure adapter changes don’t affect deployment config.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump.No script changes needed; this is a safe tooling update.
examples/react/basic/package.json (1)
23-23: Ensure Node ≥20.19 for @vitejs/plugin-react 4.7.0.Align engines/CI images accordingly; Vite 6 pairing is okay.
examples/vue/simple/package.json (1)
16-16: LGTM: @vitejs/plugin-vue to ^5.2.4 with Vite 6.3.Previous build issues were addressed; this bump is consistent with the repo-wide updates.
integrations/vue-vite/package.json (1)
13-13: LGTM; run a quick build/typecheck with Vite 6 + plugin-vue 5.2.4.You already have vue-tsc; just verify the build still resolves @tanstack/vue-query properly.
examples/react/algolia/package.json (1)
21-21: Align React type definitions with the React 19 runtime.This example runs on React 19 but still pulls in the React 18 type packages, which leads to stale JSX/ReactNode typings. Please bump the types to the matching major.
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",examples/react/eslint-legacy/package.json (1)
23-23: Update @types/react to the React 19 series.*React/ReactDOM are already on ^19.0.0 but the corresponding
@types/*remain on the 18.x line, which breaks parity and can surface bad typings. Please bump them to the latest 19.x release in this file.- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",examples/react/react-router/package.json (1)
26-26: Bring the React type packages up to React 19.After the dependency bumps, this example still ships
@types/react/@types/react-dom18.x while running React 19. Please align the type packages to the same major to avoid mismatched JSX typings.- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",examples/svelte/star-wars/package.json (1)
16-23: Svelte devDependency bumps look good.Kit/svelte/svelte-check/tailwind updates are safe and consistent with the rest of the repo.
packages/react-query-devtools/package.json (1)
86-90: Dev tooling bumps LGTM.@testing-library/react, @vitejs/plugin-react, and npm-run-all2 updates are aligned with the monorepo.
packages/svelte-query-devtools/package.json (1)
45-54: Svelte toolchain bumps LGTM.esm-env, @sveltejs/package, eslint-plugin-svelte, svelte, and svelte-check updates are consistent and safe.
examples/angular/router/package.json (1)
12-26: TypeScript 5.8.3 is incompatible with Angular 20.3.x — see prior comment.This has already been flagged; bump TS to >=5.9 <6.0 for Angular 20.3.x.
packages/angular-query-persist-client/package.json (1)
60-71: Angular 20.3 devDeps bump looks good; ensure workspace TypeScript meets Angular’s range.Already noted earlier: Angular 20.3.x requires TS >=5.9 <6.0. Ensure the workspace/root TS satisfies this for builds/tests.
examples/svelte/auto-refetching/package.json (1)
16-19: Svelte kit/svelte/svelte-check bumps LGTM.Consistent with other Svelte examples; no issues expected.
examples/svelte/playground/package.json (1)
16-19: Svelte example devDependency updates LGTM.Matches the repo-wide Svelte baseline.
packages/query-core/package.json (1)
61-64: Verify npm-run-all2 binary mapping
Ensure thenpm-run-all2package actually provides annpm-run-allexecutable in CI; if it doesn’t, update your scripts to callnpm-run-all2(or switch torun-s/run-p).examples/react/devtools-panel/package.json (1)
17-17: LGTM on @vitejs/plugin-react bump.Matches Vite 6 usage; no concerns.
examples/react/react-native/package.json (1)
19-29: Expo 52 is incompatible with React Native 0.81.x — align versions.Pick one:
- Option A (stay on Expo 52): downgrade RN stack to SDK 52’s supported set.
- Option B (preferred): upgrade Expo to SDK 54 to support RN 0.81.x (and RN Web 0.21.x).
Example diffs:
Option A:
"dependencies": { - "expo": "^52.0.47", + "expo": "^52.0.47", - "react-native": "^0.81.4", - "react-native-gesture-handler": "^2.28.0", - "react-native-reanimated": "^3.19.1", - "react-native-safe-area-context": "^4.14.1", - "react-native-screens": "^4.16.0", - "react-native-web": "^0.21.1" + "react-native": "~0.77.1", + "react-native-gesture-handler": "~2.22.0", + "react-native-reanimated": "~3.16.7", + "react-native-safe-area-context": "~5.1.0", + "react-native-screens": "~4.8.0", + "react-native-web": "~0.19.13" }Option B:
"dependencies": { - "expo": "^52.0.47", + "expo": "^54.0.0" }, "devDependencies": { - "@expo/config": "^10.0.11", + "@expo/config": "^10.0.11" }Note: Verify React 19 compatibility with the chosen RN/Expo combo.
Does Expo SDK 54 officially support React Native 0.81.x and react-native-web ~0.21.x? Which React version is supported with RN 0.81?Also applies to: 32-33
examples/angular/auto-refetching/package.json (1)
12-15: Angular 20.3.x requires TypeScript ≥5.9 <6.0 — update TS.Current "typescript": "5.8.3" is unsupported. Please bump:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Also applies to: 22-24
examples/angular/pagination/package.json (1)
12-15: Update TypeScript to meet Angular 20.3.x requirements (≥5.9 <6.0).Please bump TS:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Also applies to: 22-24
examples/angular/rxjs/package.json (1)
12-16: TypeScript 5.8.3 is incompatible with Angular 20.3.x — bump TS.Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Also applies to: 23-25
examples/react/basic-graphql-request/package.json (1)
13-14: LGTM: [email protected] with [email protected] and Vite React plugin bump
- [email protected] peers accept graphql 14–16; ^16.11.0 is compatible.
- @vitejs/plugin-react^4.7.0 aligns with Vite 6 across the repo.
Also applies to: 19-19
packages/query-persist-client-core/package.json (1)
66-66: npm-run-all2 bump mirrors other packages; same CLI alias check appliesSame note as query-sync-storage-persister: ensure "npm-run-all" binary is present in [email protected].
#!/bin/bash set -euo pipefail curl -s https://registry.npmjs.org/npm-run-all2/5.0.2 | jq '.bin'packages/query-sync-storage-persister/package.json (1)
67-67: npm-run-all2 provides “npm-run-all” binary [email protected]’sbinfield includes"npm-run-all", so existing scripts remain unaffected.examples/react/suspense/package.json (1)
19-19: Confirm compatibility and align Node version
Verified @vitejs/[email protected] supports Vite 6.x (peerDependencies include “^6.0.0”) and Vite 6.3.6 requires Node ^18.0.0 || ^20.0.0 || >=22.0.0; ensure CI/dev environments use one of these Node versions.
| }, | ||
| "devDependencies": { | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
🧩 Analysis chain
Verify Node runtime meets @vitejs/plugin-react v4.7.0 requirements (>=20.19).
Vite 6 is fine, but plugin-react 4.7 raised its Node floor. Ensure engines and CI images use Node ≥20.19 (or ≥22.12).
🌐 Web query:
What Node.js versions are required by Vite 6.3 and @vitejs/plugin-react v4.7.0?
💡 Result:
-
Vite 6.3: supports Node.js 18, 20, and 22+ (i.e., Node 18.x, 20.x, or 22.12+). [1]
-
@vitejs/plugin-react v4.7.0: requires Node.js 20.19+ or 22.12+. [2]
Sources:
[1] Vite 6 announcement / docs (Node.js support).
[2] @vitejs/plugin-react release notes / changelog.
🏁 Script executed:
#!/bin/bash
echo "=== examples/react/simple/package.json (first 200 lines) ==="
sed -n '1,200p' examples/react/simple/package.json || echo "File not found"
echo
echo "=== GitHub Actions workflows (setup-node & node-version) ==="
rg -n "uses:.*setup-node" -g ".github/workflows/*" || echo "no setup-node actions found"
rg -n "node-version" -g ".github/workflows/*" || echo "no node-version specs found"
echo
echo "=== .nvmrc presence ==="
fd .nvmrc || echo "no .nvmrc file found"Length of output: 968
Enforce Node.js ≥20.19 in package.json engines and CI
Add "engines": { "node": ">=20.19" } to examples/react/simple/package.json and ensure any CI workflows or Docker images use Node.js 20.19+ (or 22.12+).
🤖 Prompt for AI Agents
In examples/react/simple/package.json around line 17, the project lacks an
engines field enforcing Node.js >=20.19; add an "engines": { "node": ">=20.19" }
entry to package.json and update any related CI workflows and Dockerfiles used
by this example to use Node.js 20.19+ (or 22.12+) — i.e., change Node versions
in workflow job definitions (setup-node or actions/checkout runners) and base
images to a Node 20.19+ (or 22.12+) tag so the example and CI run on the
required runtime.
| "url": "https://github.com/TanStack/query.git" | ||
| }, | ||
| "packageManager": "[email protected].0", | ||
| "packageManager": "[email protected].1", |
There was a problem hiding this comment.
Fix pnpm ↔ Node mismatch before release.
pnpm 10.17.1 still only supports Node 18/20/22, but the repo is pinned to Node 24.8.0 via .nvmrc, so installs hit Unsupported engine. Please either move the Node pin back to a supported LTS (and mirror it in CI) or jump to a pnpm version that officially supports Node 24 so contributors aren’t blocked.
🤖 Prompt for AI Agents
In package.json around line 8, the pinned pnpm version ([email protected]) is
incompatible with the repo's .nvmrc Node 24.8.0 and causes "Unsupported engine"
errors; fix by either updating package.json to a pnpm release that officially
supports Node 24 (bump packageManager to that pnpm version after verifying
compatibility) or revert .nvmrc/CI Node pin to a supported LTS (e.g., 22.x) and
ensure CI/node matrix reflects that change so local installs and CI no longer
fail.
34ab05a to
28f8678
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
examples/react/basic/package.json (1)
20-25: Sync React type packages with runtimeThe example now runs on React 19, but we’re still pulling in the React 18 type definitions. Updating them keeps JSX and concurrent features typed correctly.
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.1",examples/react/algolia/package.json (1)
17-22: Update React types to match runtimeSame mismatch here: runtime is React 19 while the types are still on the 18 line. Align them to avoid stale definitions.
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.1",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-core/package.json
🚧 Files skipped from review as they are similar to previous changes (49)
- examples/vue/persister/package.json
- integrations/vue-vite/package.json
- packages/svelte-query-persist-client/package.json
- packages/solid-query-persist-client/package.json
- packages/svelte-query/package.json
- packages/react-query-persist-client/package.json
- examples/solid/simple/package.json
- examples/react/default-query-function/package.json
- examples/svelte/playground/package.json
- examples/angular/router/package.json
- examples/svelte/optimistic-updates/package.json
- examples/vue/nuxt3/package.json
- examples/react/chat/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/solid-query/package.json
- examples/react/react-native/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/optimistic-updates/package.json
- integrations/svelte-vite/package.json
- examples/svelte/basic/package.json
- examples/svelte/ssr/package.json
- packages/solid-query-devtools/package.json
- examples/svelte/simple/package.json
- examples/react/rick-morty/package.json
- packages/query-devtools/package.json
- integrations/react-webpack-5/package.json
- examples/react/devtools-panel/package.json
- packages/vue-query-devtools/package.json
- examples/vue/simple/package.json
- packages/eslint-plugin-query/package.json
- examples/vue/dependent-queries/package.json
- packages/query-test-utils/package.json
- packages/query-sync-storage-persister/package.json
- integrations/react-next-15/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-persist-client-core/package.json
- packages/angular-query-experimental/package.json
- examples/react/offline/package.json
- examples/react/shadow-dom/package.json
- integrations/solid-vite/package.json
- examples/solid/default-query-function/package.json
- examples/react/eslint-legacy/package.json
- examples/react/suspense/package.json
- examples/react/react-router/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/star-wars/package.json
- package.json
- examples/react/star-wars/package.json
- examples/angular/infinite-query-with-max-pages/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/svelte-query-devtools/package.jsonexamples/angular/basic-persister/package.jsonexamples/solid/basic/package.jsonpackages/react-query/package.jsonintegrations/react-vite/package.jsonpackages/query-async-storage-persister/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/react-query-next-experimental/package.jsonpackages/vue-query/package.jsonpackages/react-query-devtools/package.jsonpackages/angular-query-persist-client/package.jsonexamples/solid/solid-start-streaming/package.jsonexamples/solid/astro/package.jsonexamples/react/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (23)
packages/svelte-query-devtools/package.json (1)
45-54: Dependency bump looks good
esm-env, Svelte, and linting tool bumps stay within supported ranges and align with the broader workspace updates. No further action needed.packages/vue-query/package.json (2)
73-73: eslint-plugin-vue bump looks goodPatch-level update stays within the supported range; lint config shouldn’t need tweaks. 👍
66-66: Reiterating: move@vue/devtools-apiout of runtime depsStill shipping the devtools API as a production dependency forces every consumer to install (and risk bundling) tooling that should stay dev-only. Please shift it into
devDependencies(or mark it optional) and lazy-load the integration so prod builds stay lean."dependencies": { "@tanstack/match-sorter-utils": "^8.19.4", "@tanstack/query-core": "workspace:*", - "@vue/devtools-api": "^6.6.4", "vue-demi": "^0.14.10" }, "devDependencies": { + "@vue/devtools-api": "^6.6.4", "@tanstack/query-test-utils": "workspace:*", "@vitejs/plugin-vue": "^5.2.4", "@vue/composition-api": "1.7.2", "eslint-plugin-vue": "^9.33.0", "vue": "^3.4.27", "vue2": "npm:[email protected]", "vue2.7": "npm:[email protected]" }integrations/react-webpack-4/package.json (1)
14-21: Babel/webpack toolchain bump looks goodUpgrading the Babel stack and adding
webpack-cli@^4.10.0keeps the webpack‑4 example in a supported configuration, so this set of version bumps looks solid.examples/react/simple/package.json (1)
17-20: Block on Node runtime requirement for @vitejs/plugin-react v4.7.0@vitejs/plugin-react 4.7.0 bumped its engine floor to Node ≥ 20.19 (or ≥ 22.12). This package (and the repo at large) still lacks an engines gate or CI/runtime bump, so anyone running the examples under the current Node 18 baseline will now hit an install failure (
pnpmis engine-strict by default). Please either raise the enforced Node version (root package.json, workflows, Dockerfiles, etc.) to meet the new requirement or hold this plugin upgrade until the runtime is updated. The earlier review comment already called this out; it’s still unresolved.Recommended patch for this package.json once the broader runtime is upgraded:
"dependencies": { "@tanstack/react-query": "^5.90.2", "@tanstack/react-query-devtools": "^5.90.2", "react": "^19.0.0", "react-dom": "^19.0.0" }, "devDependencies": { "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.3.6" - } + }, + "engines": { + "node": ">=20.19" + } }Be sure to mirror the Node bump everywhere else before merging.
packages/react-query-devtools/package.json (1)
86-90: Devtools dependency bumps look good.The minor+patch upgrades for
@testing-library/react,@vitejs/plugin-react, andnpm-run-all2align with the rest of the workspace, and their release notes don’t introduce breaking changes for the current toolchain. Nothing else needed here.packages/react-query/package.json (1)
73-80: Core package dependency bumps LGTM.The synchronized updates to the testing libraries, Vite plugin, and
npm-run-all2stay within compatible version ranges and match the broader Renovate sweep, so no concerns from my side.packages/angular-query-persist-client/package.json (1)
60-70: Angular 20.3.2 requires TypeScript ≥5.9—align the test/deps before merging.
Upgrading these devDependencies to 20.3.2 while our scripts still invoke TypeScript 5.0–5.7 (test:types:ts50…ts57) puts the package into an unsupported combo; Angular’s 20.x compatibility matrix lists TS ≥5.9 only, so those builds will fail. Please bump the workspace TypeScript toolchain (and the per-version test runners) to the supported range—or keep Angular pinned to a release that still works with TS ≤5.7.integrations/angular-cli-20/package.json (1)
23-27: Fix TypeScript version to satisfy Angular CLI/compiler peers.Line 27 still pins
typescriptto~5.8.2, which is below the supported window advertised by@angular/[email protected](>=5.9.0 <6.0.0). This causes installation/build failures. Please bump it."@angular/build": "^20.3.3", "@angular/cli": "^20.3.3", "@angular/compiler-cli": "^20.3.2", - "typescript": "~5.8.2" + "typescript": "^5.9.3"examples/angular/basic-persister/package.json (1)
23-27: Update TypeScript to the minimum Angular 20.3 requirement.Line 27 still locks
typescriptat 5.8.3. Angular 20.3.x packages (compiler-cli/build/cli) requiretypescript >=5.9.0 <6.0.0; using 5.8.3 breaks installs/builds. Please bump accordingly."@angular/build": "^20.3.3", "@angular/cli": "^20.3.3", "@angular/compiler-cli": "^20.3.2", - "typescript": "5.8.3" + "typescript": "^5.9.3"examples/angular/rxjs/package.json (1)
22-26: Update TypeScript to the Angular 20.3 peer-supported range.Line 26 keeps
typescriptat 5.8.3, but Angular 20.3.x tooling requirestypescript >=5.9.0 <6.0.0. This mismatch will surface as peer dependency/build errors. Please upgrade."@angular/build": "^20.3.3", "@angular/cli": "^20.3.3", "@angular/compiler-cli": "^20.3.2", - "typescript": "5.8.3" + "typescript": "^5.9.3"examples/angular/pagination/package.json (1)
21-25: Upgrade TypeScript to meet Angular’s stated peer range.Line 25 still pins
typescriptto 5.8.3. Angular 20.3.x tooling requirestypescript >=5.9.0 <6.0.0, so this version will fail peer checks/builds. Please bump it."@angular/build": "^20.3.3", "@angular/cli": "^20.3.3", "@angular/compiler-cli": "^20.3.2", - "typescript": "5.8.3" + "typescript": "^5.9.3"examples/angular/simple/package.json (1)
21-25: Bring TypeScript up to Angular 20.3.x’s minimum.Line 25 still references
typescript5.8.3, yet Angular 20.3.x tooling expects>=5.9.0 <6.0.0. Leaving it as-is triggers compatibility errors. Please bump it."@angular/build": "^20.3.3", "@angular/cli": "^20.3.3", "@angular/compiler-cli": "^20.3.2", - "typescript": "5.8.3" + "typescript": "^5.9.3"integrations/react-vite/package.json (1)
11-14: Plugin bump looks good
@vitejs/plugin-react4.7.x lines up with our current Vite 6 toolchain, so this upgrade is safe.packages/query-async-storage-persister/package.json (1)
65-68: Patch bump acknowledged
npm-run-all25.0.2 is a bugfix release; no action needed.examples/react/playground/package.json (1)
17-20: Plugin bump looks goodNothing else in this example depends on that plugin at runtime, so the devDependency upgrade is low risk.
packages/react-query-next-experimental/package.json (1)
61-64: Tooling upgrades look consistentBoth the plugin-react and npm-run-all2 bumps stay within their existing peer/version ranges.
examples/react/basic-graphql-request/package.json (1)
11-20: Dependency bumps look compatible
[email protected]still peers against GraphQL 16, and the Vite plugin upgrade matches the rest of the workspace.examples/solid/astro/package.json (1)
15-22: Solid/Astro bumps look consistent.Minor upgrades for
@astrojs/solid-js,@astrojs/vercel,solid-js, andtailwindcssstay within supported ranges for the Astro example, so no action needed.examples/solid/basic/package.json (1)
13-18: Solid/Vite plugin patch aligns with the rest of the workspace.Patch bumps for
solid-jsandvite-plugin-solidmatch the other Solid examples and stay compatible with Vite 6—looks good.examples/solid/solid-start-streaming/package.json (1)
12-19: Add@tanstack/query-coredependency to fix the vinxi build.We’ve hit this before (see earlier guidance):
@tanstack/solid-query’s compiled output imports@tanstack/query-core. With pnpm’s strict node_modules layout the example must declare that dependency itself, otherwisevinxi buildfails with “failed to resolve import '@tanstack/query-core'”. Please add the workspace dependency here (or otherwise ensure it’s resolvable) so the streaming example builds again.Apply this diff to declare the missing dependency:
"dependencies": { "@solidjs/meta": "^0.29.4", "@solidjs/router": "^0.15.3", "@solidjs/start": "^1.2.0", "@tanstack/solid-query": "^5.90.3", "@tanstack/solid-query-devtools": "^5.90.3", + "@tanstack/query-core": "workspace:*", "solid-js": "^1.9.9", "vinxi": "^0.5.8" },examples/solid/basic-graphql-request/package.json (1)
13-21: Install and build the Solid GraphQL example
Run in the example folder:pnpm -C examples/solid/basic-graphql-request install pnpm -C examples/solid/basic-graphql-request buildto confirm the bumped dependencies resolve and bundle correctly.
examples/vue/basic/package.json (1)
16-18: Fix @tanstack/vue-query entry resolution in Vue basic example
Build fails with “Failed to resolve entry for package "@tanstack/vue-query"”; update the example’s package.json exports or import paths so the build passes.
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.3.3", | ||
| "@angular/cli": "^20.3.3", | ||
| "@angular/compiler-cli": "^20.3.2", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
Align TypeScript with Angular 20.3.x compatibility.
Line 25 keeps typescript at 5.8.3, which falls below the @angular/[email protected] peer range (>=5.9.0 <6.0.0). This mismatch causes the Angular toolchain to abort. Please raise the version.
"@angular/build": "^20.3.3",
"@angular/cli": "^20.3.3",
"@angular/compiler-cli": "^20.3.2",
- "typescript": "5.8.3"
+ "typescript": "^5.9.3"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "devDependencies": { | |
| "@angular/build": "^20.0.0", | |
| "@angular/cli": "^20.0.0", | |
| "@angular/compiler-cli": "^20.0.0", | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "5.8.3" | |
| "devDependencies": { | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "^5.9.3" |
🤖 Prompt for AI Agents
In examples/angular/basic/package.json around lines 21 to 25 the TypeScript
devDependency is pinned to 5.8.3 which is below the @angular/[email protected]
peer requirement (>=5.9.0 <6.0.0); update the TypeScript version to a 5.9.x
release (or any >=5.9.0 <6.0.0), then reinstall/update lockfile (npm/yarn/pnpm)
and run the Angular build/tests to verify the toolchain no longer aborts.
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.3.3", | ||
| "@angular/cli": "^20.3.3", | ||
| "@angular/compiler-cli": "^20.3.2", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
Raise TypeScript to the Angular 20.3-supported band.
Line 26 leaves typescript at 5.8.3, which is outside the @angular/[email protected] peer requirement (>=5.9.0 <6.0.0). This breaks ng commands. Please upgrade.
"@angular/build": "^20.3.3",
"@angular/cli": "^20.3.3",
"@angular/compiler-cli": "^20.3.2",
- "typescript": "5.8.3"
+ "typescript": "^5.9.3"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "devDependencies": { | |
| "@angular/build": "^20.0.0", | |
| "@angular/cli": "^20.0.0", | |
| "@angular/compiler-cli": "^20.0.0", | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "5.8.3" | |
| "devDependencies": { | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "^5.9.3" |
🤖 Prompt for AI Agents
In examples/angular/devtools-panel/package.json around lines 22 to 26, the
devDependency "typescript" is pinned to 5.8.3 which is incompatible with
@angular/[email protected] (requires >=5.9.0 <6.0.0); update the typescript
version to a 5.9.x or later 5.x release (e.g. ^5.9.0) in devDependencies and
then reinstall/update lockfile (npm install or yarn install) so ng commands no
longer fail due to the peer version mismatch.
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.3.3", | ||
| "@angular/cli": "^20.3.3", | ||
| "@angular/compiler-cli": "^20.3.2", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
Bump TypeScript to satisfy Angular 20.3.2 peer range.
Line 26 still pins typescript to 5.8.3, but @angular/[email protected] declares a peer dependency of typescript >=5.9.0 <6.0.0. Keeping 5.8.3 causes the CLI/build to error out. Please lift the version into the supported window.
"@angular/build": "^20.3.3",
"@angular/cli": "^20.3.3",
"@angular/compiler-cli": "^20.3.2",
- "typescript": "5.8.3"
+ "typescript": "^5.9.3"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "devDependencies": { | |
| "@angular/build": "^20.0.0", | |
| "@angular/cli": "^20.0.0", | |
| "@angular/compiler-cli": "^20.0.0", | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "5.8.3" | |
| "devDependencies": { | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "^5.9.3" |
🤖 Prompt for AI Agents
In examples/angular/query-options-from-a-service/package.json around lines 22 to
26, the devDependency pins "typescript" to 5.8.3 which is below
@angular/[email protected]'s peer requirement (>=5.9.0 <6.0.0); update the
"typescript" entry to a version in that range (for example "^5.9.0") so it
satisfies the peer dependency, then run install (npm/yarn) and verify the
project builds.
28f8678 to
f0d3df8
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/solid-query-persist-client/package.json (1)
79-81: Align Solid peer range with dev version for consistencyPeers currently allow ^1.6.0. Consider bumping to match dev (^1.9.x) and plugin minimum (>=1.7.2). Not a blocker, but reduces ambiguity.
Apply:
- "solid-js": "^1.6.0" + "solid-js": "^1.9.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/vue/basic/package.json
🚧 Files skipped from review as they are similar to previous changes (51)
- packages/query-sync-storage-persister/package.json
- examples/react/eslint-legacy/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/angular/pagination/package.json
- examples/react/suspense/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/rxjs/package.json
- integrations/svelte-vite/package.json
- examples/react/shadow-dom/package.json
- examples/angular/optimistic-updates/package.json
- integrations/react-vite/package.json
- examples/react/star-wars/package.json
- packages/solid-query/package.json
- package.json
- integrations/react-webpack-5/package.json
- packages/query-test-utils/package.json
- integrations/solid-vite/package.json
- integrations/angular-cli-20/package.json
- examples/svelte/simple/package.json
- examples/react/algolia/package.json
- examples/vue/persister/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query-persist-client/package.json
- examples/react/offline/package.json
- packages/query-core/package.json
- examples/angular/basic-persister/package.json
- packages/vue-query-devtools/package.json
- packages/query-async-storage-persister/package.json
- examples/react/simple/package.json
- examples/svelte/basic/package.json
- examples/angular/simple/package.json
- examples/solid/default-query-function/package.json
- packages/angular-query-experimental/package.json
- examples/react/basic/package.json
- examples/svelte/ssr/package.json
- examples/react/react-router/package.json
- integrations/vue-vite/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/react-native/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/router/package.json
- integrations/react-webpack-4/package.json
- examples/solid/simple/package.json
- examples/angular/basic/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/devtools-panel/package.json
- packages/solid-query-devtools/package.json
- packages/react-query/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/star-wars/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/react-query-next-experimental/package.jsonpackages/react-query-devtools/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/vue-query/package.jsonintegrations/react-next-15/package.jsonpackages/solid-query-persist-client/package.jsonexamples/solid/basic/package.jsonpackages/svelte-query/package.jsonpackages/query-persist-client-core/package.jsonexamples/solid/astro/package.jsonpackages/svelte-query-devtools/package.json
🔇 Additional comments (24)
packages/eslint-plugin-query/package.json (1)
62-70: Version alignment looks goodKeeping all
@typescript-eslint/*packages on the same patch and refreshingnpm-run-all2together helps avoid tooling skew. No issues spotted.examples/angular/query-options-from-a-service/package.json (1)
26-26: Upgrade TypeScript to satisfy Angular’s peer requirement.
@angular/[email protected]demandstypescript >=5.9.0 <6.0.0; keeping 5.8.3 will break ng builds. Please bump TS into the supported range.- "typescript": "5.8.3" + "typescript": "^5.9.3"examples/vue/simple/package.json (1)
16-18: Patch aligning Vue plugin looks goodThanks for keeping this example in lockstep with the other Vue workspaces; the patch upgrade matches the repo-wide tooling baseline.
examples/vue/dependent-queries/package.json (1)
15-18: Patch aligning Vue plugin looks goodSame as the simple example: this patch-level bump keeps the Vue examples consistent with the shared toolchain.
examples/svelte/auto-refetching/package.json (1)
16-19: LGTM on the Svelte stack bumps.All three devDependencies stay in lockstep and follow their patch/minor releases, so no action needed.
examples/svelte/playground/package.json (1)
16-19: Patch upgrades look good.The SvelteKit + Svelte + svelte-check versions remain aligned; nothing else to do here.
examples/svelte/optimistic-updates/package.json (1)
16-19: Aligned patch bumps confirmed.Versions match the rest of the Svelte examples, so this update is safe as-is.
packages/svelte-query/package.json (1)
50-56: Svelte tooling bumps look correctAll upgraded toolchain versions stay within their existing compatibility ranges and keep peer dependency alignment with Svelte 3/4/5, so this patch set is safe to land.
packages/svelte-query-persist-client/package.json (1)
50-57: Dev toolchain versions remain in lockstepThe synchronized bumps for
@sveltejs/package,eslint-plugin-svelte,svelte, andsvelte-checkkeep this package aligned with the rest of the workspace with no peer dependency drift.packages/svelte-query-devtools/package.json (1)
45-53: Runtime + tooling patches look good
esm-envmoves to the latest patch while the Svelte tooling deps stay coordinated with the other packages—no compatibility concerns spotted.examples/angular/devtools-panel/package.json (1)
23-26: Upgrade TypeScript to the Angular 20.3-compatible range.
@angular/[email protected]requirestypescript >=5.9.0 <6.0.0, so leaving Line 26 at 5.8.3 breaksngcommands in this example."@angular/compiler-cli": "^20.3.2", - "typescript": "5.8.3" + "typescript": "^5.9.3"integrations/react-next-15/package.json (1)
9-9: LGTM on the Temporal polyfill bumpThe dependency update looks good—no compatibility concerns spotted for the React Next 15 example.
packages/vue-query/package.json (1)
63-68: Move@vue/devtools-apiout of runtime dependenciesThis patch bump still keeps
@vue/devtools-apiin"dependencies", so every consumer installing@tanstack/vue-querycontinues to pull in the devtools bundle in production. Please shift it into"devDependencies"(or gate it behind an optional/dev-only entry) so we stop shipping devtool-only code to downstream apps."dependencies": { "@tanstack/match-sorter-utils": "^8.19.4", "@tanstack/query-core": "workspace:*", - "@vue/devtools-api": "^6.6.4", "vue-demi": "^0.14.10" }, "devDependencies": { + "@vue/devtools-api": "^6.6.4", "@tanstack/query-test-utils": "workspace:*",examples/vue/nuxt3/package.json (1)
9-14: Add Nuxt 3.19’s stricter Node engine requirement.Nuxt 3.19.2 declares
engines.node: "^20.19.0 || >=22.12.0". Without mirroring this in the example’s package.json, anyone still on Node 18 will install this bump and immediately hit runtime/tooling failures. Please gate the example with the matching engine range."devDependencies": { - "nuxt": "^3.19.2" - } + "nuxt": "^3.19.2" + }, + "engines": { + "node": "^20.19.0 || >=22.12.0" + } }examples/solid/astro/package.json (1)
15-22: Astro/Solid/Tailwind bumps look consistent.The version bumps stay within supported ranges for the Astro + Solid stack and align with the other Solid examples. Looks good.
examples/solid/basic/package.json (1)
13-19: Verify Solid basic example build
Automated build failed (vite/nxnot found). From the repo root run:cd examples/solid/basic pnpm install pnpm run buildConfirm
[email protected]and[email protected]build without regressions.packages/query-devtools/package.json (1)
67-81: LGTM on dev dependency refreshVersions are coherent with Solid 1.9.9 and vite-plugin-solid 2.11.8. No further action from my side.
packages/solid-query-persist-client/package.json (1)
73-77: All peer dependencies are satisfied
[email protected]’s requirements on solid-js (≥1.7.2) and Vite are met: this package uses solid-js ^1.9.9 and the workspace root pins Vite at ^6.3.6 consistently.packages/react-query-devtools/package.json (1)
86-91: @testing-library/[email protected] supports React 19 – peerDependencies list React ^18.0.0 || ^19.0.0; no other @testing-library/* deps in this package.packages/react-query-next-experimental/package.json (1)
61-64: Bumps look good; @vitejs/plugin-react v4.7.0 declares no peerDependencies, so no peer warnings with Vite v6 across the workspaceexamples/react/rick-morty/package.json (2)
11-14: Deprecated @mui/styles present; migrate off and remove@mui/styles is deprecated and problematic with modern React. Migrate styles to sx/@mui/system/@emotion and drop @mui/styles.
Follow-up: remove the dependency and replace makeStyles/withStyles usages. Quick scan script:
#!/usr/bin/env bash set -euo pipefail echo "Direct @mui/styles imports:" rg -n -C1 "from ['\"]@mui/styles" examples/react | sed -e 's/^/ - /' echo echo "makeStyles/withStyles occurrences:" rg -n -C1 '\b(makeStyles|withStyles|createStyles|withTheme)\b' examples/react | sed -e 's/^/ - /'
23-23: Remove the>=20.19engines.node requirement; use ≥16.0.0
@vitejs/plugin-react 4.7.0’s own engines are^14.18.0 || >=16.0.0, so enforcing ≥20.19 is unnecessarily restrictive.Likely an incorrect or invalid review comment.
examples/react/playground/package.json (1)
17-17: Incorrect Node engine requirement: @vitejs/[email protected] declares"node": "^14.18.0 || >=16.0.0", so enforcing>=20.19is overly restrictive—align engines.node to>=16.0.0or document why you’re bumping to 20.19.Likely an incorrect or invalid review comment.
examples/react/chat/package.json (1)
17-19: Remove Node >=20.19 engine requirement – @vitejs/[email protected] specifies"node": "^14.18.0 || ≥16.0.0", so enforcing ≥20.19 is overly restrictive.Likely an incorrect or invalid review comment.
| }, | ||
| "devDependencies": { | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
🧩 Analysis chain
Require Node >=20.19 for @vitejs/plugin-react 4.7.0; add engines and align CI
@vitejs/plugin-react 4.7.0 raises the Node requirement; installs/builds will fail on older Nodes. Add an engines constraint and ensure CI/dev images match.
Proposed change:
{
"name": "@tanstack/query-example-react-default-query-function",
"private": true,
"type": "module",
+ "engines": {
+ "node": ">=20.19"
+ },
"scripts": {Quick verification script (repo root):
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Root engines:"; jq -r '.engines // {}' package.json 2>/dev/null || true
echo
echo "Examples with missing/weak engines.node:"
fd -a package.json examples | while read -r f; do
node_req=$(jq -r '.engines.node // ""' "$f")
if [[ -z "$node_req" || "$node_req" =~ ^(>=)?1[0-9] ]]; then
echo "$f -> engines.node: ${node_req:-MISSING}"
fi
done
echo
echo "CI setup-node versions:"
fd -a -g ".github/workflows/*.yml" | xargs rg -n -C1 "setup-node|node-version|matrix\.node"Length of output: 5752
I couldn’t detect any CI node-version settings because hidden workflow files were skipped. Let’s recheck including hidden directories:
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "CI setup-node versions:"
fd -H -t f -g '*.yml' .github/workflows | xargs -r rg -n -C2 -e "setup-node" -e "node-version" -e "matrix.node"Length of output: 23
Enforce Node ≥ 20.19 across packages and CI
- Add
"engines": { "node": ">=20.19" }to the rootpackage.jsonand allexamples/**/package.json(includingexamples/react/default-query-function/package.json). - Update your GitHub Actions workflows in
.github/workflows/*.ymlto useactions/setup-node@v3withnode-version: "20.19".
🤖 Prompt for AI Agents
In examples/react/default-query-function/package.json around line 17, the
package.json is missing the engines field enforcing Node >= 20.19; add an
"engines": { "node": ">=20.19" } entry to this file (and mirror the change in
the root package.json and all examples/**/package.json files) to enforce Node
versioning across packages; additionally update CI workflow files
(.github/workflows/*.yml) to use actions/setup-node@v3 with node-version:
"20.19".
| "npm-run-all2": "^5.0.2" | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
npm-run-all2 v5: ensure Node engine compatibility
v5 typically requires Node 18+. Confirm repo engines align to avoid CI breakages.
Run:
🏁 Script executed:
#!/bin/bash
# Check declared Node engine constraints
echo "Root engines.node:"; jq -r '.engines.node // "none"' package.json 2>/dev/null
echo
echo "Per-package engines.node (non-null):"
fd -t f package.json | while read -r f; do
val=$(jq -r '.engines.node // empty' "$f")
if [ -n "$val" ]; then echo "$f: $val"; fi
doneLength of output: 117
Specify Node >=18 in engines Add "engines": { "node": ">=18" } to the root package.json (and any packages lacking an engines field) to satisfy npm-run-all2 v5 requirements and prevent CI failures.
🤖 Prompt for AI Agents
In packages/query-persist-client-core/package.json around lines 66 to 67, the
package.json is missing a Node engine declaration required by npm-run-all2 v5;
add an "engines" field with "node": ">=18" to the root package.json (and mirror
to any package.json files in the monorepo that lack an engines field). Update
the JSON by inserting an "engines": { "node": ">=18" } object at the top-level,
ensure valid JSON formatting and run package installation/CI locally to verify
no engine mismatches.
f0d3df8 to
091fe75
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/solid/basic/package.json (1)
15-19: Add engines.node ≥18 for Vite 6 parityDeclare Node version like other examples to avoid runtime surprises.
Apply this diff:
"devDependencies": { "typescript": "5.8.3", "vite": "^6.3.6", "vite-plugin-solid": "^2.11.8" - } + }, + "engines": { + "node": ">=18" + }examples/solid/default-query-function/package.json (1)
15-19: Add engines.node ≥18 (Vite 6)Keep engine constraints explicit and consistent.
Apply this diff:
"devDependencies": { "typescript": "5.8.3", "vite": "^6.3.6", "vite-plugin-solid": "^2.11.8" - } + }, + "engines": { + "node": ">=18" + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/react/devtools-panel/package.json
- integrations/react-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (38)
- packages/query-test-utils/package.json
- packages/solid-query/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/auto-refetching/package.json
- integrations/solid-vite/package.json
- examples/solid/astro/package.json
- examples/react/suspense/package.json
- packages/svelte-query-persist-client/package.json
- integrations/svelte-vite/package.json
- examples/react/react-native/package.json
- packages/query-core/package.json
- examples/angular/router/package.json
- examples/react/eslint-legacy/package.json
- package.json
- examples/react/offline/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/optimistic-updates/package.json
- examples/svelte/basic/package.json
- examples/react/chat/package.json
- packages/query-async-storage-persister/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/basic-persister/package.json
- examples/vue/persister/package.json
- examples/react/algolia/package.json
- examples/react/basic/package.json
- packages/angular-query-experimental/package.json
- examples/vue/nuxt3/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/simple/package.json
- examples/react/star-wars/package.json
- examples/react/rick-morty/package.json
- examples/angular/basic/package.json
- examples/angular/pagination/package.json
- examples/react/react-router/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/query-sync-storage-persister/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/rxjs/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/default-query-function/package.jsonpackages/react-query-devtools/package.jsonpackages/solid-query-devtools/package.jsonpackages/svelte-query/package.jsonpackages/solid-query-persist-client/package.jsonpackages/vue-query/package.jsonintegrations/react-next-15/package.jsonexamples/solid/basic/package.jsonpackages/react-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonpackages/angular-query-persist-client/package.jsonpackages/svelte-query-devtools/package.jsonexamples/solid/solid-start-streaming/package.jsonexamples/solid/simple/package.jsonpackages/react-query/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/query-persist-client-core/package.json
🔇 Additional comments (41)
integrations/react-next-15/package.json (1)
9-16: Dependency bump looks goodUpdating
@js-temporal/polyfillto^0.5.1keeps us current within the same compatibility range. No additional action needed.integrations/angular-cli-20/package.json (1)
24-27: Upgrade TypeScript to Angular‑supported rangeAngular 20.3.x requires TypeScript >= 5.9.0 < 6.0.0. Keeping
~5.8.2will breakng build/type‑checking once these Angular bumps land. Please raise the version to an Angular‑supported range.- "typescript": "~5.8.2" + "typescript": "^5.9.0"packages/svelte-query/package.json (1)
50-56: Svelte toolchain bumps look goodPatch/minor lifts for
@sveltejs/package,eslint-plugin-svelte,svelte, andsvelte-checkkeep this package aligned with the rest of the workspace and stay within supported peer ranges. No red flags.packages/query-devtools/package.json (1)
76-80: Solid + vite-plugin-solid versions now align.Thanks for bringing
solid-jsup to ^1.9.9 alongsidevite-plugin-solid^2.11.8—this satisfies the plugin’s peer requirements and keeps the Solid tooling consistent with the rest of the workspace.examples/angular/query-options-from-a-service/package.json (1)
23-26: Upgrade TypeScript to satisfy Angular 20.3 peer range
@angular/[email protected]enforcestypescript >=5.9.0 <6.0.0. Keeping 5.8.3 causes install/build failures. Please lift TypeScript into the supported window.- "typescript": "5.8.3" + "typescript": "^5.9.3"examples/angular/infinite-query-with-max-pages/package.json (1)
25-25: TypeScript 5.8.3 is outside Angular 20.3’s supported rangeAngular 20.3.x officially requires TypeScript ≥5.9.0 <6.0.0; keeping 5.8.3 will trigger peer dependency errors and block the example from building. Please bump
typescriptto a 5.9.x release (e.g., 5.9.2) alongside these Angular upgrades.- "typescript": "5.8.3" + "typescript": "5.9.2"integrations/react-webpack-4/package.json (1)
14-17: Babel dependency bump looks compatible.All upgrades stay within the Babel 7 line, and
[email protected]keeps webpack‑4 support, so this dev tooling refresh should be safe.packages/vue-query-devtools/package.json (1)
56-63: Plugin patch bump looks solid.Staying current with eslint-plugin-vue keeps our lint rules aligned with upstream fixes. No concerns here.
packages/vue-query/package.json (1)
63-77: Vue tooling patches look good.Both the devtools API and eslint plugin bumps stay within their existing major ranges, so consumers shouldn’t see breaking changes.
integrations/vue-vite/package.json (1)
13-13: Patch bump looks safe.@vitejs/plugin-vue 5.2.4 is a patch-level update and remains compatible with the existing Vite 6.3.6 setup here. No further action needed.
examples/vue/simple/package.json (1)
16-16: Plugin bump LGTM.Patch update to @vitejs/plugin-vue aligns with Vite 6.3.6 and doesn’t introduce breaking changes. All good.
examples/vue/basic/package.json (1)
16-16: Looks good.This patch-level upgrade of @vitejs/plugin-vue keeps pace with the rest of the Vue stack and stays compatible with Vite 6.3.6.
examples/vue/dependent-queries/package.json (1)
15-15: LGTM.@vitejs/plugin-vue 5.2.4 is a safe patch bump and fully compatible with the current toolchain.
packages/angular-query-persist-client/package.json (1)
60-64: Angular 20.3.x requires TypeScript ≥5.9—please confirm toolchain bumpThese devDep upgrades pull in Angular 20.3, which officially supports only TS 5.9+. If the workspace (root or package-level) still pins TypeScript 5.8.x, the build/test matrix here will fail. Please verify that the repo has already been bumped to ≥5.9 and that CI uses a compatible Node/TS toolchain.
Run this script to check the declared TypeScript versions across the repo:
#!/bin/bash set -euo pipefail find . -name package.json -not -path "*/node_modules/*" -print0 | \ xargs -0 jq -r 'path(..|objects|select(has("typescript")))|@json + ": " + (getpath(path(..|objects|select(has("typescript"))))|tostring)'examples/react/default-query-function/package.json (1)
17-20: Upgrade to Node ≥20.19 before shipping this plugin bump.
@vitejs/[email protected]hard-requires Node 20.19+ (or 22.12+). If any developer or CI job is still on Node 18/20.18,pnpm installwill now abort because of the engine check. Please align the repo’s Node runtime (engines fields, CI images, dev docs) with the new floor or hold the plugin at 4.6.x until that happens.examples/react/playground/package.json (1)
17-20: Same Node runtime blocker as flagged in the other React examples.This example also picks up
@vitejs/[email protected], so it inherits the Node 20.19+ requirement. Installs/builds on older Nodes will fail; please bump the enforced Node version everywhere before merging.examples/react/shadow-dom/package.json (1)
17-21: Shadow DOM example also needs Node ≥20.19 now.Because this package moves to
@vitejs/[email protected], it cannot be installed on Node <20.19. Ensure the workspace/CI runtime is updated (or pin the plugin lower) before releasing.examples/react/simple/package.json (1)
17-20: Simple React example will break on Node <20.19.Yet another copy of the plugin bump—please update the enforced Node version and CI runners to ≥20.19 (or ≥22.12) so installs don’t fail.
examples/react/basic-graphql-request/package.json (1)
13-20: GraphQL example needs the same Node upgrade before this ships.With
@vitejs/[email protected]now in devDependencies, this package also requires Node 20.19+ (22.12+) to install. Please raise the repo’s Node floor accordingly or defer the plugin bump.examples/svelte/ssr/package.json (1)
16-19: Svelte + Kit patch bumps look goodKit 2.43.5 with Svelte 5.39.6 and svelte-check 4.3.2 keeps the toolchain aligned with current peer requirements; no red flags on the compatibility matrix.
examples/svelte/load-more-infinite-scroll/package.json (1)
16-19: Tooling trio stays in syncThese patch updates mirror the rest of the Svelte examples and remain within supported ranges for Vite 6 + SvelteKit 2. All good.
examples/svelte/star-wars/package.json (1)
16-22: Tailwind & Svelte stack updates look healthyKit/Svelte/svelte-check bumps align with peers, and Tailwind 3.4.17 continues to work with the existing PostCSS/Autoprefixer versions.
examples/svelte/playground/package.json (1)
16-19: Consistent Svelte toolchain versionsPatch upgrades keep this example in lockstep with the others—no compatibility issues spotted.
examples/svelte/simple/package.json (1)
16-18: Dev tooling patches align with ecosystem
@tsconfig/svelte5.0.5 plus the latest Svelte and svelte-check patches maintain parity with the other examples; everything stays within supported ranges.examples/svelte/auto-refetching/package.json (1)
16-19: SvelteKit patch bump approvedLatest Kit/Svelte/svelte-check combo matches the rest of the suite and keeps peer requirements satisfied.
integrations/react-webpack-5/package.json (2)
14-16: Add engines.node and enable preset-react automatic runtime (echoing prior review).Reiterating: babel-loader 9.x requires Node >=14.15.0, and with React 19 it’s safer to opt into the automatic JSX runtime in Babel config.
Apply this diff to enforce the Node minimum in this package.json:
{ "name": "react-webpack-5", "private": true, + "engines": { + "node": ">=14.15.0" + }, "scripts": { "build": "webpack --mode production" },And update integrations/react-webpack-5/webpack.config.js to pass runtime: "automatic" to @babel/preset-react:
- '@babel/preset-react', + ['@babel/preset-react', { runtime: 'automatic' }],Run to verify engines and preset config:
#!/bin/bash set -euo pipefail echo "engines.node in this package:" jq -r '.engines.node // "(missing)"' integrations/react-webpack-5/package.json echo echo "Checking webpack config for preset-react automatic runtime:" fd -a -g 'webpack.config.*' integrations/react-webpack-5 | xargs -I{} sh -c 'echo "=== {} ==="; rg -nP -C2 "@babel/preset-react|runtime\\s*:\\s*[\"\\'']automatic[\"\\'']" "{}" || true'
18-18: LGTM: html-webpack-plugin ^5.6.4 is compatible with webpack 5.packages/solid-query-persist-client/package.json (1)
73-76: Solid toolchain bumps look goodPatch bumps for npm-run-all2, solid-js, and vite-plugin-solid stay within our peer ranges and align with upstream releases.
packages/svelte-query-devtools/package.json (1)
45-54: Svelte devtools dependency refresh LGTMThe updated esm-env, Svelte, and linting/tooling versions remain compatible with our declared peers and unblock the latest fixes.
packages/react-query-devtools/package.json (1)
86-89: React devtools tooling bumps check outThe @testing-library/react, @vitejs/plugin-react, and npm-run-all2 updates are within supported ranges and align with the broader workspace rollup.
packages/solid-query-devtools/package.json (1)
68-71: Solid devtools tooling versions alignedThese patch bumps keep the Solid tooling stack consistent across packages with no peer conflicts.
packages/react-query-persist-client/package.json (1)
67-70: React persist client tooling upgrade looks goodThe @testing-library/react and @vitejs/plugin-react updates match the rest of the React workspace and stay within supported ranges.
packages/react-query/package.json (1)
73-79: Core React package toolchain bump approvedThe testing-library, react-render-stream, and vite plugin upgrades are all safe patch releases and keep parity with dependent packages.
packages/query-persist-client-core/package.json (1)
65-67: Add Node engine ≥18 to workspace root
Rootpackage.jsonhas noengines.nodefield; please add"engines": { "node": ">=18" }to ensure compatibility withnpm-run-all2@^5.0.2.examples/solid/solid-start-streaming/package.json (2)
14-18: LGTM on version bumpsThe SolidStart/vinxi/solid-js bumps are consistent and expected.
11-19: Fix SSR build: add @tanstack/query-core dependency so vinxi can resolve itThe Solid adapter’s built output imports @tanstack/query-core; without declaring it here, Rollup/Vite cannot resolve it during SSR bundling.
Apply this diff:
"dependencies": { "@solidjs/meta": "^0.29.4", "@solidjs/router": "^0.15.3", "@solidjs/start": "^1.2.0", "@tanstack/solid-query": "^5.90.3", "@tanstack/solid-query-devtools": "^5.90.3", + "@tanstack/query-core": "workspace:*", "solid-js": "^1.9.9", "vinxi": "^0.5.8" },If you prefer using the published package instead of the workspace one, use a compatible ^5.x version. Based on learnings
#!/bin/bash set -euo pipefail pnpm -w -F @tanstack/query-example-solid-start-streaming install pnpm -w -F @tanstack/query-example-solid-start-streaming run buildexamples/solid/simple/package.json (3)
13-13: LGTM on dependency bumpssolid-js and vite-plugin-solid bumps align with the rest of the repo.
Also applies to: 19-19
15-20: Add engines.node >=18 (Vite 6 requirement, consistency with other examples)This example lacks an engines field; Vite 6 requires Node ≥18 and other examples already declare it.
Apply this diff:
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.90.1", "typescript": "5.8.3", "vite": "^6.3.6", "vite-plugin-solid": "^2.11.8" - } + }, + "engines": { + "node": ">=18" + }
10-14: Verify @tanstack/solid-query resolves in Vite build
v5.90.3’s package.json exports lack a main entry, so Vite can’t resolve the package; upgrade to a version with correct exports or add a Vite alias mapping@tanstack/solid-queryto its ESM/CJS build (e.g.resolve.alias: { '@tanstack/solid-query': require.resolve('@tanstack/solid-query/build/index.js') }).⛔ Skipped due to learnings
Learnt from: TkDodo PR: TanStack/query#9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.examples/solid/basic/package.json (1)
13-13: LGTM on dependency bumpsMatches the broader Solid/Vite updates in this PR.
Also applies to: 18-18
examples/solid/default-query-function/package.json (1)
13-13: LGTM on dependency bumpsIn line with the other Solid examples.
Also applies to: 18-18
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
2 times, most recently
from
712a8bf to
a5eb092
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/query-test-utils/package.json
- integrations/react-next-15/package.json
- examples/svelte/optimistic-updates/package.json
🚧 Files skipped from review as they are similar to previous changes (43)
- examples/svelte/ssr/package.json
- examples/angular/auto-refetching/package.json
- packages/react-query-devtools/package.json
- packages/eslint-plugin-query/package.json
- examples/svelte/simple/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/solid-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- packages/svelte-query/package.json
- packages/react-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/solid/simple/package.json
- examples/solid/basic/package.json
- examples/vue/dependent-queries/package.json
- examples/react/react-router/package.json
- integrations/vue-vite/package.json
- packages/react-query/package.json
- integrations/react-webpack-5/package.json
- packages/solid-query/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/simple/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-devtools/package.json
- examples/vue/persister/package.json
- examples/solid/default-query-function/package.json
- package.json
- integrations/angular-cli-20/package.json
- packages/vue-query/package.json
- packages/angular-query-persist-client/package.json
- examples/solid/astro/package.json
- integrations/svelte-vite/package.json
- integrations/react-vite/package.json
- examples/vue/nuxt3/package.json
- examples/react/algolia/package.json
- examples/react/shadow-dom/package.json
- examples/react/playground/package.json
- integrations/react-webpack-4/package.json
- examples/react/react-native/package.json
- examples/react/rick-morty/package.json
- packages/query-core/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-broadcast-client-experimental/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/solid/solid-start-streaming/package.jsonpackages/solid-query-devtools/package.jsonintegrations/solid-vite/package.jsonexamples/solid/basic-graphql-request/package.jsonexamples/angular/basic-persister/package.jsonpackages/vue-query-devtools/package.jsonpackages/svelte-query-devtools/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/angular-query-experimental/package.jsonpackages/query-async-storage-persister/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (30)
examples/vue/simple/package.json (1)
16-18: Patch bump for@vitejs/plugin-vuelooks goodMinor patch upgrade stays within the supported range for Vite 6 / Vue 3.4.x and keeps the example aligned with the rest of the workspace. No action needed.
examples/vue/basic/package.json (1)
16-18: Patch bump for@vitejs/plugin-vuelooks goodSame patch-level upgrade as the other Vue examples; remains compatible with the current Vite + Vue stack. No further changes required.
examples/svelte/playground/package.json (1)
16-19: Svelte tooling patch upgrades LGTMAll bumped ranges stay within supported minor streams and remain compatible with existing scripts.
examples/svelte/basic/package.json (1)
18-21: Svelte devDependency bumps reviewedPatch-level updates only; no action required.
examples/svelte/star-wars/package.json (1)
16-22: Tailwind/Svelte version bumps approvedPatch upgrades for Svelte stack and Tailwind remain within current support policy.
packages/query-broadcast-client-experimental/package.json (1)
62-68: Dependency bump looks compatible
broadcast-channel@^7.1.0is still a minor bump with no breaking changes, and the dev tooling updates line up with the rest of the workspace. Looks good to me.packages/svelte-query-persist-client/package.json (1)
49-57: Svelte toolchain bumps look goodMinor upgrades across the Svelte toolchain land cleanly, and the existing peer range already covers the new svelte version so nothing else needs to move.
packages/svelte-query-devtools/package.json (1)
44-53: Dependency refresh confirmed
esm-envstays within a compatible minor range and the aligned Svelte tooling bumps match the rest of the workspace, so the update looks safe.packages/vue-query-devtools/package.json (1)
56-62: eslint-plugin-vue bump looks goodThanks for keeping this plugin aligned with the other Vue packages; the minor update is consistent and shouldn’t introduce surprises.
examples/react/offline/package.json (1)
22-24: Blocker: Declare the Node ≥ 18 requirement for this example.Upgrading
@vitejs/plugin-reactto ^4.7.0 (with Vite 6.3.x already in place) hard-requires Node 18+. Because this package.json still lacks an"engines"guard, installs on Node 16/17 will now fail at runtime. Please add the explicit engines hint (and ensure CI uses ≥18) before merging. This mirrors the unresolved feedback left earlier."type": "module", + "engines": { + "node": ">=18.0.0" + },examples/solid/solid-start-streaming/package.json (1)
12-19: Add missing@tanstack/query-coredependency to restore the vinxi buildThe verification agent already caught that the updated bundle now requires
@tanstack/query-core, and the build still fails to resolve it. Please add the dependency explicitly so the SSR build can complete.Apply this diff inside the
dependenciesblock:"@tanstack/solid-query": "^5.90.3", "@tanstack/solid-query-devtools": "^5.90.3", + "@tanstack/query-core": "^5.90.3", "solid-js": "^1.9.9", "vinxi": "^0.5.8"integrations/solid-vite/package.json (1)
9-14: Solid deps bump stays within supported ranges
solid-js1.9.9 andvite-plugin-solid2.11.8 remain compatible with Vite 6.3.x and the workspace Solid packages, so this update looks safe.packages/solid-query-devtools/package.json (1)
67-72: Devtools Solid stack versions alignedThe devDependency bumps keep everything on the latest Solid 1.9.x line and match the other Solid packages in the monorepo, with no peer range adjustments needed. Looks good.
examples/angular/router/package.json (1)
23-26: Ensure TypeScript meets Angular 20.3.x’s minimum version.
@angular/[email protected]requires TypeScript >= 5.9.0 < 6.0.0. The existing 5.8.3 will fail peer checks and breakngbuilds. Please bump it.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/rxjs/package.json (1)
23-26: Update TypeScript to satisfy Angular 20.3 toolchain peers.The new Angular 20.3.x packages expect TypeScript >= 5.9.0 < 6.0.0. Leaving 5.8.3 results in unmet peer dependency errors and broken builds. Please bump it to a compatible release.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/pagination/package.json (1)
22-25: Upgrade TypeScript to keep Angular 20.3 tooling functional.With the Angular packages now on 20.3.x, TypeScript must be within >= 5.9.0 < 6.0.0. Version 5.8.3 breaks installs/builds due to peer incompatibility. Please bump it.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic-persister/package.json (1)
24-27: Bump TypeScript to the Angular 20.3 compatible band.After upgrading the Angular stack to 20.3.x, TypeScript must be >= 5.9.0 < 6.0.0 per the compiler-cli peer range. Version 5.8.3 will cause install/build failures. Please update the pin.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic/package.json (1)
22-25: Raise TypeScript to the supported range for Angular 20.3.The Angular 20.3.x toolchain enforces a TypeScript peer range of >= 5.9.0 < 6.0.0. Keeping 5.8.3 will cause dependency resolution/build errors. Please update the version.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/devtools-panel/package.json (1)
23-26: Align TypeScript with Angular 20.3.x requirements.
@angular/[email protected]demands TypeScript >= 5.9.0 < 6.0.0. Keeping 5.8.3 leads to peer dependency mismatch andngcommand failures. Please upgrade the devDependency.- "typescript": "5.8.3" + "typescript": "^5.9.0"packages/angular-query-experimental/package.json (1)
92-102: Angular toolchain bump looks consistentAll updated dev dependencies stay aligned on the Angular 20.3.2 train and keep the ancillary tooling current. No further changes needed.
packages/query-async-storage-persister/package.json (1)
67-68: Version bump LGTMThe npm-run-all2 minor update integrates cleanly; no further changes needed.
examples/solid/basic-graphql-request/package.json (1)
13-21: LGTM on the GraphQL/vite-solid bumps
[email protected],[email protected], and[email protected]stay within the supported peer windows for this example. No additional changes needed.examples/react/devtools-panel/package.json (1)
17-17: Match the Node ≥20.19 engines guard here as well
Same@vitejs/plugin-react4.7.0 upgrade, same Node ≥20.19 requirement. Please replicate the engines/CI update fromexamples/react/simple/package.jsonso this package doesn’t run on Node 18.examples/react/suspense/package.json (1)
19-19: Apply the Node 20.19 runtime floor for the suspense example too
This example now depends on@vitejs/[email protected], so add the same"engines": { "node": ">=20.19" }guard (and bump any runners) to avoid Node-18 build failures.examples/react/default-query-function/package.json (1)
17-17: Default-query-function example also needs the Node ≥20.19 guard
Please add the engines field / CI bump here as well; the plugin-react 4.7.0 requirement applies to every React example.examples/react/chat/package.json (1)
17-19: Tailwind/Vite React combo still requires Node ≥20.19
With@vitejs/[email protected](and Tailwind v4’s Node ≥18 floor), we must enforce Node 20.19+ for this example as well. Mirror the engines + workflow updates from the other React packages.examples/react/basic-graphql-request/package.json (1)
19-19: GraphQL request example needs the same Node engines update
Please add"engines": { "node": ">=20.19" }(and adjust runners) so this package doesn’t attempt to build on Node 18 with the upgraded plugin.examples/react/basic/package.json (1)
23-23: Basic React example: enforce Node ≥20.19
Same@vitejs/[email protected]bump means the engines/CI guard is required here too.examples/react/simple/package.json (1)
17-17: Add Node engines ≥20.19 now that @vitejs/plugin-react 4.7.0 ships
v4.7.0 of@vitejs/plugin-reacthard-bumps its Node floor to 20.19 (or 22.12). We don’t pin an engines constraint or otherwise guarantee CI/dev shells meet that requirement, so installs/builds will break on the Node 18 runners we still use in parts of the repo. Please gate the example with an explicit engines field (and mirror the bump in CI images).{ "name": "@tanstack/query-example-react-simple", "private": true, "type": "module", + "engines": { + "node": ">=20.19" + }, "scripts": {Once added, align any workflows or containers that exercise this example to Node 20.19+.
examples/react/star-wars/package.json (1)
11-14: Drop legacy@mui/styleswhile upgrading to MUI 6Bumping to
@mui/material6.x while still depending on@mui/styleskeeps the example on the deprecated JSS runtime (makeStylesinsrc/Layout.tsx/src/Home.jsx). MUI 6 treats this path as legacy and it’s on the chopping block, so let’s migrate those components to thesx/styledAPIs and remove@mui/stylesbefore merging.
| "@angular/build": "^20.3.3", | ||
| "@angular/cli": "^20.3.3", | ||
| "@angular/compiler-cli": "^20.3.2", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
Raise TypeScript to Angular 20.3’s supported range.
Angular 20.3.x (CLI/compiler-cli) requires TypeScript >= 5.9.0 < 6.0.0. Keeping 5.8.3 causes peer dependency resolution to fail and ng commands to abort. Please bump the pinned version accordingly.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "5.8.3" | |
| "@angular/build": "^20.3.3", | |
| "@angular/cli": "^20.3.3", | |
| "@angular/compiler-cli": "^20.3.2", | |
| "typescript": "^5.9.0" |
🤖 Prompt for AI Agents
In examples/angular/optimistic-updates/package.json around lines 23 to 26, the
pinned TypeScript version is "5.8.3" which is outside Angular 20.3's supported
range (>=5.9.0 <6.0.0); update the TypeScript dependency to a version within
that range (for example "5.9.x" or a caret range like "^5.9.0") so peer
dependency resolution succeeds and Angular CLI/compiler-cli work correctly.
a5eb092 to
8548b9e
Compare
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (77)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/svelte/optimistic-updates/package.json
- examples/react/shadow-dom/package.json
🚧 Files skipped from review as they are similar to previous changes (51)
- examples/react/simple/package.json
- examples/react/playground/package.json
- examples/solid/basic-graphql-request/package.json
- examples/solid/default-query-function/package.json
- packages/solid-query/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/auto-refetching/package.json
- integrations/svelte-vite/package.json
- packages/eslint-plugin-query/package.json
- examples/react/rick-morty/package.json
- packages/solid-query-persist-client/package.json
- examples/react/basic/package.json
- examples/angular/pagination/package.json
- packages/vue-query-devtools/package.json
- examples/svelte/auto-refetching/package.json
- examples/vue/dependent-queries/package.json
- packages/query-persist-client-core/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- package.json
- examples/react/default-query-function/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-test-utils/package.json
- packages/svelte-query-persist-client/package.json
- examples/solid/astro/package.json
- examples/svelte/star-wars/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/basic/package.json
- examples/react/algolia/package.json
- examples/solid/simple/package.json
- integrations/solid-vite/package.json
- examples/react/suspense/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/router/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/rxjs/package.json
- examples/svelte/playground/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- packages/react-query-persist-client/package.json
- examples/vue/simple/package.json
- examples/react/chat/package.json
- examples/react/react-native/package.json
- packages/query-core/package.json
- examples/angular/basic/package.json
- examples/vue/basic/package.json
- integrations/react-vite/package.json
- integrations/react-webpack-5/package.json
- packages/angular-query-persist-client/package.json
- integrations/react-webpack-4/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-async-storage-persister/package.jsonpackages/svelte-query-devtools/package.jsonintegrations/react-next-15/package.jsonpackages/query-broadcast-client-experimental/package.jsonpackages/solid-query-devtools/package.jsonexamples/vue/persister/package.jsonpackages/react-query/package.jsonpackages/svelte-query/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/angular-query-experimental/package.jsonpackages/vue-query/package.jsonexamples/angular/basic-persister/package.json
🔇 Additional comments (26)
packages/query-async-storage-persister/package.json (1)
67-68: Dev dependency bump looks goodPatch update stays within the supported range and shouldn’t affect runtime consumers. All good here.
examples/vue/persister/package.json (1)
15-20: Dependency bump aligns with upstream patches.Updating
idb-keyvaland@vitejs/plugin-vueto the latest patch levels stays within the supported ranges and keeps the example current. No issues spotted.integrations/vue-vite/package.json (1)
13-14: Vue plugin patch upgrade looks good.The uplift to
@vitejs/plugin-vue^5.2.4 matches the rest of the workspace updates and remains compatible with the existing toolchain.packages/react-query/package.json (1)
73-79: Dev tooling bumps look solidThese version bumps track the latest patch/minor releases and remain compatible with our current React 19 / Vite setup. No action needed.
examples/react/react-router/package.json (1)
23-24: React 19 app must depend on React 19 type packagesThis example runs on React ^19.0.0 but still installs the React 18 type definitions. That mismatch breaks JSX/Concurrent features and causes TS compiler errors (e.g., new
use/actiontypes missing). Bump both type packages to the React 19 line.- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",packages/solid-query-devtools/package.json (1)
68-72: LGTM on the devDependency bumpsThe upgraded versions for
npm-run-all2,solid-js, andvite-plugin-solidstay within our existing peer range and mirror the rest of the workspace updates—no concerns here.packages/query-broadcast-client-experimental/package.json (1)
61-68: Broadcast-channel and tooling bumps LGTMMinor/patch bumps stay within supported ranges and don't require repo config changes.
packages/angular-query-experimental/package.json (1)
92-101: Angular/tooling bumps look goodThe devDependency upgrades to Angular 20.3.2 and the associated tooling remain compatible with the existing peer range (>=16) and don’t introduce conflicts here.
packages/vue-query/package.json (1)
66-66: Still need to move@vue/devtools-apiout of prod depsThis package is dev-only plumbing; keeping it under
"dependencies"keeps dragging it into consumers’ production bundles. Please relocate it (e.g. todevDependenciesor mark optional) and lazy-load its wiring as previously discussed.packages/svelte-query/package.json (1)
50-56: Svelte tooling patch bumps look goodAll version bumps stay within existing ranges and match the rest of the workspace updates, so no follow-up work needed on this package.json.
packages/svelte-query-devtools/package.json (1)
45-53: Aligned with workspace-wide Svelte tooling updatesThese dependency and devDependency bumps keep us on the latest patch releases and remain compatible with the declared peer ranges. Looks good.
examples/angular/query-options-from-a-service/package.json (1)
22-26: Upgrade TypeScript to meet Angular 20.3.x peer requirementsLine 26 keeps TypeScript at 5.8.3, but
@angular/[email protected]declares a peer of>=5.9.0 <6.0.0, so installs/builds will fail until we bump TS into that window.- "typescript": "5.8.3" + "typescript": "^5.9.3"examples/angular/simple/package.json (1)
21-25: Align TypeScript with Angular 20.3.x peer rangeLine 25 still pins TS 5.8.3, which is below the
>=5.9.0 <6.0.0peer dependency published by@angular/[email protected], so the example won’t compile until we raise the TypeScript version.- "typescript": "5.8.3" + "typescript": "^5.9.3"packages/query-devtools/package.json (1)
67-80: Solid stack bumps look good.All updated Solid-related deps line up with each other (solid-js ^1.9.9, matching peer windows for @kobalte/core, @solid-primitives/*, solid-transition-group, and vite-plugin-solid), so this should keep the devtools build happy.
examples/react/offline/package.json (1)
22-25: Still missing Node ≥18 guard for upgraded Vite stackUpgrading
@vitejs/plugin-reactalongsidevite@6keeps the Node ≥18 requirement in place, yet this package.json still lacks anengineshint (and CI hasn’t been updated either). Please add"engines": { "node": ">=18.0.0" }so installs on older Node fail fast, and mirror that in workflows.Here’s the patch for this file:
"devDependencies": { "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.3.6" }, + "engines": { + "node": ">=18.0.0" + },examples/angular/basic-persister/package.json (1)
24-28: Update TypeScript to a version supported by Angular 20.3.xAngular 20.3.x requires TypeScript >= 5.9.0 and < 6.0.0; keeping 5.8.3 will break the build. Please bump the pinned TypeScript version accordingly.
- "typescript": "5.8.3" + "typescript": "5.9.3"integrations/react-next-15/package.json (1)
9-9: No direct imports of@js-temporal/polyfilldetected
The codebase contains no CommonJS or ESM imports of this polyfill, so upgrading from 0.4→0.5 is unlikely to affect the Next 15 example—but please run the app to confirm no runtime breakage.examples/svelte/simple/package.json (1)
15-18: Svelte stack versions stay in lockstep—looks good.
@sveltejs/vite-plugin-svelte@^5.1.1now pairs with Svelte^5.39.6and Vite^6.3.6, which satisfies the plugin’s peer requirements. No further action needed.examples/svelte/basic/package.json (1)
17-21: Kit/Vite/Svelte bump is coherent.
@sveltejs/kit@^2.43.5, Svelte^5.39.6, and svelte-check^4.3.2align with the same Vite 6.3.x toolchain used elsewhere in the repo. 👍examples/svelte/ssr/package.json (1)
15-19: SSR example stays consistent with the updated Svelte toolchain.The new versions of Kit, Svelte, and svelte-check match the other Svelte examples and satisfy the known peer dependencies.
examples/vue/nuxt3/package.json (1)
13-13: Declare Nuxt’s Node engine requirementNuxt 3.19.2’s published package.json sets
engines.nodeto^20.19.0 || >=22.12.0. Leaving this example without a matching top-levelenginesconstraint lets contributors install with Node 18, after whichpnpm installfails once Nuxt’s engine check kicks in. Please mirror the requirement here so the tooling blocks incompatible runtimes up front."devDependencies": { "nuxt": "^3.19.2" - } + }, + "engines": { + "node": "^20.19.0 || >=22.12.0" + }examples/react/star-wars/package.json (3)
11-14: Migrate off @mui/styles for MUI v6/React 19; remove dependency.@mui/styles is legacy and not supported in MUI v6; refactor usages to
sxorstyledand drop the package.Apply this diff to remove the dependency (code changes to replace makeStyles are needed in source files):
"dependencies": { "@emotion/react": "^11.14.0", "@emotion/styled": "^11.14.1", - "@mui/material": "^6.5.0", - "@mui/styles": "^6.4.8", + "@mui/material": "^6.5.0",
19-20: React Router 6.30 bump is fine; quick route sanity recommended.No breaking config expected; just ensure routes still render as intended.
23-25: @vitejs/plugin-react 4.7.0 + Vite 6/TS 5.8 — OK.Looks compatible; no action needed.
examples/react/basic-graphql-request/package.json (2)
13-14: Approve dependency versions [email protected] peers graphql 14–16; 16.11.0 falls within this range.
19-20: Verify Node version ≥18 for local and CI
Vite 6.3.6 requires Node^18.0.0 || ^20.0.0 || ≥22.0.0; confirm your environments meet this.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
@vitejs/plugin-react 4.7.0 upgrade looks good; verify Vite/Node engines.
Peer range includes Vite 6; ensure CI/dev Node satisfies Vite 6 engines (>=18).
🏁 Script executed:
#!/bin/bash
# Inspect peer deps and engines
curl -s https://registry.npmjs.org/%40vitejs%2Fplugin-react/4.7.0 | jq '{version, peerDependencies, engines}'
curl -s https://registry.npmjs.org/vite/6.3.6 | jq '{version, engines}'Length of output: 249
Specify Node >=18 in engines and CI
Vite 6.3.6 requires Node ^18.0.0, so update your package.json “engines.node” to “>=18.0.0” and ensure your CI/development environments use Node 18 or higher.
🤖 Prompt for AI Agents
In examples/react/devtools-panel/package.json around lines 17 to 19, the package
uses Vite 6.3.6 which requires Node ^18.0.0; update the "engines.node" field to
">=18.0.0" in package.json and adjust any CI configuration or developer setup
scripts to use Node 18+ (for example update CI matrix or Node setup actions) so
builds run on a compatible Node version.
8548b9e to
0b11537
Compare
|
Sizes for commit 0b11537:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9628 +/- ##
=======================================
Coverage 46.38% 46.38%
=======================================
Files 214 214
Lines 8488 8488
Branches 1927 1930 +3
=======================================
Hits 3937 3937
Misses 4108 4108
Partials 443 443 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/angular-query-persist-client/package.json (1)
73-76: Consider bounding Angular peer ranges to avoid future-major breakage.Optional: narrow peers to <21 for safety until validated with Angular 21.
Apply:
- "peerDependencies": { - "@angular/common": ">=16.0.0", - "@angular/core": ">=16.0.0", - "@tanstack/angular-query-experimental": "workspace:^" - } + "peerDependencies": { + "@angular/common": ">=16.0.0 <21", + "@angular/core": ">=16.0.0 <21", + "@tanstack/angular-query-experimental": "workspace:^" + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/svelte/playground/package.json
- examples/react/offline/package.json
🚧 Files skipped from review as they are similar to previous changes (44)
- integrations/solid-vite/package.json
- packages/svelte-query/package.json
- packages/svelte-query-devtools/package.json
- integrations/react-vite/package.json
- integrations/vue-vite/package.json
- packages/solid-query/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/basic/package.json
- examples/solid/simple/package.json
- packages/query-persist-client-core/package.json
- examples/svelte/optimistic-updates/package.json
- examples/solid/default-query-function/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/react-native/package.json
- packages/query-test-utils/package.json
- examples/angular/rxjs/package.json
- examples/angular/pagination/package.json
- examples/react/star-wars/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/basic/package.json
- examples/svelte/star-wars/package.json
- examples/vue/simple/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/shadow-dom/package.json
- integrations/react-webpack-4/package.json
- examples/angular/router/package.json
- integrations/react-webpack-5/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query-devtools/package.json
- examples/react/chat/package.json
- examples/react/react-router/package.json
- examples/react/simple/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/simple/package.json
- examples/react/playground/package.json
- packages/react-query-persist-client/package.json
- packages/react-query/package.json
- examples/angular/basic-persister/package.json
- packages/eslint-plugin-query/package.json
- examples/vue/persister/package.json
- examples/react/algolia/package.json
- examples/react/suspense/package.json
- integrations/react-next-15/package.json
- examples/react/devtools-panel/package.json
👮 Files not reviewed due to content moderation or server errors (7)
- examples/solid/astro/package.json
- examples/svelte/ssr/package.json
- packages/query-sync-storage-persister/package.json
- packages/solid-query-persist-client/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/auto-refetching/package.json
- integrations/svelte-vite/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonpackages/solid-query-persist-client/package.jsonexamples/solid/astro/package.jsonexamples/solid/basic/package.jsonpackage.jsonpackages/vue-query/package.jsonpackages/query-async-storage-persister/package.jsonpackages/query-broadcast-client-experimental/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/angular-query-experimental/package.jsonpackages/react-query-next-experimental/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/angular-query-persist-client/package.jsonpackages/solid-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (22)
examples/vue/nuxt3/package.json (1)
13-13: Add engines.node to match Nuxt 3.19.x requirements.Nuxt 3.19 requires modern Node; add an engines field to prevent CI/runtime mismatches.
{ "name": "@tanstack/query-example-vue-nuxt3", "private": true, + "engines": { + "node": "^20.19.0 || >=22.12.0" + }, "scripts": { "dev": "nuxi dev",What Node.js version range is required by Nuxt 3.19.x?packages/query-async-storage-persister/package.json (1)
67-67: LGTM — dev-only tool bump.npm-run-all2 → ^5.0.2 is safe; workspace deps on query-core/persist-client-core are present. Based on learnings.
packages/vue-query/package.json (1)
66-66: Make @vue/devtools-api dev-only and lazy-load devtools to avoid prod bloat.Keeping devtools API in dependencies pulls it into consumer installs/bundles.
"dependencies": { "@tanstack/match-sorter-utils": "^8.19.4", "@tanstack/query-core": "workspace:*", - "@vue/devtools-api": "^6.6.4", "vue-demi": "^0.14.10" }, "devDependencies": { "@tanstack/query-test-utils": "workspace:*", + "@vue/devtools-api": "^6.6.4", "@vitejs/plugin-vue": "^5.2.4",Follow-up in code (not in this file):
- In src/vueQueryPlugin.ts, gate devtools behind NODE_ENV !== 'production' and dynamic import:
if (process.env.NODE_ENV !== 'production') (await import('./devtools/devtools')).setupDevtools(...).- Ensure devtools.ts imports @vue/devtools-api only inside the setup function.
packages/query-core/package.json (1)
63-63: LGTM — dev tooling version bump only.No impact on runtime or exports.
examples/vue/dependent-queries/package.json (1)
15-15: @vitejs/[email protected] peer/engine compatibility OK – supports Vite v6 & Vue 3; Vite 6.x requires Node 18+.examples/svelte/simple/package.json (1)
16-18: Approve Svelte toolchain bump
@sveltejs/[email protected]requires Vite >=6.2 & Svelte >=5.26; the upgrade to Vite 6.3.x and Svelte 5.39.x meets these requirements. Vite 6 supports Node 18, 20, and 22+.examples/svelte/basic/package.json (1)
18-21: Pin CI Node engine to ≥18.13 (Node 20+ recommended) for Vite 6.3.x/SvelteKit 2.43.x compatibility.packages/react-query-next-experimental/package.json (1)
61-63: Confirm Vite and Node compatibility@vitejs/[email protected] lists Vite peer: ^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 (so Vite 6.3.x is supported) and Vite 6.3.x requires Node ^18.0.0 || ^20.0.0 || >=22.0.0—ensure your Node runtime meets this.
examples/angular/infinite-query-with-max-pages/package.json (1)
25-26: Blocker: Angular 20.3 requires TypeScript ≥ 5.9.0 < 6.0.0Keeping 5.8.3 violates
@angular/[email protected]’s peer range and causesngcommands to fail. Please bump TypeScript into the supported window (e.g.,^5.9.0) before releasing.Apply this diff to resolve the blocker:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/auto-refetching/package.json (1)
25-26: Blocker: TypeScript 5.8.3 is incompatible with Angular 20.3.x
@angular/[email protected]insists ontypescript >=5.9.0 <6.0.0; pinning 5.8.3 will break installs/builds. Please lift the version to a supported 5.9.x release.Suggested fix:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/optimistic-updates/package.json (1)
26-27: Blocker: Update TypeScript to satisfy Angular 20.3 peer requirementsAngular 20.3.* refuses to work with TypeScript 5.8.3; the supported range starts at 5.9.0. Upgrade the pinned version so installs and
ngcommands succeed.Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/query-options-from-a-service/package.json (1)
26-27: Blocker: Align TypeScript with Angular 20.3’s required range
@angular/[email protected]peers againsttypescript >=5.9.0 <6.0.0; keeping 5.8.3 will fail peer resolution and CLI usage. Please bump into the ≥5.9.x range.Proposed change:
- "typescript": "5.8.3" + "typescript": "^5.9.0"packages/solid-query-devtools/package.json (1)
68-72: Solid bump looks good; peer range still compatible.Dev bumps to solid-js and vite-plugin-solid are fine. Peer range "solid-js": ^1.6.0 already covers 1.9.x.
examples/react/default-query-function/package.json (1)
17-19: Require Node ≥20.19 for @vitejs/plugin-react 4.7.0; add engines and align CI.Add engines.node and update CI to avoid install/build failures on older Node.
{ "name": "@tanstack/query-example-react-default-query-function", "private": true, "type": "module", + "engines": { + "node": ">=20.19" + }, "scripts": {packages/angular-query-experimental/package.json (1)
92-104: Angular 20.x dev bumps look consistent; workspace link to query-core present.Deps align, and "@tanstack/query-core": "workspace:*" is correctly declared. Based on learnings
examples/react/rick-morty/package.json (1)
11-24: Remove @mui/styles (deprecated; incompatible with React 19).This example targets React 19; @mui/styles is deprecated and not supported. Migrate usage to sx/@emotion/@mui/system and drop the dependency.
"dependencies": { "@emotion/react": "^11.14.0", "@emotion/styled": "^11.14.1", - "@mui/material": "^6.5.0", - "@mui/styles": "^6.4.8", + "@mui/material": "^6.5.0",Also ensure all imports from @mui/styles are removed in the example sources.
integrations/angular-cli-20/package.json (1)
11-27: TypeScript ~5.8.2 is incompatible with Angular 20.3.x. Bump to ≥5.9.x.Angular 20 requires TS >=5.9 <6.0. Update to avoid compiler/CLI errors.
"devDependencies": { "@angular/build": "^20.3.3", "@angular/cli": "^20.3.3", "@angular/compiler-cli": "^20.3.2", - "typescript": "~5.8.2" + "typescript": "^5.9.0" }package.json (1)
8-8: Blocker: pnpm 10.17.1 still breaks with our Node 24 toolchain
.nvmrccontinues to pin Node 24.x, but pnpm 10.17.1 hasn’t added Node 24 support yet (engines remain 18/20/22), so contributors hitUnsupported engineduring installs. Please either drop the packageManager pin back to a Node‑24–compatible build or realign the repo to a supported Node LTS before merging. The bot raised this earlier, and it’s still unresolved.Run this to confirm the mismatch and pick a remediation path:
#!/bin/bash set -euo pipefail echo ".nvmrc current value:" cat .nvmrc echo echo "[email protected] declared engines:" npm view [email protected] enginespackages/angular-query-persist-client/package.json (1)
60-64: Angular 20.3.x devDeps require compatible TS and Node in CI.Please ensure TypeScript >= 5.9 and CI Node is pinned to a supported version for Angular 20.x.
Run:
#!/bin/bash set -euo pipefail echo "Root TypeScript (if any):" if [ -f package.json ]; then jq -r '.devDependencies.typescript // .dependencies.typescript // "none"' package.json; fi echo echo "TypeScript versions across packages:" find . -name package.json -not -path "*/node_modules/*" -print0 | xargs -0 -I{} jq -r '"{} -> dev TS: \(.devDependencies.typescript // "-"), dep TS: \(.dependencies.typescript // "-")"' {} echo echo "CI workflows Node setup:" if [ -d .github/workflows ]; then rg -nI "actions/setup-node|node-version" .github/workflows || true; else echo "No workflows dir"; fi echo echo "Local Node pin (if any):" for f in .nvmrc .node-version .tool-versions; do [ -f "$f" ] && { echo "---- $f"; sed -n '1,120p' "$f"; }; doneAlso applies to: 68-71
examples/solid/basic/package.json (1)
13-13: Solid and plugin versions look good for the example.Matches the rest of the repo; no peer conflicts expected. LGTM.
Also applies to: 18-18
packages/query-devtools/package.json (1)
67-70: Solid ecosystem dependencies aligned; LGTM.
Installed solid-js ^1.9.9 satisfies [email protected] peerDependency (^1.7.2).examples/react/basic-graphql-request/package.json (1)
13-14: PeerDependencies verified
[email protected] requires graphql 14–16; ^16.11.0 satisfies it. @vitejs/[email protected] only peers on Vite. LGTM.
| "@types/react": "^18.2.79", | ||
| "@types/react-dom": "^18.2.25", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
🧩 Analysis chain
@vitejs/plugin-react 4.7.0 requires Node ≥20.19 (or ≥22.12). Verify engines/CI.
Installs/builds will fail on Node 18. Ensure engines.node and CI images use Node ≥20.19.
Run to audit engines and CI node versions:
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Root engines:"
jq -r '.engines // {}' package.json 2>/dev/null || true
echo
echo "Examples with missing/old engines.node:"
fd -a package.json examples | while read -r f; do
node_req=$(jq -r '.engines.node // ""' "$f")
if [[ -z "$node_req" || "$node_req" =~ ^(>=)?1[0-9] || "$node_req" =~ ^(>=)?20(\.[0-1][0-8])?(\.|$) ]]; then
echo "$f -> engines.node: ${node_req:-MISSING}"
fi
done
echo
echo "Workflows node setup:"
fd -H -t f -g '.github/workflows/*.yml' | xargs -r rg -n -C2 -e 'setup-node' -e 'node-version' -e 'matrix\.node'Length of output: 5066
Enforce Node ≥20.19 for builds
- Add
"engines": { "node": ">=20.19.0" }to root and all example package.json files. - Update .github/workflows setup-node steps to pin Node ≥20.19 (via
node-versionor matrix).
🤖 Prompt for AI Agents
In examples/react/basic/package.json around line 23, add an "engines": { "node":
">=20.19.0" } entry (and likewise add the same "engines" field to the repository
root package.json and every example package.json) so builds enforce Node
>=20.19; then update .github/workflows setup-node steps to pin Node to 20.19
(e.g., set node-version to "20.19" or "20.19.x" in the workflow or matrix) to
ensure CI uses the required minimum Node version.
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
5.2.1->5.38.0^20.0.0->^20.3.2^20.0.0->^20.3.3^20.0.0->^20.3.3^20.0.0->^20.3.2^20.0.0->^20.3.2^20.0.0->^20.3.2^20.0.0->^20.3.2^20.0.0->^20.3.2^20.0.0->^20.3.2^20.0.0->^20.3.2^0.15.3->^0.18.2^5.0.7->^5.1.1^8.1.3->^8.2.8^7.26.0->^7.28.4^7.24.9->^7.28.4^7.26.0->^7.28.3^7.25.9->^7.27.1^2.29.5->^2.29.7^11.13.5->^11.14.0^11.13.5->^11.14.1^10.0.5->^10.0.11^0.4.4->^0.5.1^0.13.4->^0.13.11^6.1.8->^6.5.0^6.1.8->^6.4.8^1.2.2->^1.5.2^2.0.26->^2.1.3^1.1.3->^1.2.0^2.42.2->^2.43.5^2.4.0->^2.5.4^4.0.14->^4.1.13^5.76.0->^5.90.2^10.4.0->^10.4.1^16.1.0->^16.3.0^2.0.0->^2.0.1^5.0.4->^5.0.5^8.44.0->^8.44.1^8.44.0->^8.44.1^8.44.0->^8.44.1^4.3.4->^4.7.0^5.2.1->^5.2.4^1.1.36->^1.3.13^6.6.3->^6.6.4^8.3.0->^8.4.1^7.0.0->^7.1.0^50.5.0->^50.8.0^6.0.0-rc.2->^6.0.0-rc1^3.11.0->^3.12.4^1.2.1->^1.2.2^52.0.11->^52.0.47^17.0.3->^17.1.7^2.0.0->^2.2.3^16.9.0->^16.11.0^7.1.2->^7.2.0^5.6.3->^5.6.4^6.2.1->^6.2.2^5.63.1->^5.64.0^2.6.6->^2.11.3^5.0.0->^5.0.2^3.12.4->^3.19.210.17.0->10.17.1^2.5.2->^2.6.0^0.76.3->^0.81.4^2.20.2->^2.28.0^5.12.5->^5.14.5^3.16.2->^3.19.1^4.12.0->^4.14.1^4.1.0->^4.16.0^0.19.13->^0.21.1^6.25.1->^6.30.1^6.25.1->^6.30.1^8.0.0->^8.4.0~7.8.0->~7.8.2^1.9.7->^1.9.9^0.2.3->^0.3.0^5.39.3->^5.39.6^4.3.1->^4.3.2^3.4.7->^3.4.17^4.0.14->^4.1.13^2.3.0->^2.8.1^0.5.3->^0.5.84.2.3->4.5.4^2.11.6->^2.11.8~0.15.0->~0.15.10.15.0->0.15.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
algolia/algoliasearch-client-javascript (@algolia/client-search)
v5.38.0Compare Source
composition&composition-full(#5333) by @ClaraMullerv5.37.0Compare Source
v5.36.0Compare Source
v5.35.0Compare Source
v5.34.1Compare Source
v5.34.0Compare Source
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.