chore(svelte-query): fix eslint config #9699

lachlancollins · 2025-09-27T13:41:18Z

🎯 Changes

It seems like parsing of .svelte.ts files has been broken this whole time. Amazing! This PR should fix this.

Reminder to myself to read the docs next time...

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

changeset-bot · 2025-09-27T13:41:22Z

⚠️ No Changeset found

Latest commit: c889017

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-27T13:41:25Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-eslint-config

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2025-09-27T13:41:51Z

View your CI Pipeline Execution ↗ for commit c889017

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	55s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	7s	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-27 13:43:19 UTC

pkg-pr-new · 2025-09-27T13:42:45Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9699

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9699

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9699

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9699

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9699

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9699

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9699

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9699

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9699

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9699

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9699

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9699

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9699

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9699

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9699

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9699

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9699

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9699

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9699

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9699

commit: c889017

github-actions · 2025-09-27T13:42:46Z

Sizes for commit c889017:

Branch	Bundle Size
Main
This PR

codecov · 2025-09-27T13:43:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.47%. Comparing base (367c06b) to head (c889017).
⚠️ Report is 955 commits behind head on svelte-5-adapter.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           svelte-5-adapter    #9699      +/-   ##
====================================================
+ Coverage             44.15%   45.47%   +1.32%     
====================================================
  Files                   171      196      +25     
  Lines                  6994     8312    +1318     
  Branches               1574     1899     +325     
====================================================
+ Hits                   3088     3780     +692     
- Misses                 3546     4090     +544     
- Partials                360      442      +82

Components	Coverage Δ
@tanstack/angular-query-experimental	`93.85% <ø> (+7.27%)`	⬆️
@tanstack/eslint-plugin-query	`83.24% <ø> (-3.07%)`	⬇️
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (∅)`
@tanstack/query-codemods	`0.00% <ø> (ø)`
@tanstack/query-core	`97.48% <ø> (+4.65%)`	⬆️
@tanstack/query-devtools	`3.48% <ø> (-1.76%)`	⬇️
@tanstack/query-persist-client-core	`79.60% <ø> (+21.87%)`	⬆️
@tanstack/query-sync-storage-persister	`84.61% <ø> (+2.11%)`	⬆️
@tanstack/query-test-utils	`77.77% <ø> (∅)`
@tanstack/react-query	`96.00% <ø> (+3.50%)`	⬆️
@tanstack/react-query-devtools	`10.00% <ø> (-0.72%)`	⬇️
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.06% <ø> (-0.15%)`	⬇️
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`71.10% <ø> (-0.33%)`	⬇️
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* WIP: Svelte 5 adapter (#6981) * feat(svelte-query): Improve svelte runes API (#8852) * feat: Draft proposal * chore: Improve reactive containers * ci: apply automated fixes * oops * fix: Update API, add a bunch of tests * merge main * fix: use const * more tests * feat: More tests, back to thunks, fixed svelte-query-persist-client * feat: More tests and examples! * lockfile * fixes * Fix current CI errors * More small fixes/tweaks * Remove test.only * ci: apply automated fixes * Fix pnpm-lock, fix import order * update main docs * feat: More tests * ci: apply automated fixes * add back old tests * Cleanup * Fix persist client * Fix useMutationState --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Lachlan Collins <[email protected]> * Use sleep from query-test-utils * Simplify test reset logic * Fix some merge conflicts * More fixes * A few more fixes * Fix useMutationState * Add changeset * Add migration docs * Replace Set with SvelteSet * Update minimum svelte version * Bump svelte-eslint-parser * Unwrap createQuery test * fix(svelte-query): `state_unsafe_mutation` error with `useIs...` (#9493) * fix(svelte-query): don't wrap observers in derived to avoid state_unsafe_mutation fixes useIsFetching and useIsMutating in svelte 5 adapter * test(svelte-query): wrap (useIs...) tests in QueryClientProvider to test non colocated query * fix(svelte-query): update observers when passed in query client changes * fix(svelte-query): simplify creatMutation sub/unsub * Refactor result handling in createMutation.svelte.ts Replace derived state with direct state and add watchChanges for result updates. --------- Co-authored-by: Lachlan Collins <[email protected]> * chore(svelte-query): fix eslint config (#9699) * chore(svelte-query): fix eslint config * Use @typescript-eslint/parser directly * ci: apply automated fixes * Fix sherif * Update docs and changeset * Update keywords --------- Co-authored-by: Zhiheng Zhang <[email protected]> Co-authored-by: Elliott Johnson <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: David <[email protected]>

lachlancollins added 2 commits September 27, 2025 23:36

chore(svelte-query): fix eslint config

ef5ff15

Use @typescript-eslint/parser directly

c889017

github-actions bot added package: svelte-query package: svelte-query-devtools package: svelte-query-persist-client labels Sep 27, 2025

lachlancollins merged commit 62be7d5 into svelte-5-adapter Sep 27, 2025
9 checks passed

lachlancollins deleted the fix-eslint-config branch September 27, 2025 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(svelte-query): fix eslint config #9699

chore(svelte-query): fix eslint config #9699

Uh oh!

lachlancollins commented Sep 27, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 27, 2025

Uh oh!

coderabbitai bot commented Sep 27, 2025

Review skipped

Uh oh!

nx-cloud bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Sep 27, 2025

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

codecov bot commented Sep 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore(svelte-query): fix eslint config #9699

chore(svelte-query): fix eslint config #9699

Uh oh!

Conversation

lachlancollins commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

changeset-bot bot commented Sep 27, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Sep 27, 2025

Review skipped

Uh oh!

nx-cloud bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Sep 27, 2025

Uh oh!

github-actions bot commented Sep 27, 2025

Uh oh!

codecov bot commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

lachlancollins commented Sep 27, 2025 •

edited

Loading

nx-cloud bot commented Sep 27, 2025 •

edited

Loading

codecov bot commented Sep 27, 2025 •

edited

Loading