Skip to content

Do not override pytest's report_collect #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Collaborator

@blueyed blueyed commented Nov 13, 2018

With 3.10.0 it will write "collecting ..." now always, and I think it is
good to see progress here.
This uses to be rather slow (because it printed a lot), which has been
fixed (only prints every 0.5s).

Ref: pytest-dev/pytest#4225

@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #165 into master will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #165     +/-   ##
=========================================
- Coverage   87.47%   86.58%   -0.9%     
=========================================
  Files           2        2             
  Lines         479      477      -2     
  Branches       85       85             
=========================================
- Hits          419      413      -6     
- Misses         35       39      +4     
  Partials       25       25
Impacted Files Coverage Δ
pytest_sugar.py 82.64% <ø> (-0.11%) ⬇️
test_sugar.py 96.35% <0%> (-2.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381cd0e...fa3310b. Read the comment docs.

With 3.10.0 it will write "collecting ..." now always, and I think it is
good to see progress here.
This uses to be rather slow (because it printed a lot), which has been
fixed (only prints every 0.5s).

Ref: pytest-dev/pytest#4225
@Teemu
Copy link
Owner

Teemu commented Nov 8, 2022

Hey 👋

Thank you for your PR! I am going through the old PRs in this repository and closing them since a long time has passed since the opening and they may not be that relevant anymore. If you still wish to continue with this pull request, let me know and we can re-open it.

Teemu

@Teemu Teemu closed this Nov 8, 2022
@Teemu Teemu reopened this Nov 8, 2022
@Teemu
Copy link
Owner

Teemu commented Nov 8, 2022

This actually seems simple enough that I might look into it myself

@Teemu
Copy link
Owner

Teemu commented Nov 8, 2022

Rebased to another PR so we can run CI ^

@Teemu Teemu closed this Nov 8, 2022
@blueyed blueyed deleted the report_collect branch November 9, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants