Added possibility to replace only the link text by the provided html … #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ added compile option, to support translations.
contextMenu.js
Outdated
| } else if (typeof item.text !== "undefined") { | ||
| } | ||
| else if (typeof item.html !== "undefined" && item.replaceTextByHtml) | ||
| { |
There was a problem hiding this comment.
This curly brace should be moved to previous line for consistency
|
Seems to look alright. I'll test it out in a little while. In the meantime, please check out some of the minor comments above. Also, what is the issue related to this? |
|
Hi, I restyled the curly braces. The reason I did them that way is to make it more readable, as it was getting cramped with code. As for what issue: none actually, I didn't made one, but I had some functionality added:
So for example, I need the following html inside the link tag: |
|
This feature definitely must be part of the master brach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…+ added compile option, to support translations.