Is power of two

[i-redbyte]

Checks if a number is a power of two

[siriak]

Thanks!

[tjgurwara99]

Very good use of bitwise operations. I would recommend you try to make the function names as succinct as possible without losing the readability.

[tjgurwara99]

LGTM 😄

[tjgurwara99]

I've marked it as approved but I still think the log function should be moved to the parent package. Up to you @siriak 😄

[siriak]

LGTM

[tjgurwara99]

Small change 😅 everything else is perfect 😄

[raklaptudirm]

Wouldn't it be better if we created a new sub-package under the math package, and put the files their? What are your opinions?

[i-redbyte]

Wouldn't it be better if we created a new sub-package under the math package, and put the files their? What are your opinions?

New subpackage for one function? I think this is redundant

[tjgurwara99]

Wouldn't it be better if we created a new sub-package under the math package, and put the files their? What are your opinions?

Could you elaborate on what you mean? If you are talking about moving just one function, then I think its not worth it - creates a lot of clutter. But if you mean to move all power of two functions in a sub package then I can see the benefits. Either way, could you elaborate? @raklaptudirm

[raklaptudirm]

I was saying that instead of moving the log based algorithm to another file as you had suggested, we could create a new sub-package under math and put all the functions there.

math/
 └─ powersOfTwo/
     └─ checkPowerOfTwo.go
     └─ checkPowerOfTwo_test.go

[i-redbyte]

I was saying that instead of moving the log based algorithm to another file as you had suggested, we could create a new sub-package under math and put all the functions there.

math/
 └─ powersOfTwo/
     └─ checkPowerOfTwo.go
     └─ checkPowerOfTwo_test.go

I am generally satisfied with both approaches, so that as most people decide, so I will do

[siriak]

I'm fine with either approach too :)

[tjgurwara99]

Ah ok, I guess this is a question of opinion so majority would rule. But I would say that the binary operation functions are good inside the binary directory but the algorithm that uses log doesn't necessitate a sub package in my opinion.

I guess my point would be that it depends on whether there would be other algorithms that would be added to the directory - personally I don't think there are any algorithms other than these algorithms that would go inside this subpackage - which is not a problem but it creates another layer of subdirectory for learners/explorers to browse through. We should try to keep the package structure as close to flat as possible unless there is a specific reason for creating separate package.

So I guess my vote would be a no to creating a subdirectory/subpackage for it 😅. But if @siriak and @raklaptudirm disagree then go ahead with a sub package approach 😄

[i-redbyte]

Ah ok, I guess this is a question of opinion so majority would rule. But I would say that the binary operation functions are good inside the binary directory but the algorithm that uses log doesn't necessitate a sub package in my opinion.

I guess my point would be that it depends on whether there would be other algorithms that would be added to the directory - personally I don't think there are any algorithms other than these algorithms that would go inside this subpackage - which is not a problem but it creates another layer of subdirectory for learners/explorers to browse through. We should try to keep the package structure as close to flat as possible unless there is a specific reason for creating separate package.

So I guess my vote would be a no to creating a subdirectory/subpackage for it 😅. But if @siriak and @raklaptudirm disagree then go ahead with a sub package approach 😄

Yes, it looks like the subpackage will be redundant

[tjgurwara99]

Could you move the test for the UseLog function to the parent math folder? do this dependent on whether other maintainers agree with my previous suggestion.

[i-redbyte]

Could you move the test for the UseLog function to the parent math folder? do this dependent on whether other maintainers agree with my previous suggestion.

Done

[i-redbyte]

So what do we decide in the end, gentlemen?

[siriak]

@raklaptudirm waiting on you :)

[raklaptudirm]

I was away for a bit, so could not reply earlier. All good. I am ok with the directory structure.