-
Notifications
You must be signed in to change notification settings - Fork 20.5k
refactor: Enhance docs, add tests in PrintMatrixInSpiralOrder
#6636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6636 +/- ##
============================================
- Coverage 75.74% 75.68% -0.06%
- Complexity 5765 5766 +1
============================================
Files 701 701
Lines 19757 19779 +22
Branches 3831 3841 +10
============================================
+ Hits 14964 14969 +5
- Misses 4214 4228 +14
- Partials 579 582 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @Hardvan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hardvan
I found that there are multiple PrintAMatrixInSpiralOrder
classes:
com.thealgorithms.matrix.PrintAMatrixInSpiralOrder
com.thealgorithms.others.PrintAMatrixInSpiralOrder
Please remove the duplicate class in the others
package and ensure that only one class remains in the matrix
package.
Also, move your updated class (with improved documentation) and the corresponding test file into the matrix
package so at the end there exists only one class in the matrix folder
clang-format -i --style=file path/to/your/file.java