Skip to content

Updated Comments on upper.py #10442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Updated Comments on upper.py #10442

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c032ab
Updated Comments on upper.py
its-100rabh Oct 14, 2023
cd26f8d
Update upper.py
its-100rabh Oct 14, 2023
02f4de1
Update upper.py
cclauss Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions strings/upper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ def upper(word: str) -> str:
'WH[]32'
"""

# Converting to ascii value int value and checking to see if char is a lower letter
# if it is a lowercase letter it is getting shift by 32 which makes it an uppercase
# case letter
# Converting to ASCII value, obtaining the integer representation
# and checking to see if the character is a lowercase letter.
# If it is a lowercase letter, it is shifted by 32, making it an uppercase letter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

88 characters per line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the code.

return "".join(chr(ord(char) - 32) if "a" <= char <= "z" else char for char in word)


Expand Down