Skip to content

Graphs/kruskal: adding doctest & type hints #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2020
Merged

Graphs/kruskal: adding doctest & type hints #3101

merged 5 commits into from
Oct 15, 2020

Conversation

meysam81
Copy link
Contributor

@meysam81 meysam81 commented Oct 9, 2020

Describe your change:

This is related to a previous comment by @cclauss
Here's the link

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@meysam81
Copy link
Contributor Author

@poyea
Could you take a look, please? It's been around for a while.

@cclauss cclauss merged commit 83b8250 into TheAlgorithms:master Oct 15, 2020
@meysam81
Copy link
Contributor Author

@cclauss
Thanks. Can I get a hacktoberfest-accepted please? 😃

@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 15, 2020
@meysam81 meysam81 mentioned this pull request Oct 16, 2020
Merged
14 tasks
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@meysam81 @stokhos
Graphs/kruskal: adding doctest & type hints (TheAlgorithms#3101)
b6ccf95 
* graphs/kruskal: add doctest & type hints

this is a child of a previous PR TheAlgorithms#2443

its ancestor is TheAlgorithms#2128

* updating DIRECTORY.md

* graphs/kruskal: fix max-line-length violation

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@meysam81
Graphs/kruskal: adding doctest & type hints (TheAlgorithms#3101)
c3e96d2 
* graphs/kruskal: add doctest & type hints

this is a child of a previous PR TheAlgorithms#2443

its ancestor is TheAlgorithms#2128

* updating DIRECTORY.md

* graphs/kruskal: fix max-line-length violation

* fixup! Format Python code with psf/black push

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meysam81 @cclauss